Re: [PATCH v3] mlxbf-bootctl: correctly identify secure boot with development keys

Ilpo Järvinen
2023-12-04T13:09:58Z

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

On Thu, 30 Nov 2023, David Thompson wrote:

> The secure boot state of the BlueField SoC is represented by two bits:
> 0 = production state
> 1 = secure boot enabled
> 2 = non-secure (secure boot disabled)
> 3 = RMA state
> There is also a single bit to indicate whether production keys or
> development keys are being used when secure boot is enabled.
> This single bit (specified by MLXBF_BOOTCTL_SB_DEV_MASK) only has
> meaning if secure boot state equals 1 (secure boot enabled).
>
> The secure boot states are as follows:
> - “GA secured” is when secure boot is enabled with official production keys.
> - “Secured (development)” is when secure boot is enabled with development keys.
>
> Without this fix “GA Secured” is displayed on development cards which is
> misleading. This patch updates the logic in "lifecycle_state_show()" to
> handle the case where the SoC is configured for secure boot and is using
> development keys.
>
> Fixes: 79e29cb8fbc5c ("platform/mellanox: Add bootctl driver for Mellanox BlueField Soc")
> Reviewed-by: Khalil Blaiech <kblaiech@nvidia.com>
> Signed-off-by: David Thompson <davthompson@nvidia.com>
> ---

> + } else if ((use_dev_key) &&
> + (lc_state == MLXBF_BOOTCTL_SB_LIFECYCLE_GA_SECURE)) {
> + return sprintf(buf, "Secured (development)\n");
> }

Thanks for the update. Applied to review-ilpo and will propagate into
fixes once LKP has built it.

I removed the unnecessary parenthesis around that use_dev_key while
applying the patch.

--
i.