From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB54C369970 for ; Mon, 27 Apr 2026 11:56:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777291015; cv=none; b=EpvybwMIxHOs0PLp6Y6B0ukas5XerfSNa3lR4+xxlwiV486cNzdwCqzu4eZR4Mbg5czOFUZUm/0BW8imHytKMc2mRbEJQAiW+5cUYYiEITVgAmyVZyeORuRXuhicJf8wkInO4GT/I3HXTtlYMpAxhaH++kC9rmLUM4LIfCZqu60= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777291015; c=relaxed/simple; bh=jMmdI5PjkkOv2fb/0b6eRHygdHRBUOV+ov32MF77QX0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KImtOL1b/rNCW4yj4/msL6QcP1rbkTZKqZA24TtaUwflAhuipQg0o2t2Cz5cBR/pRDVclsP9xri/MFnIQEidKo3gquXYOAWOcIdACx7RvNjDbGj13qBbp8UZwBqxzR2i+6PQLBUvOSCe3RWzVfPcoz5H27yiI6Sl05MlKdosLj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=o2PuXEyB; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6Of40lE6; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=o2PuXEyB; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=6Of40lE6; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="o2PuXEyB"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6Of40lE6"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="o2PuXEyB"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="6Of40lE6" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3649A5BCCD; Mon, 27 Apr 2026 11:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777291011; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ggqycDOgWocBnR/7hMuhm5n8WeCzm8oWPCHkBdVokhw=; b=o2PuXEyBkW3XsqwpYWNp8Z0sxW45qskODJTL3uaKKmlaNSmljc8VBbuEUqaKF7ALi7h6VA ywXiGEx54BJwj4zOzt7L12um84pN93D8SWCC42MT666sxCwuEDqzP5/VsRFj5+lZmXBpRx NM5jxljienGUzSy5jbZbNjC3iGw1siY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777291011; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ggqycDOgWocBnR/7hMuhm5n8WeCzm8oWPCHkBdVokhw=; b=6Of40lE6XJX2/NnANAwnlHHP9e8oDBho6+uj4ueHgPUPDAv3zR1jCOTwTp7UqObc04n1fA 8rbAaFkRubbsHPDg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=o2PuXEyB; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6Of40lE6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777291011; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ggqycDOgWocBnR/7hMuhm5n8WeCzm8oWPCHkBdVokhw=; b=o2PuXEyBkW3XsqwpYWNp8Z0sxW45qskODJTL3uaKKmlaNSmljc8VBbuEUqaKF7ALi7h6VA ywXiGEx54BJwj4zOzt7L12um84pN93D8SWCC42MT666sxCwuEDqzP5/VsRFj5+lZmXBpRx NM5jxljienGUzSy5jbZbNjC3iGw1siY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777291011; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ggqycDOgWocBnR/7hMuhm5n8WeCzm8oWPCHkBdVokhw=; b=6Of40lE6XJX2/NnANAwnlHHP9e8oDBho6+uj4ueHgPUPDAv3zR1jCOTwTp7UqObc04n1fA 8rbAaFkRubbsHPDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 001E2593B0; Mon, 27 Apr 2026 11:56:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bq5tOgJP72lmdwAAD6G6ig (envelope-from ); Mon, 27 Apr 2026 11:56:50 +0000 Message-ID: Date: Mon, 27 Apr 2026 13:56:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/7] scsi: scsi_devinfo: extend BLIST_NO_LUN_1F to MATSHITA and NEC PD-1 variants To: Phil Pemberton , linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Damien Le Moal , Niklas Cassel , "James E . J . Bottomley" , "Martin K . Petersen" References: <20260426190920.2051289-1-philpem@philpem.me.uk> <20260426190920.2051289-8-philpem@philpem.me.uk> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20260426190920.2051289-8-philpem@philpem.me.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email,philpem.me.uk:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 3649A5BCCD On 4/26/26 21:09, Phil Pemberton wrote: > The Panasonic LF-1095/LF-1195 PD/CD combo drive was sold under three > OEM identities: COMPAQ "PD-1", MATSHITA "PD-1", and NEC "PD-1 ODX654P". > All three are the same drive mechanism with the same firmware family, > so they should share the BLIST_NO_LUN_1F quirk that was applied to the > COMPAQ variant: PDT 0x1f / PQ 0 INQUIRY responses on non-existent LUNs > are treated as "LUN not present" rather than as a phantom sdev. > > This patch is offered for completeness. It has not been tested on the > MATSHITA or NEC variants -- the author only has access to the COMPAQ > unit -- but the drives are functionally identical and the flag is a > no-op on devices that do not exhibit the PDT 0x1f response. Drop or > hold this patch if confirmation on real hardware is preferred before > extending the quirk. > > Signed-off-by: Phil Pemberton > --- > drivers/scsi/scsi_devinfo.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c > index bfc2cbd43897..ab1ffa9433b7 100644 > --- a/drivers/scsi/scsi_devinfo.c > +++ b/drivers/scsi/scsi_devinfo.c > @@ -201,7 +201,8 @@ static struct { > {"LASOUND", "CDX7405", "3.10", BLIST_MAX5LUN | BLIST_SINGLELUN}, > {"Marvell", "Console", NULL, BLIST_SKIP_VPD_PAGES}, > {"Marvell", "91xx Config", "1.01", BLIST_SKIP_VPD_PAGES}, > - {"MATSHITA", "PD-1", NULL, BLIST_FORCELUN | BLIST_SINGLELUN}, > + {"MATSHITA", "PD-1", NULL, BLIST_FORCELUN | BLIST_SINGLELUN | > + BLIST_NO_LUN_1F}, > {"MATSHITA", "DMC-LC5", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36}, > {"MATSHITA", "DMC-LC40", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36}, > {"Medion", "Flash XL MMC/SD", "2.6D", BLIST_FORCELUN}, > @@ -212,7 +213,8 @@ static struct { > {"nCipher", "Fastness Crypto", NULL, BLIST_FORCELUN}, > {"NAKAMICH", "MJ-4.8S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN}, > {"NAKAMICH", "MJ-5.16S", NULL, BLIST_FORCELUN | BLIST_SINGLELUN}, > - {"NEC", "PD-1 ODX654P", NULL, BLIST_FORCELUN | BLIST_SINGLELUN}, > + {"NEC", "PD-1 ODX654P", NULL, BLIST_FORCELUN | BLIST_SINGLELUN | > + BLIST_NO_LUN_1F}, > {"NEC", "iStorage", NULL, BLIST_REPORTLUN2}, > {"NRC", "MBR-7", NULL, BLIST_FORCELUN | BLIST_SINGLELUN}, > {"NRC", "MBR-7.4", NULL, BLIST_FORCELUN | BLIST_SINGLELUN}, Any specific reason why this patch is not merged with the previous one? Otherwise: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich