Re: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems of resets for Cadence OSPI controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 27/05/2025 08:05, Mahapatra, Amit Kumar wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
>> Subject: Re: [PATCH v2] spi: dt-bindings: cdns,qspi-nor: Update minItems/maxItems
>> of resets for Cadence OSPI controller
>>
>> On 26/05/2025 09:07, Mahapatra, Amit Kumar wrote:
>>>>>    - if:
>>>>> @@ -132,11 +139,11 @@ properties:
>>>>>      maxItems: 1
>>>>>
>>>>>    resets:
>>>>> -    minItems: 2
>>>>> +    minItems: 1
>>>>
>>>> I think you're still missing one of the things Krzysztof requested on
>>>> v1, cos you reduce minItems for all platforms without restricting it
>>>> back to 2 for non-versal platforms.
>>>
>>> I believe we can remove the "resets" and corresponding "reset-names"
>>> properties from here, as their default minItems/maxItems are already
>>> taken care of in the else block [1].
>>>
>>> [1]
>>> https://github.com/torvalds/linux/blob/0ff41df1cb268fc69e703a08a57ee14
>>> ae967d0ca/Documentation/devicetree/bindings/spi/cdns%2Cqspi-nor.yaml#L
>>> 39
>> I don't see anything fixed there.
> 
> The intention was to point out the redundancy related to the 'resets' and
> 'reset-names' properties. At [1], the default minItems and maxItems values
> are already defined for all platforms. However, the same constraints are
> redefined at [2] with different minItems and maxItems values , again
> applying to all platforms. Based on my understanding, the definitions at
> [2] for 'resets' and the corresponding 'reset-names' can be safely
> removed.
It is not about redefining. You need to constrain your properties. They
have to be fixed, not flexible.

Best regards,
Krzysztof