From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes
Date: Wed, 27 Apr 2016 16:40:05 +0200 [thread overview]
Message-ID: <c1fc599c-875b-8b61-23c2-de775d95201f@redhat.com> (raw)
In-Reply-To: <20160427143711.GT3217@sirena.org.uk>
Hi,
On 27-04-16 16:37, Mark Brown wrote:
> On Wed, Apr 27, 2016 at 04:31:02PM +0200, Hans de Goede wrote:
>> On 27-04-16 16:24, Mark Brown wrote:
>
>>> The regulator API should not touch any regulators that it doesn't have
>>> permission to change the state for. All other regulators are strictly
>>> read only.
>
>> How do we give permission to change state ? Is omitting the dts node,
>> and thus not returning a node / constrains from regulator_of_get_init_data
>> enough for the regulator API to not have permission ?
>
> Yes, omit the DT node or mark it always on at the minute.
Or, since regulator_of_get_init_data uses for_each_available_child_of_node
which checks the "status" value we can actually already use
"status=disabled" cool. So this simply already works :)
Regards,
Hans
next prev parent reply other threads:[~2016-04-27 14:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 14:03 [PATCH resend 0/2] regulator: core: Allow use of "status = disabled" in regulator dts nodes Hans de Goede
2016-04-27 14:03 ` [PATCH 1/2] " Hans de Goede
2016-04-27 14:24 ` Mark Brown
2016-04-27 14:31 ` Hans de Goede
2016-04-27 14:37 ` Mark Brown
2016-04-27 14:40 ` Hans de Goede [this message]
2016-04-27 15:01 ` Mark Brown
2016-04-27 15:50 ` Maxime Ripard
2016-04-27 15:52 ` Hans de Goede
2016-04-27 15:54 ` Hans de Goede
2016-04-27 16:32 ` Mark Brown
2016-04-27 14:03 ` [PATCH 2/2] regulator: axp20x: Handle regulator_register returning ENODEV Hans de Goede
2016-04-27 14:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1fc599c-875b-8b61-23c2-de775d95201f@redhat.com \
--to=hdegoede@redhat.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).