Re: [BK PATCH] SCSI host num allocation improvement

Mike Anderson
2004-02-27T16:35:32Z

Ben Collins [bcollins@debian.org] wrote:
> static void scsi_host_cls_release(struct class_device *class_dev)
> {
> + down(&host_num_lock);
> + idr_remove(&allocated_hosts, class_to_shost(class_dev)->host_no);
> + up(&host_num_lock);
> put_device(&class_to_shost(class_dev)->shost_gendev);
> }
>

Should the idr_remove be done in scsi_host_dev_release instead? We
really should not make this number available until everyone is done with
this host.

-andmike
--
Michael Anderson
andmike@us.ibm.com