From: David Woodhouse <dwmw2@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Boqun Feng <boqun.feng@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v2] lockdep: add lockdep_cleanup_dead_cpu()
Date: Sun, 29 Oct 2023 17:47:52 +0000 [thread overview]
Message-ID: <c20ead65f61a2609a0a80d7692aed0c74886b238.camel@infradead.org> (raw)
In-Reply-To: <87o7ghz63l.ffs@tglx>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
On Sun, 2023-10-29 at 18:33 +0100, Thomas Gleixner wrote:
> On Sat, Oct 28 2023 at 20:24, David Woodhouse wrote:
> > @@ -24,12 +24,16 @@
> > extern void lockdep_hardirqs_on_prepare(void);
> > extern void lockdep_hardirqs_on(unsigned long ip);
> > extern void lockdep_hardirqs_off(unsigned long ip);
> > + extern void lockdep_cleanup_dead_cpu(unsigned int cpu,
> > + struct task_struct *idle);
>
> Lacks a forward declaration of 'struct task_struct'
>
Apparently so; I thought that was fairly much ubiquitous. Was debating
spamming you with a v3 in the space of as many days, or perhaps
revisiting my decision to *pass* the idle task out of kernel/cpu.c.
We could always shift the declaration of idle_thread_get() out to
linux/smpboot.h and let the lockdep code call it directly. You already
reviewed my patch to do that, although it was dropped in the end.
https://lore.kernel.org/lkml/20230321194008.785922-2-usama.arif@bytedance.com/
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
next prev parent reply other threads:[~2023-10-29 17:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 11:14 [PATCH] lockdep: add lockdep_cleanup_dead_cpu() David Woodhouse
2023-10-28 14:13 ` Thomas Gleixner
2023-10-28 17:14 ` kernel test robot
2023-10-28 19:24 ` [PATCH v2] " David Woodhouse
2023-10-29 10:05 ` kernel test robot
2023-10-29 17:33 ` Thomas Gleixner
2023-10-29 17:47 ` David Woodhouse [this message]
2023-10-30 8:45 ` [PATCH v3] " David Woodhouse
2024-09-24 14:20 ` David Woodhouse
2024-09-26 12:09 ` Boqun Feng
2024-09-26 12:16 ` David Woodhouse
2024-09-26 12:34 ` Boqun Feng
2024-09-26 14:34 ` David Woodhouse
2024-09-26 15:13 ` Boqun Feng
2024-09-26 15:38 ` David Woodhouse
2023-10-30 16:37 ` [PATCH v2] " kernel test robot
2023-10-30 11:17 ` [PATCH] " Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2024-09-26 15:17 [PATCH v2] " David Woodhouse
2024-09-26 16:09 ` Boqun Feng
2024-09-26 16:37 ` David Woodhouse
2024-09-27 0:45 ` Boqun Feng
2024-09-27 8:45 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c20ead65f61a2609a0a80d7692aed0c74886b238.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=boqun.feng@gmail.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).