From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Rui Salvaterra <rsalvaterra@gmail.com>, tiwai@suse.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: hda: Replace numeric device IDs with constant values
Date: Mon, 22 Jan 2024 12:51:03 +0100 [thread overview]
Message-ID: <c21377fb-da4c-4cdb-994c-e469d4cb1e46@linux.intel.com> (raw)
In-Reply-To: <20240122114512.55808-2-rsalvaterra@gmail.com>
On 1/22/2024 12:45 PM, Rui Salvaterra wrote:
> We have self-explanatory constants for Intel HDA devices, let's use them instead
> of magic numbers and code comments.
>
> Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
> ---
> sound/pci/hda/hda_intel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 2276adc84478..66f013ee160d 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -1729,8 +1729,8 @@ static int default_bdl_pos_adj(struct azx *chip)
> /* some exceptions: Atoms seem problematic with value 1 */
> if (chip->pci->vendor == PCI_VENDOR_ID_INTEL) {
> switch (chip->pci->device) {
> - case 0x0f04: /* Baytrail */
> - case 0x2284: /* Braswell */
> + case PCI_DEVICE_ID_INTEL_HDA_BYT:
> + case PCI_DEVICE_ID_INTEL_HDA_BSW:
> return 32;
> }
> }
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
next prev parent reply other threads:[~2024-01-22 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 11:45 [PATCH 1/2] ALSA: hda: Replace numeric device IDs with constant values Rui Salvaterra
2024-01-22 11:45 ` [PATCH 2/2] ALSA: hda: Increase default bdl_pos_adj for Apollo Lake Rui Salvaterra
2024-01-22 11:51 ` Amadeusz Sławiński
2024-01-22 11:51 ` Amadeusz Sławiński [this message]
2024-01-23 7:51 ` [PATCH 1/2] ALSA: hda: Replace numeric device IDs with constant values Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c21377fb-da4c-4cdb-994c-e469d4cb1e46@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox