From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753202AbdJLQfd (ORCPT ); Thu, 12 Oct 2017 12:35:33 -0400 Received: from g9t1613g.houston.hpe.com ([15.241.32.99]:21765 "EHLO g9t1613g.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbdJLQfb (ORCPT ); Thu, 12 Oct 2017 12:35:31 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=mike.travis@hpe.com; Subject: Re: [PATCH 2/5] x86/kernel: Skip TSC test and error messages if already unstable To: Thomas Gleixner CC: Peter Zijlstra , Ingo Molnar , "H. Peter Anvin" , Bin Gao , Prarit Bhargava , Dimitri Sivanich , Andrew Banman , Russ Anderson , , References: <20171005164716.233817374@stormcage.americas.sgi.com> <20171005164716.507003714@stormcage.americas.sgi.com> <726db3a9-3607-3105-770a-d5e5927b1874@hpe.com> From: Mike Travis Message-ID: Date: Thu, 12 Oct 2017 09:35:20 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.48.179.6] X-ClientProxiedBy: CY4PR0601CA0078.namprd06.prod.outlook.com (52.132.96.147) To DF4PR84MB0185.NAMPRD84.PROD.OUTLOOK.COM (10.162.193.14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2fa94b01-ca7f-46b8-0ad6-08d5118f3f18 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DF4PR84MB0185; X-Microsoft-Exchange-Diagnostics: 1;DF4PR84MB0185;3:dFB4tGhsSg+wPi3Ijt849O9cuCKSF1uRZafdtSUwuiZupMmbZ8m/wMxmJ0XggeNyYBT9Hq7k6APdDXOnu/9aEG30P1Zo7UwF8gFlaHnpuOIa2jWPuveJfMW1X9yurWm9b/Ygpkzo6J0sMDLzm29HMRvhDT41PD8CY42BMboYBckgyYrEL1q5rwbzPohDQSaIja47RXqa4/1V0RdVz/VXXnXeiQN4QHDZFVT2Dnj0FQzEVKbQvQSpFXKq9yJuOTQq;25:6dxTp9zYPEM1rEnxpfNuOEoa/yOUx0j/qDQxCrupu9APFZsVOa02RVsffkofZzta3rdG44CXrwZnqAs+zSwOLTQgM4sOMHBps7x8Y9CX5ZFDced1SnuyeKHf2VK6VpMQZSTBSoGGuZWKN++SZoInuS2qFDY4Y7c4msh2sLSqjsNBGY8shNSLwclkfbzX6k4DK42ZwHG/KQlYkKrk/H8vnS9p9Rr0vyTOho/c9Z7gxobQ8NgDvRiLGXrLdoiFgp6mqKsZqJMo2OIL8aceYsbGDW6GFOFaj36etB68oJjDk8Y7A43TN9MJ3B4p+ppk5YjfAgmBj2RSC1sSqjL6s2PUhWV1rT/PmX4UIMD2vua3QZ8=;31:TuoBcDvWSAL3eaw0PKnn11Zi47TmhgQ9I94iPY81JL3YJKyquk9gsNUU8bzYKBVFmlBpACEGpN0ZGR+ditUcf0PJWqiZN+y1c54550loT2DeN/+ep8BqOqZryEzQFrr0Hw3RtNVrj771xeccEIvjju/hgy4rut2ApSYlYAH5DvetNVKJ8yBC+Zu2tQ/tPB6KAP5BnX6IL1at5hjbx6Br68VYYVRECvjdviK8RPj1pgo= X-MS-TrafficTypeDiagnostic: DF4PR84MB0185: X-Microsoft-Exchange-Diagnostics: 1;DF4PR84MB0185;20:WQJ7G/yvRVqyO1pIh0OSJsDYkACxPawF+AUoDkLUpQcX3HK8oSeeuyZMSOKBonQ/389KqeaugjeWGhtBqylHgl0DfA9osCbKddooNKxCo3D2HYi7kXJbyrhgMkvXEp0FJw56WIkUpSxyCUmlEtVBnsTNB/c5mghRcqhnjy25QT7clfWsn/V12KfwZa/5G/RlB0eaj1KjN2zv2fy7gWIzTvyg3Z95nxrq+bYjThwrQaI2gn1diomhNq0LVyA+CghpvTvWLsY/nxHO54lD9AUg/s6gQoGTNa9+f45HyCXJz/o+8bokrOXd/5IjNcb2v1z8zU4yK3v5Ch05NONwSfDvWcjmKFDCQWTo70cFUD2M2lVINTCJr0esFm9r/xj9Bimwj4KBinfr3KYdstt+L3HO/xELoAUxOSiw7dYd0exjy4nurVI2U3ZZQwn0vkPo3ZgTVUCuPwOKJwsVd5buzu0UTt0APw3TRSiG2GSKKQ8dcJhFNwfM0yW7kG6rZVEf0Ouy;4:yTdz32Q8zVn8E9V9n3lBzNW1yUi1D6DJv38G/9wl5TuXlZQQZ2qMErN8Qdq4BNfw+i6n2e9gojsQ4iu6K90KjOBhkunA3wXCXcMkC7C3MDrj9/ihUzGXiBBbqdVDFNUL0czH+Quwj79w3wGMhjOo16MerEz5AerAqjWSmO8RUw2Tfnxd1Sjbs3Vz8rc67M9n36bCNN0GKNoqBjsPQIF0vYDOGJAiQKv+Z4zw2WOKqwqPcdNWaYBEeJgaNF4PGCH89aX+oeGiTO+JDi1yqB0kDzozSJqcctCiE1jp5P9HWc0= X-Exchange-Antispam-Report-Test: UriScan:(227479698468861); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0185;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0185; X-Forefront-PRVS: 04583CED1A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6049001)(6009001)(376002)(346002)(39860400002)(24454002)(377454003)(199003)(189002)(50466002)(3846002)(68736007)(7736002)(93886005)(36756003)(83506001)(16576012)(316002)(2906002)(54906003)(97736004)(305945005)(50986999)(8676002)(105586002)(81166006)(106356001)(76176999)(64126003)(58126008)(230700001)(6486002)(229853002)(33646002)(53546010)(54356999)(81156014)(16526018)(47776003)(101416001)(49976008)(5660300001)(31686004)(65956001)(189998001)(66066001)(478600001)(8936002)(86362001)(6116002)(6666003)(65806001)(65826007)(15650500001)(4326008)(53936002)(3260700006)(6916009)(6246003)(23746002)(25786009)(31696002)(2950100002)(78286006);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0185;H:[134.15.1.45];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DF4PR84MB0185;23:IIS2MLegGVPnF1SylVq5auJRRjbFxboVlIwgs?= =?Windows-1252?Q?zj9gbD0YQGieFKI4dxkPB5vl8wgQfzdJStrFLMnsj8tPXMJc7slZDPbj?= =?Windows-1252?Q?OIiTe37Iuyn2LXCNyohvbdqD12b1UXGD97g3Qhyz6JJSNi0QeX/8wULH?= =?Windows-1252?Q?e9BMfYrKqLbuGdLoEp/fU8UknKKfGZOGKlMn529cAY/yGYId9U1sDRVM?= =?Windows-1252?Q?/uSLwX0DF26NvmJjRktb+uyLdCNFwc48NuGNYsxHdE6oki9A8LGRNe18?= =?Windows-1252?Q?hR0OAxaPCtx7QqcD3sqcp3BnpH8ChiB1nMw4O9nIRlRcujWMa2clNk2E?= =?Windows-1252?Q?Xfs7tXNl36A9MLb9MSReXAnkvsBKKcdF+MxRwleL+A0IO9wpd5Ie6eaX?= =?Windows-1252?Q?4CdDFon/zntJFrnURysH5F7a+KW1t+EtaVQeMTeL3+5gHEpVeB71Enl7?= =?Windows-1252?Q?RzqfQGTTeeNHDJgN7Xx7X62wj+c87n2tUgshXkugmaHHcRlC0AhEnI/c?= =?Windows-1252?Q?6RjYvdFsW+AY1qxCMxzboQG6jbTEf5guCal6CEQMzZP8yUXdlnOlFZ8i?= =?Windows-1252?Q?62O5vpJjdrq8PF4ELBrzEBDPgyUmLTrDfehGhPPWh89E+tothnE3jVIV?= =?Windows-1252?Q?gR2oddYqALshZtFBfmEzl2un8/hAj0xQ+QGLtQdtLkN0NfaWG54Ap3Or?= =?Windows-1252?Q?D9dVKb03t9NVjkRFUKXZNm7jM9l054Y2/rjiLXZjcSztKf+Kfmq55fpM?= =?Windows-1252?Q?memOcBN1Fm+zAz0D3/0Fu4GqovwT4zfYz2iduhhOVdYLdcUF6KUUVKWS?= =?Windows-1252?Q?GtMf7dcbvR4BbFmMKjbuMCuhvoegf3c0pwQ51d0UL7JwsnIBEAaP26Fn?= =?Windows-1252?Q?mZ4FCPvkYhoP6thXoNjKVEIyFZVnywG37CF10oKrjptPt17XBXh+U/gl?= =?Windows-1252?Q?qMvz+8WDafSR8if9F07TpQF5qKShs4jpyCTowe1vva35Equ2utmWRdPL?= =?Windows-1252?Q?2k6ZAdDMKOAJ365lmXrdqoZMT8rt8X0Ph4Cua/hVFN2Ltmi4Tbc/jLFM?= =?Windows-1252?Q?95tYj6JGofqXtXydgbqhmZmYldgGUx1hJGGI5aFxgEaHeas+MjMDcjVB?= =?Windows-1252?Q?o7t5ReeBnUuWXR0vdFSAbOeAwn/WGDio9/WqX8x2V83rF/tpfsdsB4Qi?= =?Windows-1252?Q?MGjMCoj8k8RTXOzhR6X8IdNfXFgMDNx/RHW3orWqCjnCx+05GkFFoyLn?= =?Windows-1252?Q?Bf2EhPktLmZX6hJogTw1U3KeGUon7XaBKZoSe34OwfXN5iORWMyCw1dC?= =?Windows-1252?Q?eatOmRa9oBEU/CQ3fhMCynvseUmMosgJIh2JI3qXJe+JXQO6WGcwS2DK?= =?Windows-1252?Q?xVrZFOiqWDFd2KVzn0P1KfP8zpAghUu0bw7CaW5WML+LSLbGqtn0ddwv?= =?Windows-1252?Q?L+VAsuN2ilIorDgZtaURUk31VKEqlp0Pwo/YOfNKjTqBrxbqWzo16TG7?= =?Windows-1252?Q?JXEBj4XKYvIsIarlJodlY1nS45uNPBd1IaQEFTjQLFWzP06RrWpJIy8r?= =?Windows-1252?Q?bdozoAhxkC3nw+uINfABs128SWf4JXrs6A7qVdAYF2DtRF//Ur+fQgMr?= =?Windows-1252?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1;DF4PR84MB0185;6:ZUvPkCO1bfwVsLnMeLPU6+CVrbOQDiwnUFT5wKp1lSEyVYraZ75jUnRt3CiJSLbDuxQjGztvQ+Gqr6e4iHGIOzI7FSctt1/pS0cYW1vmytmd+vxhOBT2/i4rKsBQXnUuGMEYwSnJIfJFT4BrqxQUb0NOCUqOCADm65X9L8Ig+Ns93X+osGaz+Og7KXQUYVos/kAJlUM79ihOeN8OGVvuGAzMA2lDUXi2xmijL2PHAdv+YKFeTf2rLsipwNozjdtMWCsEGnnedLoEdwM0oRI4VTfdSdfP2BKxPVty3yX4EgHGBKu8ZNDziwRD/FFkKUINCmeRySrJ1SoE9/oewGXvRg==;5:J4wK+wuvbK1Ctg8ek3fDsElL4xRqYIPsRE0E6hCALkZBPa1X0JyMZ+q5l8MLti8/r2fu+eUh0IiPxfUOFpg3v4/RlSZqfYGuBYbgUsZwQFSZm7fksMB5wild15Hg9tKKRTHecjHiaBfOjL+hOYp4XQ==;24:+frt4d45I91dppIcLaRO+PVrJplN9CMDJOg4MMo9DbJDaJ6DgWCc2jWiOMwYkkEJv8vecJYDQtUlJOOEtzl8gfLW8y5tnwZjFNFqVfha4Ck=;7:pFMGzsQCjd1PsigyjIJwY66Szj70o/udXUOdiPAGpC05+UU3wo7+q2Gbt1tYUg7yw+HJJuyXUs4RgrqmAWCbOKfOPBLkEgAQ83RI+/7xiXvQrZdn2oyBTA4C36rxS0YKlp2c1bKAkC9ni+Hx9ZGPxNfrZxCD2Ppu6MhRUIQhFbqzQ9tnTtee1w0Gce3K84o7u0eBD2nKlTRrkClr032BoLmIdbaBPVCQwMwmetflKcc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2017 16:35:25.6671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0185 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/12/2017 8:22 AM, Thomas Gleixner wrote: > On Thu, 12 Oct 2017, Mike Travis wrote: >> On 10/12/2017 4:17 AM, Thomas Gleixner wrote: >>> On Thu, 5 Oct 2017, mike.travis@hpe.com wrote: >>>> @@ -89,6 +93,10 @@ bool tsc_store_and_check_tsc_adjust(bool >>>> if (!boot_cpu_has(X86_FEATURE_TSC_ADJUST)) >>>> return false; >>>> + /* Skip unnecessary error messages if TSC already unstable */ >>>> + if (check_tsc_unstable()) >>>> + return false; >>>> + >>>> rdmsrl(MSR_IA32_TSC_ADJUST, bootval); >>>> cur->bootval = bootval; >>>> cur->adjusted = bootval; >>> >>> This hunk rejects and I really can't figure out against which tree that >>> would apply. >> >> My current merge tree happens to be 4.13.0-rc1 which was the latest when I >> started this patch submission. I can update my merge tree and reapply if need >> be? > > Please send patches always against top of tree and not some random ancient > version of it. > I pulled in 4.14.0-rc4 and reapplied the patches and they went in without conflict. Hopefully it will be the same for you. (And dealt with your question about applying the same change to the !CONFIG_SMP case.) Thanks, Mike