From: "SkyLake Huang (黃啟澤)" <SkyLake.Huang@mediatek.com>
To: "andrew@lunn.ch" <andrew@lunn.ch>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dqfext@gmail.com" <dqfext@gmail.com>,
"Steven Liu (劉人豪)" <steven.liu@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"daniel@makrotopia.org" <daniel@makrotopia.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH net-next v10 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988
Date: Wed, 21 Aug 2024 09:49:38 +0000 [thread overview]
Message-ID: <c21fe0db83dd665d4725ffedc51db9063dbe2f3d.camel@mediatek.com> (raw)
In-Reply-To: <ebeb75a3-a6b1-46b3-b1e8-7d8448eb23f6@lunn.ch>
On Fri, 2024-08-09 at 16:17 +0200, Andrew Lunn wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> > +static int mt798x_2p5ge_phy_config_aneg(struct phy_device
> *phydev)
> > +{
> > +bool changed = false;
> > +u32 adv;
> > +int ret;
> > +
> > +/* In fact, if we disable autoneg, we can't link up correctly:
> > + * 2.5G/1G: Need AN to exchange master/slave information.
> > + * 100M/10M: Without AN, link starts at half duplex (According to
> > + * IEEE 802.3-2018), which this phy doesn't support.
> > + */
> > +if (phydev->autoneg == AUTONEG_DISABLE)
> > +return -EOPNOTSUPP;
>
> I assume you have seen Russells patches in this area. Please could
> you
> test and review them. Depending on which gets merged, you might need
> to come back and clean this up later.
>
> Andrew
Yes I've seen Russells' patch which forces AN on for speed >= 1G.
Could I send another patch to clean this up? This patchset is sent a
month ago. I need some time to rebuild my testing environment.
BRs,
Sky
next prev parent reply other threads:[~2024-08-21 9:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 10:54 [PATCH net-next v10 00/13] net: phy: mediatek: Introduce mtk-phy-lib and add 2.5Gphy support Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 01/13] net: phy: mediatek: Re-organize MediaTek ethernet phy drivers Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 02/13] net: phy: mediatek: Fix spelling errors and rearrange variables Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 03/13] net: phy: mediatek: Move LED helper functions into mtk phy lib Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 04/13] net: phy: mediatek: Improve readability of mtk-phy-lib.c's mtk_phy_led_hw_ctrl_set() Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 05/13] net: phy: mediatek: Integrate read/write page helper functions Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 06/13] net: phy: mediatek: Hook LED helper functions in mtk-ge.c Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 07/13] net: phy: mediatek: add MT7530 & MT7531's PHY ID macros Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 08/13] net: phy: mediatek: Change mtk-ge-soc.c line wrapping Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 09/13] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 10/13] net: phy: mediatek: Extend 1G TX/RX link pulse time Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 11/13] net: phy: add driver for built-in 2.5G ethernet PHY on MT7988 Sky Huang
2024-08-09 14:17 ` Andrew Lunn
2024-08-21 9:49 ` SkyLake Huang (黃啟澤) [this message]
2024-09-04 8:49 ` SkyLake Huang (黃啟澤)
2024-09-04 9:02 ` Daniel Golle
2024-07-01 10:54 ` [PATCH net-next v10 12/13] net: phy: mediatek: Fix alignment in callback functions' hook Sky Huang
2024-07-01 10:54 ` [PATCH net-next v10 13/13] net: phy: mediatek: Remove unnecessary outer parens of "supported_triggers" var Sky Huang
2024-07-01 11:20 ` Daniel Golle
2024-07-02 4:25 ` SkyLake Huang (黃啟澤)
2024-08-09 10:58 ` [PATCH net-next v10 00/13] net: phy: mediatek: Introduce mtk-phy-lib and add 2.5Gphy support SkyLake Huang (黃啟澤)
2024-08-09 14:07 ` Andrew Lunn
2024-08-21 23:26 ` Daniel Golle
2024-09-04 8:47 ` SkyLake Huang (黃啟澤)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c21fe0db83dd665d4725ffedc51db9063dbe2f3d.camel@mediatek.com \
--to=skylake.huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steven.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox