public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: hpa@zytor.com (H. Peter Anvin)
To: linux-kernel@vger.kernel.org
Subject: Re: [CFT][PATCH] 2.6.4-rc1 remove x86 boot page tables
Date: Tue, 2 Mar 2004 09:21:15 +0000 (UTC)	[thread overview]
Message-ID: <c21jmb$9g9$1@terminus.zytor.com> (raw)
In-Reply-To: m1vflp81kq.fsf@ebiederm.dsl.xmission.com

Followup to:  <m1vflp81kq.fsf@ebiederm.dsl.xmission.com>
By author:    ebiederm@xmission.com (Eric W. Biederman)
In newsgroup: linux.dev.kernel
> 
> -	.quad 0x0000000000000000	/* 0x20 unused */
> -	.quad 0x0000000000000000	/* 0x28 unused */
> +	.quad 0x40cf9a000000ffff	/* 0x20 kernel 4G code at 0-__PAGE_OFFSET */
> +	.quad 0x40cf92000000ffff	/* 0x28 kernel 4G data at 0-__PAGE_OFFSET */
> 

This needs to actually be derived from __PAGE_OFFSET (it may or may
not be 0xc0000000.)

I'd suggest:

/* Create a descriptor from (base,limit,flags) */
/* Limit is in 20-bit form! */
#define DESC(b,l,f)     .long (((l) & 0x0ffff)) |\
                              (((b) & 0x0000ffff) << 16), \
			      (((b) & 0x00ff0000) >> 16) | \
                              (((l) & 0xf0000)) | \
                              (((f) & 0xf0ff) << 8) | \
			      (((b) & 0xff000000))

        DESC(-__PAGE_OFFSET,0xfffff,0xc09a)       /* 0x20 kernel 4G code at -__PAGE_OFFSET */
        DESC(-__PAGE_OFFSET,0xfffff,0xc092)       /* 0x28 kernel 4G code at -__PAGE_OFFSET */

[It broken up into .longs like that, because gas doesn't seem to
handle 64-bit arithmetric.]

Writing all the descriptors in that form may be a good thing :)

	-hpa

  parent reply	other threads:[~2004-03-02  9:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-01  7:32 [CFT][PATCH] 2.6.4-rc1 remove x86 boot page tables Eric W. Biederman
2004-03-01 19:05 ` Dave Hansen
2004-03-02  5:29   ` Eric W. Biederman
2004-03-02  6:47 ` H. Peter Anvin
2004-03-02 12:53   ` [PATCH] Clean up empty_zero_page abuse Brian Gerst
2004-03-02 17:56   ` [CFT][PATCH] 2.6.4-rc1 remove x86 boot page tables Eric W. Biederman
2004-03-02  9:21 ` H. Peter Anvin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-03-01 18:13 Tolentino, Matthew E
2004-03-02  5:36 ` Eric W. Biederman
2004-03-03  6:47 ` Eric W. Biederman
2004-03-03  8:15 ` Eric W. Biederman
2004-03-03 19:45 Tolentino, Matthew E
2004-03-05 14:23 ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='c21jmb$9g9$1@terminus.zytor.com' \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox