From: John Hubbard <jhubbard@nvidia.com>
To: Oded Gabbay <ogabbay@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
"Arnd Bergmann" <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
"Jason Gunthorpe" <jgg@nvidia.com>,
Alex Deucher <alexander.deucher@amd.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>,
Jiho Chu <jiho.chu@samsung.com>,
Daniel Stone <daniel@fooishbar.org>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Jeffrey Hugo <quic_jhugo@quicinc.com>,
Christoph Hellwig <hch@infradead.org>,
Kevin Hilman <khilman@baylibre.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
Maciej Kwapulinski <maciej.kwapulinski@linux.intel.com>
Subject: Re: [RFC PATCH 0/3] new subsystem for compute accelerator devices
Date: Mon, 24 Oct 2022 19:21:52 -0700 [thread overview]
Message-ID: <c22bd93e-8bd2-6865-711a-37aeadbca7f9@nvidia.com> (raw)
In-Reply-To: <CAFCwf12HDZvsr1TrRFQH9Vi26S-Xf9ULgxtBazme90Sj5AzhQQ@mail.gmail.com>
On 10/24/22 05:43, Oded Gabbay wrote:
Hi Oded,
The patches make sense to me. I'm still just reading through and looking
for minor issues, but at a high level it seems to match what the LPC
discussions pointed to.
>> What's your opinion on the long-term prospect of DRM vs accel? I assume
>> that over time, DRM helpers will move into accel and some DRM drivers
>> will start depending on accel?
> I don't think that is what I had in mind.
> What I had in mind is that accel helpers are only relevant for accel
> drivers, and any code that might also be relevant for DRM drivers will
> be placed in DRM core code. e.g. GEM enhancements, RAS netlink
Yes. That is how I understood it ("it" being both the LPC discussions,
and this patchset) as well:
* accel-only code goes in drivers/accel, thus allowing for
smaller, simpler drivers (as compared to full drm) for that case.
* graphics and display code still goes in drivers/gpu/drm, because
it is much too hard to rename or move that directory.
* code common to both also goes in drivers/gpu/drm.
Looking ahead a bit more:
For full-featured GPUs that do both Graphics and Compute, I expect
that a *lot* of the code will end up in drivers/gpu/drm. Because so
much of setting up for Compute is also really just setting up for
Graphics--that's how it evolved, after all!
And as things are structured now, it looks like those full featured
GPU stacks will also need an aux bus (which I only just now learned
about, but it looks quite helpful here). And also, user space will
need to open both /dev/dri/* and /dev/accel/* nodes, if it needs
access to anything live objects that drivers/accel owns.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2022-10-25 2:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 21:46 [RFC PATCH 0/3] new subsystem for compute accelerator devices Oded Gabbay
2022-10-22 21:46 ` [RFC PATCH 1/3] drivers/accel: add new kconfig and update MAINTAINERS Oded Gabbay
2022-10-23 12:40 ` Greg Kroah-Hartman
2022-10-24 7:19 ` Oded Gabbay
2022-10-24 15:01 ` Jeffrey Hugo
2022-10-22 21:46 ` [RFC PATCH 2/3] drm: define new accel major and register it Oded Gabbay
2022-10-23 12:40 ` Greg Kroah-Hartman
2022-10-24 7:23 ` Oded Gabbay
2022-10-24 7:52 ` Dave Airlie
2022-10-24 15:08 ` Jeffrey Hugo
2022-10-22 21:46 ` [RFC PATCH 3/3] drm: add dedicated minor for accelerator devices Oded Gabbay
2022-10-23 12:41 ` Greg Kroah-Hartman
2022-10-24 7:23 ` Oded Gabbay
2022-10-24 15:21 ` Jeffrey Hugo
2022-10-24 17:43 ` Oded Gabbay
2022-10-25 13:26 ` Michał Winiarski
2022-10-26 6:38 ` Oded Gabbay
2022-10-25 6:43 ` Jiho Chu
2022-10-26 6:38 ` Oded Gabbay
2022-10-28 6:56 ` Jiho Chu
2022-10-23 14:02 ` [RFC PATCH 0/3] new subsystem for compute " Bagas Sanjaya
2022-10-23 14:14 ` Greg Kroah-Hartman
2022-10-24 11:55 ` Thomas Zimmermann
2022-10-24 12:35 ` Greg Kroah-Hartman
2022-10-24 12:43 ` Oded Gabbay
2022-10-25 2:21 ` John Hubbard [this message]
2022-10-25 2:27 ` Dave Airlie
2022-10-25 11:15 ` Jason Gunthorpe
2022-10-25 14:21 ` Alex Deucher
2022-10-25 14:34 ` Jason Gunthorpe
2022-10-25 14:43 ` Alex Deucher
2022-10-24 13:55 ` Alex Deucher
2022-10-24 14:41 ` Oded Gabbay
2022-10-24 15:10 ` Alex Deucher
2022-10-26 6:10 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c22bd93e-8bd2-6865-711a-37aeadbca7f9@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=daniel@ffwll.ch \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=jagan@amarulasolutions.com \
--cc=jgg@nvidia.com \
--cc=jiho.chu@samsung.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maciej.kwapulinski@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=yuji2.ishikawa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox