From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27F541E6AE for ; Fri, 14 Aug 2026 07:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786693745; cv=none; b=IesWp4bmuhguU5GEsmhxgaD8OHe1C5agZDS60t2oC5r3F61nbmrjfp/WIEyrh18T+ykmQ0oz5Ks5wyvgkujfVKz3ASeF2+QFrHhfEYJwL9/29jElcpVIuY4v2yGu3uXCh+TNWOYz48P++GDq8F8Oex1DlmY6VpXumSEBJbCsitk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786693745; c=relaxed/simple; bh=v2/1rGY1jbTV6mnksaNbt64aVjPeYee2pckvADnDVtA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z/eQuMIFavB5TAj7jttkaiJip/6qLPrszRxoXzt8WE/OnNrPXv2udnWGtoShSh7utsj67aRIL148BMj/dN0W04gK8RmGXQSgMhcveKKtyK55AMniEapoEvzVdUgym0wRsSJllFhgKStJrLOWp/sei+pIw2bIcgzwbgGormixnqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cIYdhht5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XN/SbgKS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cIYdhht5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XN/SbgKS" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67E7gJWe4047375 for ; Fri, 14 Aug 2026 07:48:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2EEdADYVf7PZDDxkAC3RN/57VZYCx8imRtEtjUOGyeU=; b=cIYdhht5ffjkWy8X HY56cQq9eoqMPrqXHrlYQ32Jr01S2EKEnWadPVUbsnx4eUmU1ktUyTcOBpumUy+K U3yg/ti81tgu2QAcbR7Cap1dG+8jlyBs4ox0LF38pRt9P0hQ02osvPFKE7lE1djx Ty7VsRW9iCy32lkVyfuQhK+F9oyJgxYV7PR2zqeBNkWTNMjqomyZdpO+fCVp53Pd 9AC4rthqt5DMmOEK77zFHoWRit8nY76Mujatu4Q23j+DKbWqXELiwRLymGT6ti3v 0gkgjUHbrZE66sd3B49h3HnyMwEsFFZe/UzdIE0TD1lHQsr1Hc8eym92IYO4uIUd PA76Nw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1hgy355h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Aug 2026 07:48:56 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38f57e31b6eso700211a91.1 for ; Fri, 14 Aug 2026 00:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786693735; x=1787298535; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2EEdADYVf7PZDDxkAC3RN/57VZYCx8imRtEtjUOGyeU=; b=XN/SbgKSICRL01iXY6vgpmk89zC+7ZIN+jy/iXsVSH+s2R9RlfuJuskoNrG0FXeYD3 kyE1sJT/AZg9/786SNZ0X8g1xAxwVr0f3fqNsAbG563cE6lbYD0SKo0HkR9iezJvHGkp jjgQKUOS0rsq9s6VTJPm3SNQE4e18P27cONz10CURQwptrFDCFNk8whyx0Uv0I2wMtTk tdmUdkypKkL1l64EK3fjPMTrDJG3cJSwOUmZwUYAiBY2I3ufHyS87kLAj2s8N4vDASd2 N5OUsfHiF8kU/vBfVgMGwO2ywC8qw2EPXToBDH0S5pfRg6dIleATxfNXMZuYV6KxRIN/ kPGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786693735; x=1787298535; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2EEdADYVf7PZDDxkAC3RN/57VZYCx8imRtEtjUOGyeU=; b=WB0/ekJSmsia1+QT5Klm7hlnGa9hOWUeYOGmtXLTKcqHRTgRPEO20CO5AnOPjMh29Y v/7Fw/u2opSuehhQPgnyrG+wzeaWPGEz3BWcPOJE7gOzlLAfZ8N1DAxjRUhUEcy5rVrE N6gslD5fi5c/QY3GBy9zEmqmLh9bWaGBN1hlFVZyUz4ew592kEXHkKuhlsFrHlA/dlGP fJ0uegjwFLvdgHidauGM+U1OpzLVB0851ma/+Ws/8bafVkvzQ7R8aGD/NQjeGWEOdtC9 yq7ZKKDlHQkVcNxI6wwgX000GfzkCHADp8YNgqbkqN4/WFKC25JTQj1c6Hcb1Z0+0ONQ 0deg== X-Forwarded-Encrypted: i=1; AHgh+Ro2KcCM5242FqUkOQLiUyH8IgtEE9bsojVtsZArLIXhGtrkxRp7fg6esGCh2t07gohsNv6viKitZOOYaqg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3yglv+ETYNapuBPUH1xVtef4vPN0DpK8/f0oMhlENKZ+mtcEi eTRlAir2sjJx1pMHRsPWK55q3Qcx2xo5sb2QkaNLS2Zgvkzj1ki44JlqCERBGu9L7SnjwzTHvFM D4kByj5spbSJcXvjBOO0KsJ7cT8c4izW2L2u8RY/tfNre9Dtwkm0qa6wHoGDckO3d8b4= X-Gm-Gg: AR+sD13QXOlm5E2koJYGZCfQ7md7j3JutlMcDyCNmiQICVBRK7pvpBmS8GGBM/4R0NS DjZvhNm4acR5fGOejFukBmZBU5T/obY5Vy5m9aflKzr8S1X/aQXkK6cGWuRqJRWYYPDHHef78Ta wGeMsMauPWv1BPO9f3pDDfTT1NTOfMDAVBaBnKINyW/iFfAZY7fr0N1ZOMMtgwyd2skmo4VgKwU qHIruEqTfIzoA9nY71h3FqgSSXyIkpy13NvrZ7EKFGsq99rBnCBTplOsG2/1uBLxYvalKSopERi 9G/f9PovKjWKOZQRJlP6JlgpPp24LBdPI6/8l0Kbb+PEDPfByCSQVaBgkHeQFWXyAUnF7u7PzAh 1/NNOWQ7sTOmJgrX8QhwG/Jt8hMJXSPwVI6Wkt7bcLc9S7gaT5FXV4vnnuxamCaVdOEmJ02j/4C rCQoZ4QDgZ/OfVMEbrFmk= X-Received: by 2002:a17:90b:4cc1:b0:37f:be6c:f3f2 with SMTP id 98e67ed59e1d1-3933bd0dd0fmr4662242a91.2.1786693735380; Fri, 14 Aug 2026 00:48:55 -0700 (PDT) X-Received: by 2002:a17:90b:4cc1:b0:37f:be6c:f3f2 with SMTP id 98e67ed59e1d1-3933bd0dd0fmr4662206a91.2.1786693734924; Fri, 14 Aug 2026 00:48:54 -0700 (PDT) Received: from [10.79.117.20] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-394ebbcbb78sm1556274a91.13.2026.08.14.00.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 00:48:54 -0700 (PDT) Message-ID: Date: Fri, 14 Aug 2026 13:18:46 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/15] pinctrl: qcom: Add Kuno pinctrl driver To: Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Michael Turquette , Stephen Boyd , Brian Masney , Taniya Das , Georgi Djakov , Linus Walleij , Thomas Gleixner , Radu Rendec , Robert Marko , Guru Das Srinagesh References: <20260809-kuno-soc-support-v1-0-5e0ede4a0c72@oss.qualcomm.com> <20260809-kuno-soc-support-v1-9-5e0ede4a0c72@oss.qualcomm.com> Content-Language: en-US From: Hardeep Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE0MDA1OSBTYWx0ZWRfX6ujGY3/QktaL MahDZHo4hjb0LmvHWaBJcJjCUgOCWQmXUac2y/KjASyZVdlfZmJfqwsFfadSvScCkOKWOstc71+ 5EW/ouKtNm25kmphtaPzJj5ZMeiwm2yKkEk5u/4dYzYYl0Yqmcm2XGvFo8V+LwCvMGrkY/XI8zH MjNijSjrmJ72PO0ay0J7tLdyXPOl9rlJ8rpcDt3UNaXPooLEeE2gRctrUR8tSl7mH0CUe1VxlCx jLPstHJOopVoyW0vG7Vz2Ikve1CVE3c1FepC/Vc2VwMCXQa/fU1TQ3kfh5X2sxvlhIwz2ToTOOf YoX6OEd+Ow5Rj2PyALEAqAcZSLN70iN9iPIZokwzKuBTsgllGzMOZMS6Iic9mZZ5wRAZD9PQ4YP C4csavmb+e/tzkC6S/rXDA3MZ9uKC/Lic79hLGJX21GzfEHVQR7iCdvHJpDysKZ0z8V318DzuMX eX4ILyVWlz4XvqADNzg== X-Authority-Analysis: v=2.4 cv=AaSB2XXG c=1 sm=1 tr=0 ts=6a7ec868 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=S7Hclr-U69tWnHOGgbMA:9 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: q7dgIm-JAs72uz9I6z8UtvB61dfkdc6y X-Proofpoint-GUID: q7dgIm-JAs72uz9I6z8UtvB61dfkdc6y X-Proofpoint-Spam-Info: AW1haW4tMjYwODE0MDA1OSBTYWx0ZWRfXzIKwJhQhbm4V 6IQpBhJ3jaiIyTq2kkhHefxAIEWpBBeVTf0Ng5o3LIFhUVozpAa6ETBiMA2G3gOWnL0gWVxqnGK A8YTxUaPN2oqsvFj/rfjlX1CyRB/6G0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-14_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608140059 On 8/10/2026 4:33 PM, Bartosz Golaszewski wrote: > On Sun, 9 Aug 2026 09:27:08 +0200, Hardeep Sharma > said: >> Add the TLMM pinctrl driver for the Qualcomm Kuno platform, supporting >> 110 GPIOs and their pin multiplexing, pin configuration and gpiolib >> interface through the common pinctrl-msm driver. >> >> Signed-off-by: Hardeep Sharma >> --- >> + > ... > >> +static const struct pinfunction kuno_functions[] = { >> + MSM_PIN_FUNCTION(gpio), > MSM_GPIO_PIN_FUNCTION() ? Thanks for review. Done in v2 : https://lore.kernel.org/all/20260814-kuno-soc-support-v2-0-3079794f0f73@oss.qualcomm.com/ Best Wishes Hardeep Sharma > >> + MSM_PIN_FUNCTION(audio_ref_clk), >> + MSM_PIN_FUNCTION(coex_uart), >> + MSM_PIN_FUNCTION(ebi2_lcd_a), >> + MSM_PIN_FUNCTION(ebi2_lcd_cs), >> + MSM_PIN_FUNCTION(ebi2_lcd_reset), >> + MSM_PIN_FUNCTION(ebi2_lcd_te), >> + MSM_PIN_FUNCTION(emac_mdc), >> + MSM_PIN_FUNCTION(emac_mdio), >> + MSM_PIN_FUNCTION(emac_pps_in), >> + MSM_PIN_FUNCTION(emac_ptp_aux), >> + MSM_PIN_FUNCTION(emac_ptp_pps), >> + MSM_PIN_FUNCTION(gcc_gp1_clk), >> + MSM_PIN_FUNCTION(gcc_gp2_clk), >> + MSM_PIN_FUNCTION(gcc_gp3_clk), >> + MSM_PIN_FUNCTION(mi2s0_data0), >> + MSM_PIN_FUNCTION(mi2s0_data1), >> + MSM_PIN_FUNCTION(mi2s0_sck), >> + MSM_PIN_FUNCTION(mi2s0_ws), >> + MSM_PIN_FUNCTION(mi2s1_data0), >> + MSM_PIN_FUNCTION(mi2s1_data1), >> + MSM_PIN_FUNCTION(mi2s1_sck), >> + MSM_PIN_FUNCTION(mi2s1_ws), >> + MSM_PIN_FUNCTION(mi2s_mclk), >> + MSM_PIN_FUNCTION(nav_gpio), > Possibly here too? This one not required. Grepped the tree for peer TLMM drivers that expose a `nav_gpio` function: all 10 use MSM_PIN_FUNCTION(nav_gpio, ...), none use MSM_GPIO_PIN_FUNCTION. Kuno matches that convention. Best Wishes Hardeep Sharma > >> + MSM_PIN_FUNCTION(pci_e_rst), >> + MSM_PIN_FUNCTION(pcie_clkreq_n), >> + MSM_PIN_FUNCTION(pll_bist_sync), >> + MSM_PIN_FUNCTION(pll_clk_aux), >> + MSM_PIN_FUNCTION(qdss_cti_trig0), >> + MSM_PIN_FUNCTION(qdss_cti_trig1), >> + MSM_PIN_FUNCTION(qdss_gpio_traceclk), >> + MSM_PIN_FUNCTION(qdss_gpio_tracectl), >> + MSM_PIN_FUNCTION(qup0_se0), >> + MSM_PIN_FUNCTION(qup0_se1), >> + MSM_PIN_FUNCTION(qup0_se2), >> + MSM_PIN_FUNCTION(qup0_se3_mira), >> + MSM_PIN_FUNCTION(qup0_se3_mirb), >> + MSM_PIN_FUNCTION(qup0_se4), >> + MSM_PIN_FUNCTION(sdc4_clk), >> + MSM_PIN_FUNCTION(sdc4_cmd), >> + MSM_PIN_FUNCTION(sdc4_data), >> + MSM_PIN_FUNCTION(sdc4_tb_trig), >> + MSM_PIN_FUNCTION(sgmii_phy_intr), >> + MSM_PIN_FUNCTION(spmi_coex_clk), >> + MSM_PIN_FUNCTION(spmi_coex_data), >> + MSM_PIN_FUNCTION(spmi_vgi_hwevent), >> + MSM_PIN_FUNCTION(uim1_clk), >> + MSM_PIN_FUNCTION(uim1_data), >> + MSM_PIN_FUNCTION(uim1_present), >> + MSM_PIN_FUNCTION(uim1_reset), >> + MSM_PIN_FUNCTION(usb2phy_ac_en), >> +}; >> + > Bart