RE: [PATCH] drm/exynos/vidi: Remove redundant error handling in vidi_get_modes()

대인기/Tizen Platform Lab(SR)/삼성전자
2025-03-19T03:30:41Z

Hi,

> -----Original Message-----
> From: Wentao Liang <vulab@iscas.ac.cn>
> Sent: Thursday, March 6, 2025 1:27 PM
> To: jani.nikula@linux.intel.com; inki.dae@samsung.com;
> sw0312.kim@samsung.com; kyungmin.park@samsung.com; airlied@gmail.com;
> simona@ffwll.ch; krzk@kernel.org; alim.akhtar@samsung.com
> Cc: dri-devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org;
> linux-samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; Wentao
> Liang <vulab@iscas.ac.cn>
> Subject: [PATCH] drm/exynos/vidi: Remove redundant error handling in
> vidi_get_modes()
>
> In the vidi_get_modes() function, if either drm_edid_dup() or
> drm_edid_alloc() fails, the function will immediately return 0,
> indicating that no display modes can be retrieved. However, in
> the event of failure in these two functions, it is still necessary
> to call the subsequent drm_edid_connector_update() function with
> a NULL drm_edid as an argument. This ensures that operations such
> as connector settings are performed in its callee function,
> _drm_edid_connector_property_update. To maintain the integrity of
> the operation, redundant error handling needs to be removed.

You are right. Merged.

Thanks,
Inki Dae

>
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/gpu/drm/exynos/exynos_drm_vidi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> index fd388b1dbe68..a956cdb2f33a 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
> @@ -312,9 +312,6 @@ static int vidi_get_modes(struct drm_connector
> *connector)
> else
> drm_edid = drm_edid_alloc(fake_edid_info,
> sizeof(fake_edid_info));
>
> - if (!drm_edid)
> - return 0;
> -
> drm_edid_connector_update(connector, drm_edid);
>
> count = drm_edid_connector_add_modes(connector);
> --
> 2.42.0.windows.2