From: Dave Jiang <dave.jiang@intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<dmaengine@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: idxd: No need to clear memory after a dma_alloc_coherent() call
Date: Tue, 30 May 2023 08:36:43 -0700 [thread overview]
Message-ID: <c2b5dd7c-9aed-e72c-9685-66680885583b@intel.com> (raw)
In-Reply-To: <f44be04317387f8936d31d5470963541615f30ef.1685283065.git.christophe.jaillet@wanadoo.fr>
On 5/28/23 07:11, Christophe JAILLET wrote:
> dma_alloc_coherent() already clear the allocated memory, there is no need
> to explicitly call memset().
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/device.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 5abbcc61c528..7c74bc60f582 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -786,8 +786,6 @@ static int idxd_device_evl_setup(struct idxd_device *idxd)
> goto err_alloc;
> }
>
> - memset(addr, 0, size);
> -
> spin_lock(&evl->lock);
> evl->log = addr;
> evl->dma = dma_addr;
next prev parent reply other threads:[~2023-05-30 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 14:11 [PATCH] dmaengine: idxd: No need to clear memory after a dma_alloc_coherent() call Christophe JAILLET
2023-05-30 15:36 ` Dave Jiang [this message]
2023-05-30 15:51 ` Fenghua Yu
2023-05-30 15:54 ` Bernd Petrovitsch
2023-05-30 18:46 ` Christophe JAILLET
2023-07-11 16:44 ` Vinod Koul
[not found] <20230721073440.5402-1-xujianghui@cdjrlc.com>
2023-07-21 7:35 ` sunran001
2023-07-21 16:13 ` Dave Jiang
2023-08-01 18:31 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2b5dd7c-9aed-e72c-9685-66680885583b@intel.com \
--to=dave.jiang@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox