From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 700022F531A for ; Tue, 18 Nov 2025 07:01:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763449275; cv=none; b=m+mim8LErpWfZdMaYmP753TnL6Qc8NYkHq3egfEFBGyvC/rEN4jl/YxH018ggC9EJuneJE8s5tBbGw2X+ezGTJWbvop2AGhpP3NqxvPzq+yDzL2gl5egIEZYlnLbM2Gn8yjXZAWflOLTdBv6zGsIGP5srqY4LrC1/PEsrA2XxjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763449275; c=relaxed/simple; bh=vWypKvsnQ7C2Dx17m1gpm7H7isGhl97JTgfTA3Z6xZM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HuvS+eYEMcNT5Y1TdvCDzKkFLcGc5wzPwzAvSJdfav55lh7VhREg6AKS9yvfqMHZvHj8vQk5RA7/YJSkF7iBdpHmXOhButaPTvP61f71zJIxN5kRz0Zb8k0lkzpDyHxr94yiLpgPN6aBva9MzGKifkYHm6vx32j1oygdBitMTOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=OlN/fAb5; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=wC5JTfzo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=OlN/fAb5; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=wC5JTfzo; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="OlN/fAb5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="wC5JTfzo"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="OlN/fAb5"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="wC5JTfzo" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 511A32116F; Tue, 18 Nov 2025 07:01:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763449271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a/FvumS8RsqF+3RcJbKhQK8h4HoAvKjVffBThdh2T7A=; b=OlN/fAb5robpppVCccSncDPrJOMkFjpHToRABkIG++mX1AFplZIUYLPOFRzfRClvaQ6NqP ptIo+Gt2GctcbI8maCIURsdAV4giK+qJ8RxBfZI5JyutzD5oZKnlxqBVHdMreoarFGGcB6 MuBSKQc3lUnE+byfbJAboJabYfm9WNI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763449271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a/FvumS8RsqF+3RcJbKhQK8h4HoAvKjVffBThdh2T7A=; b=wC5JTfzoZrDk0XcKHJC4Z8R13xpODhDUBit7Ajfcodd18z18iVsMfXuM2bvcrYP9BJCpIl b1gpNzkqkEvK0yBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1763449271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a/FvumS8RsqF+3RcJbKhQK8h4HoAvKjVffBThdh2T7A=; b=OlN/fAb5robpppVCccSncDPrJOMkFjpHToRABkIG++mX1AFplZIUYLPOFRzfRClvaQ6NqP ptIo+Gt2GctcbI8maCIURsdAV4giK+qJ8RxBfZI5JyutzD5oZKnlxqBVHdMreoarFGGcB6 MuBSKQc3lUnE+byfbJAboJabYfm9WNI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1763449271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a/FvumS8RsqF+3RcJbKhQK8h4HoAvKjVffBThdh2T7A=; b=wC5JTfzoZrDk0XcKHJC4Z8R13xpODhDUBit7Ajfcodd18z18iVsMfXuM2bvcrYP9BJCpIl b1gpNzkqkEvK0yBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 131443EA61; Tue, 18 Nov 2025 07:01:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Yh6mArcZHGkoSAAAD6G6ig (envelope-from ); Tue, 18 Nov 2025 07:01:11 +0000 Message-ID: Date: Tue, 18 Nov 2025 08:01:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for authentication failures To: Justin Tee , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Daniel Wagner References: <20251117184343.97605-1-justintee8345@gmail.com> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20251117184343.97605-1-justintee8345@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Level: X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[gmail.com,lists.infradead.org,vger.kernel.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_CC(0.00)[gmail.com,broadcom.com,kernel.org]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Score: -4.30 On 11/17/25 19:43, Justin Tee wrote: > With authentication, in addition to EKEYREJECTED there is also no point in > retrying reconnects when status is ENOKEY. Thus, add -ENOKEY as another > criteria to determine when to stop retries. > > Cc: Daniel Wagner > Cc: Hannes Reinecke > Closes: https://lore.kernel.org/linux-nvme/20250829-nvme-fc-sync-v3-0-d69c87e63aee@kernel.org/ > Signed-off-by: Justin Tee > --- > drivers/nvme/host/fabrics.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c > index 3d4d6d8e88c4..fb7765bf0cdf 100644 > --- a/drivers/nvme/host/fabrics.c > +++ b/drivers/nvme/host/fabrics.c > @@ -594,7 +594,7 @@ bool nvmf_should_reconnect(struct nvme_ctrl *ctrl, int status) > if (status > 0 && (status & NVME_STATUS_DNR)) > return false; > > - if (status == -EKEYREJECTED) > + if (status == -EKEYREJECTED || status == -ENOKEY) > return false; > > if (ctrl->opts->max_reconnects == -1 || Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich