From: Krzysztof Kozlowski <krzk@kernel.org>
To: Paul Elder <paul.elder@ideasonboard.com>,
laurent.pinchart@ideasonboard.com
Cc: michael.riesch@collabora.com, xuhf@rock-chips.com,
stefan.klug@ideasonboard.com, mehdi.djait@linux.intel.com,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v2 1/5] media: dt-bindings: Add rockchip rkisp2 bindings
Date: Mon, 24 Aug 2026 12:52:26 +0200 [thread overview]
Message-ID: <c2ed44e5-ed5c-41f7-a782-57c82968495e@kernel.org> (raw)
In-Reply-To: <20260824090406.3695880-2-paul.elder@ideasonboard.com>
On 24/08/2026 11:03, Paul Elder wrote:
> Add documentation for the Rockchip rkisp2 bindings. This is meant to
> support multiple versions of Rockchip ISPs going forward, including the
> 2.x series and 3.x series. The current version only adds the compatible
> for the RK3588, which is a 3.0.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Testing is disabled for some time but it's not really a reason to opt out.
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-24 10:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 9:03 [PATCH v2 0/5] media: rockchip: rkisp2: Add driver for ISP on Rk3588 Paul Elder
2026-08-24 9:03 ` [PATCH v2 1/5] media: dt-bindings: Add rockchip rkisp2 bindings Paul Elder
2026-08-24 10:52 ` Krzysztof Kozlowski [this message]
2026-08-25 6:05 ` Paul Elder
2026-08-25 6:15 ` Krzysztof Kozlowski
2026-08-24 9:03 ` [PATCH v2 2/5] arm64: dts: rockchip: add ISP nodes to rk3588 Paul Elder
2026-08-24 10:52 ` Krzysztof Kozlowski
2026-08-24 9:04 ` [PATCH v2 3/5] media: rockchip: rkisp2: Add rkisp2 driver Paul Elder
2026-08-24 9:04 ` [PATCH v2 4/5] media: rkisp2: Add parameters output video node Paul Elder
2026-08-24 9:04 ` [PATCH v2 5/5] media: rkisp2: Add statistics capture " Paul Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2ed44e5-ed5c-41f7-a782-57c82968495e@kernel.org \
--to=krzk@kernel.org \
--cc=heiko@sntech.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mehdi.djait@linux.intel.com \
--cc=michael.riesch@collabora.com \
--cc=paul.elder@ideasonboard.com \
--cc=stefan.klug@ideasonboard.com \
--cc=xuhf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox