From: Shuah Khan <skhan@linuxfoundation.org>
To: Michael Ellerman <mpe@ellerman.id.au>, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Shuah Khan <skhan@linuxfoundation.org>, shuah <shuah@kernel.org>
Subject: Re: [PATCH] selftests/openat2: Fix build warnings on ppc64
Date: Wed, 29 May 2024 16:20:20 -0600 [thread overview]
Message-ID: <c2eec7d1-27c3-4089-beea-168d19062aaf@linuxfoundation.org> (raw)
In-Reply-To: <20240521030325.58095-1-mpe@ellerman.id.au>
On 5/20/24 21:03, Michael Ellerman wrote:
> Fix warnings like:
>
> openat2_test.c: In function ‘test_openat2_flags’:
> openat2_test.c:303:73: warning: format ‘%llX’ expects argument of type
> ‘long long unsigned int’, but argument 5 has type ‘__u64’ {aka ‘long
> unsigned int’} [-Wformat=]
>
> By switching to unsigned long long for u64 for ppc64 builds.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> tools/testing/selftests/openat2/openat2_test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/openat2/openat2_test.c b/tools/testing/selftests/openat2/openat2_test.c
> index 9024754530b2..5790ab446527 100644
> --- a/tools/testing/selftests/openat2/openat2_test.c
> +++ b/tools/testing/selftests/openat2/openat2_test.c
> @@ -5,6 +5,7 @@
> */
>
> #define _GNU_SOURCE
> +#define __SANE_USERSPACE_TYPES__ // Use ll64
> #include <fcntl.h>
> #include <sched.h>
> #include <sys/stat.h>
Applied to linux-kselftest fixes for the next rc.
Michael, If you want to take this through, let me know, I can drop this.
thanks,
-- Shuah
prev parent reply other threads:[~2024-05-29 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 3:03 [PATCH] selftests/openat2: Fix build warnings on ppc64 Michael Ellerman
2024-05-25 4:32 ` Muhammad Usama Anjum
2024-05-29 8:23 ` Michael Ellerman
2024-05-29 22:20 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2eec7d1-27c3-4089-beea-168d19062aaf@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox