From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BFA9C2D0E4 for ; Tue, 24 Nov 2020 09:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4D6B2073C for ; Tue, 24 Nov 2020 09:14:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cs3k1SZ7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730952AbgKXJNx (ORCPT ); Tue, 24 Nov 2020 04:13:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727477AbgKXJNw (ORCPT ); Tue, 24 Nov 2020 04:13:52 -0500 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCDA4C0613D6; Tue, 24 Nov 2020 01:13:51 -0800 (PST) Received: by mail-lf1-x143.google.com with SMTP id s30so27866481lfc.4; Tue, 24 Nov 2020 01:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fIukb1V/mzn93MU1dQnXMsPLeNbtxaANkhBLdUp3br0=; b=Cs3k1SZ7ifHsNVz0CZW36NkPQFd0rGwgER9f8cZGQQko1ikOKhr4QWnWr7eWc7Yzfc MDtohI4WKe5AtxCJOwRVbfnbEqWzt6iwZKRcsWl6Zntdve4L6np4Ltdc8UA1Ybq4Vx+f jkTbfww4FtxD1tOa71zcmihcXFm1DoAyCkty0gzyYBGMpTbPJHxtlmGYgnyZCvOg7WwG /OEiGh7E4T52ddQQ33opkEjHCbtbasseciyiYlm9rrkUzHsQog+59kJpgL/e/JVl9bZ2 Q9bgzkKdhB0y23+hR20ySeSipeqIN5ffi6/V9lvozoC6G/epREtERZS8gD3NrAhsfq5E gy1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=fIukb1V/mzn93MU1dQnXMsPLeNbtxaANkhBLdUp3br0=; b=A5/2/CYeKhVCmukyL2KJH50MYdLk5UbvMDpN2DmjzCk5PLTJyn62IsgKEZJUo3lKI6 ISvRvUu3c/Gpdbl8rq1eS61nhVRZO3H5xkSzlMS/WSY3KTz1K/sPSH5M9CkTmYKxT08v mcsaKHsFqk/0kgnJa7VnjcuriYyw44apCBFza+2Hes4QUC/Q6SJ3J5gXmYmvIIaA+C3z 08IA9giUMgGwD4R7Rj1mNdApyEO0FltV/T+kQfXBSVjRrCCOifbBf4VVHsjcnFjDk02y O7OTdXQTpwo05rfT7Fw8i9GvF7ga3y309dSNChVpcwIMoES1v2E6bY4SZ5lvMHAmDPmX rbtQ== X-Gm-Message-State: AOAM533gNbsz9I4NHmbIdHlaTF2pf7OtSxUAe8Dj5/81JozTgv/x5lPt zyIovb/uWYQvBQDlqqEpWTs= X-Google-Smtp-Source: ABdhPJxbyG0352c86lWvNDZnJDqhA2YOWXcRsyfKquJjBhPyD4Ni9BJBwtvNNPtm+8dxHSAwjj+CPw== X-Received: by 2002:a19:7b06:: with SMTP id w6mr1484289lfc.260.1606209230293; Tue, 24 Nov 2020 01:13:50 -0800 (PST) Received: from ?IPv6:2a00:1fa0:42b3:ccad:a982:d97f:90ed:ada1? ([2a00:1fa0:42b3:ccad:a982:d97f:90ed:ada1]) by smtp.gmail.com with ESMTPSA id 6sm253081ljr.127.2020.11.24.01.13.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 01:13:49 -0800 (PST) Subject: Re: [PATCH v3] usb: musb: remove unused variable 'devctl' To: min.guo@mediatek.com, Bin Liu Cc: Greg Kroah-Hartman , Alan Stern , Matthias Brugger , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20201124084955.30270-1-min.guo@mediatek.com> From: Sergei Shtylyov Organization: Brain-dead Software Message-ID: Date: Tue, 24 Nov 2020 12:13:42 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201124084955.30270-1-min.guo@mediatek.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 24.11.2020 11:49, min.guo@mediatek.com wrote: > From: Min Guo > > Remove unused 'devctl' variable to fix compile warnings: > > drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq': > drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set > but not used [-Wunused-but-set-variable] > > Signed-off-by: Min Guo > --- > changes in v3 > suggested by Greg Kroah-Hartman: > Add a comment. > > changes in v2 > suggested by Alan Stern: > Add void before musb_read to indicate that the register MUSB_DEVCTL > was intended to be read and discarded. > --- > drivers/usb/musb/musbhsdma.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c > index 0aacfc8be5a1..2a345b4ad015 100644 > --- a/drivers/usb/musb/musbhsdma.c > +++ b/drivers/usb/musb/musbhsdma.c [...] > @@ -336,7 +334,11 @@ irqreturn_t dma_controller_irq(int irq, void *private_data) > < musb_channel->len) ? > "=> reconfig 0" : "=> complete"); > > - devctl = musb_readb(mbase, MUSB_DEVCTL); > + /* > + * Some hardware may need to read the > + * MUSB_DEVCTL register once to take effect. > + */ > + (void)musb_readb(mbase, MUSB_DEVCTL); Hm, forcibly reading DevCtl in the DMA driver... sounds quite nonsensically. Lemme take a look... [...] MBR, Sergei