public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lizhi Hou <lizhi.hou@amd.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>,
	Su Hui <suhui@nfschina.com>, <jacek.lawrynowicz@linux.intel.com>,
	<min.ma@amd.com>, <ogabbay@kernel.org>
Cc: <George.Yang@amd.com>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH v2] accel/amdxdna: Add missing include linux/slab.h
Date: Wed, 19 Feb 2025 10:47:13 -0800	[thread overview]
Message-ID: <c3075150-94f5-7187-007c-0037eaed6077@amd.com> (raw)
In-Reply-To: <60700ca3-8d9a-d284-d2d8-343d770ca384@quicinc.com>


On 2/11/25 07:36, Jeffrey Hugo wrote:
> On 2/10/2025 6:53 PM, Su Hui wrote:
>> When compiling without CONFIG_IA32_EMULATION, there can be some errors:
>>
>> drivers/accel/amdxdna/amdxdna_mailbox.c: In function 
>> ‘mailbox_release_msg’:
>> drivers/accel/amdxdna/amdxdna_mailbox.c:197:2: error: implicit 
>> declaration
>> of function ‘kfree’.
>>    197 |  kfree(mb_msg);
>>        |  ^~~~~
>> drivers/accel/amdxdna/amdxdna_mailbox.c: In function 
>> ‘xdna_mailbox_send_msg’:
>> drivers/accel/amdxdna/amdxdna_mailbox.c:418:11: error:implicit 
>> declaration
>> of function ‘kzalloc’.
>>    418 |  mb_msg = kzalloc(sizeof(*mb_msg) + pkg_size, GFP_KERNEL);
>>        |           ^~~~~~~
>>
>> Add the missing include.
>>
>> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
>> Signed-off-by: Su Hui <suhui@nfschina.com>
>> Reviewed-by: Lizhi Hou <lizhi.hou@amd.com>
>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>

Pushed to drm-misc-fixes


Thanks,

Lizhi


      reply	other threads:[~2025-02-19 18:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11  1:53 [PATCH v2] accel/amdxdna: Add missing include linux/slab.h Su Hui
2025-02-11  8:47 ` Jacek Lawrynowicz
2025-02-11 15:36 ` Jeffrey Hugo
2025-02-19 18:47   ` Lizhi Hou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3075150-94f5-7187-007c-0037eaed6077@amd.com \
    --to=lizhi.hou@amd.com \
    --cc=George.Yang@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacek.lawrynowicz@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=min.ma@amd.com \
    --cc=ogabbay@kernel.org \
    --cc=quic_jhugo@quicinc.com \
    --cc=suhui@nfschina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox