From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753302AbcHUOGg (ORCPT ); Sun, 21 Aug 2016 10:06:36 -0400 Received: from mout.web.de ([217.72.192.78]:59543 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752976AbcHUOGe (ORCPT ); Sun, 21 Aug 2016 10:06:34 -0400 Subject: [PATCH 7/7] USB-iowarrior: Apply another recommendation from "checkpatch.pl" To: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Josh Boyer , Wolfram Sang References: <566ABCD9.1060404@users.sourceforge.net> <5f6dd0dd-820e-c3d3-a88d-a16ad5e64aa8@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Sun, 21 Aug 2016 16:06:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <5f6dd0dd-820e-c3d3-a88d-a16ad5e64aa8@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ncbuspyw4VL1vUuD6rfvaOKrN8k0WmBRHChy6K8wyBeGgYAs6qm 81urdrYrWA8/u55Ad6N1Svh/bMIbxAakQ28ORX4wOwj0r8tdlvzEToeaKLBsJKPt/DjVjuZ h0CTu5yDE4/7/yhm8HvyzOfR8HnDt7pwfZUlHm/pKjXDtf0vZLfK4UD1jCINJDsIC7sGMnW RzEUnxHGoqGWsW3FHSygg== X-UI-Out-Filterresults: notjunk:1;V01:K0:usfmk15WqOs=:LBoXdOukGvUdY1ijvtgr9I RLiesGlHbX3UCkJ8m1GmoVs1NQa5aImTXzQzCr21p7xDHCVUZM07ug1p3r4xuM8xjOeJFjtaq wuRzYuJh8LPm3/zC8cl84e1KFxMT63xH/vzuEMRxZlSZZIeUcgcvxaAJgJrReVE62KYpv/hGX 3rVU9RQD8PSjfj6jU/JMym9OxnMkDUNl0oQWyDqK6JHtNCEuaDi2AYpTx6kWkHDPrc1eXm/OZ t3SG65I5VsRRIe7HD8p6eDVESfcpdK2FYrIW0c9lz2xmFAOmbDYC4zBK8L5ottpaqZPrM/+og Y9K4yGW8yW2wMjoCAyYeAjB+SVGzQqwl302tfKvogrVlLXWxlBk65YwUWlbzz+z0TLAeSHziy M+VcOfl0zouNUDWj2cCjcBoHa9DEyV8dr7MdupOnzd2MLVuS9OWDxEDcRREhFeSB0OrrJ9BBO EAwobYrTCj7nhm1mrGJMo8kBJdrGpE10TcXQYN0QwJWuJD9DTMwnXXDmuiC3JL9vZKh5ctWT1 Wy5X/CFbTQr+DEfmY252SZhgbVBPZG+qJ5lt2YKzotLY7sb5FfGzVJkcmTh8Ak4zeKdPoUND7 MsUiIlYnkv5S9tlaE2dSh7Bpxi1MgTdcCo8rNC6fOgE0zhC3KfXS6L0iHCGkQ/l3OVeJhvpDg 8YFbuhg+Lf6a9bmGJ5Rqt1aa55RQCS9h9rEdG44xJ2FmE3lwROWhjpXR2duVVePX5gKLujCK1 VynrZfz3lfXswa93Reguc8G5Ios+bV5WgajoAhk/FmRu5nL7LwoNZPMtefRPNpd8s2WwsBtcJ QAI1cGV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 21 Aug 2016 15:30:11 +0200 The script "checkpatch.pl" can point out that assignments should usually not be performed within condition checks. Thus move the assignments for two local variables to separate statements. Signed-off-by: Markus Elfring --- drivers/usb/misc/iowarrior.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 132c8cf..78b5d65 100644 --- a/drivers/usb/misc/iowarrior.c +++ b/drivers/usb/misc/iowarrior.c @@ -292,7 +292,8 @@ static ssize_t iowarrior_read(struct file *file, char __user *buffer, /* repeat until no buffer overrun in callback handler occur */ do { atomic_set(&dev->overflow_flag, 0); - if ((read_idx = read_index(dev)) == -1) { + read_idx = read_index(dev); + if (read_idx == -1) { /* queue empty */ if (file->f_flags & O_NONBLOCK) return -EAGAIN; @@ -616,7 +617,8 @@ static int iowarrior_open(struct inode *inode, struct file *file) } /* setup interrupt handler for receiving values */ - if ((retval = usb_submit_urb(dev->int_in_urb, GFP_KERNEL)) < 0) { + retval = usb_submit_urb(dev->int_in_urb, GFP_KERNEL); + if (retval < 0) { dev_err(&interface->dev, "Error %d while submitting URB\n", retval); retval = -EFAULT; goto out; -- 2.9.3