From: Alexandre Mergnat <amergnat@baylibre.com>
To: "Jason-JH.Lin" <jason-jh.lin@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Jason-ch Chen <jason-ch.chen@mediatek.com>,
Johnson Wang <johnson.wang@mediatek.com>,
Singo Chang <singo.chang@mediatek.com>,
Nancy Lin <nancy.lin@mediatek.com>,
Shawn Sung <shawn.sung@mediatek.com>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3 1/2] drm/mediatek: Fix iommu fault by swapping FBs after updating plane state
Date: Wed, 12 Jul 2023 15:03:00 +0200 [thread overview]
Message-ID: <c331bfa3-443d-0976-fb14-e6e97fbd7d58@baylibre.com> (raw)
In-Reply-To: <20230710093253.32224-2-jason-jh.lin@mediatek.com>
On 10/07/2023 11:32, Jason-JH.Lin wrote:
> According to the comment in drm_atomic_helper_async_commit(),
> we should make sure FBs have been swapped, so that cleanups in the
> new_state performs a cleanup in the old FB.
>
> So we should move swapping FBs after calling mtk_plane_update_new_state(),
> to avoid using the old FB which could be freed.
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-07-12 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230710093253.32224-1-jason-jh.lin@mediatek.com>
[not found] ` <20230710093253.32224-3-jason-jh.lin@mediatek.com>
2023-07-10 9:34 ` [PATCH v3 2/2] drm/mediatek: Fix iommu fault during crtc enabling AngeloGioacchino Del Regno
2023-07-12 13:03 ` Alexandre Mergnat
2023-07-14 6:57 ` CK Hu (胡俊光)
2023-07-18 15:48 ` Jason-JH Lin (林睿祥)
2023-07-26 6:56 ` CK Hu (胡俊光)
2023-08-05 8:10 ` Jason-JH Lin (林睿祥)
[not found] ` <20230710093253.32224-2-jason-jh.lin@mediatek.com>
2023-07-12 13:03 ` Alexandre Mergnat [this message]
2023-07-14 6:38 ` [PATCH v3 1/2] drm/mediatek: Fix iommu fault by swapping FBs after updating plane state CK Hu (胡俊光)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c331bfa3-443d-0976-fb14-e6e97fbd7d58@baylibre.com \
--to=amergnat@baylibre.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-ch.chen@mediatek.com \
--cc=jason-jh.lin@mediatek.com \
--cc=johnson.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nancy.lin@mediatek.com \
--cc=shawn.sung@mediatek.com \
--cc=singo.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox