From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: cwchoi00@gmail.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, steven.price@arm.com,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v5 1/4] PM / devfreq: Register devfreq as a cooling device on demand
Date: Mon, 8 Mar 2021 12:04:14 +0000 [thread overview]
Message-ID: <c33ea5f5-1f0e-d081-5f8d-9319536ca215@arm.com> (raw)
In-Reply-To: <bd6c8e7f-e626-b6f4-65b9-f7ea96098677@linaro.org>
On 3/8/21 12:00 PM, Daniel Lezcano wrote:
> On 08/03/2021 10:53, Lukasz Luba wrote:
>> Hi Daniel,
>>
>> In general the approach is good. If there is a special GPU driver, which
>> would like to provide 'struct devfreq_cooling_power *' it would leave
>> 'is_cooling_device=false' and register manually:
>> devfreq_cooling_em_register(df, dfc_power);
>>
>> Please find only a few minor comments below.
>>
>>
>> On 3/8/21 9:16 AM, Daniel Lezcano wrote:
>>> Currently the default behavior is to manually having the devfreq
>>> backend to register themselves as a devfreq cooling device.
>>>
>>> Instead of adding the code in the drivers for the thermal cooling
>>> device registering, let's provide a flag in the devfreq's profile to
>>> tell the common devfreq code to register the newly created devfreq as
>>> a cooling device.
>>>
>>> Suggested-by: Chanwoo Choi <cwchoi00@gmail.com>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>
> [ ... ]
>
>>> + struct thermal_cooling_device *cdev;
>>
>> The linux/thermal.h for 'cdev' would be needed in this header.
>
> May be just a forward declaration ?
>
> struct thermal_cooling_device;
Make sense
Regards,
Lukasz
prev parent reply other threads:[~2021-03-08 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 9:16 [PATCH v5 1/4] PM / devfreq: Register devfreq as a cooling device on demand Daniel Lezcano
2021-03-08 9:16 ` [PATCH v5 2/4] PM / devfreq: msm: Use devfreq cooling device registration Daniel Lezcano
2021-03-08 9:16 ` [PATCH v5 3/4] PM / devfreq: panfrost: " Daniel Lezcano
2021-03-08 9:51 ` Steven Price
2021-03-08 9:16 ` [PATCH v5 4/4] PM / devfreq: lima: " Daniel Lezcano
2021-03-08 9:51 ` [PATCH v5 1/4] PM / devfreq: Register devfreq as a cooling device on demand Steven Price
2021-03-08 9:53 ` Lukasz Luba
2021-03-08 12:00 ` Daniel Lezcano
2021-03-08 12:04 ` Lukasz Luba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c33ea5f5-1f0e-d081-5f8d-9319536ca215@arm.com \
--to=lukasz.luba@arm.com \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox