[PATCH v1 0/2] platform/x86: Remove unused intel-mid.h

[PATCH v1 0/2] platform/x86: Remove unused intel-mid.h

[Andy Shevchenko]

intel-mid.h is not used in the drivers, remove it.

Andy Shevchenko (2):
  platform/x86: intel_scu_wdt: Remove unused intel-mid.h
  platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h

 drivers/platform/x86/intel_scu_pcidrv.c | 1 -
 drivers/platform/x86/intel_scu_wdt.c    | 1 -
 2 files changed, 2 deletions(-)

-- 
2.43.0.rc1.1.gbec44491f096

[PATCH v1 1/2] platform/x86: intel_scu_wdt: Remove unused intel-mid.h

[Andy Shevchenko]

intel-mid.h is providing some core parts of the South Complex PM,
which are usually are not used by individual drivers. In particular,
this driver doesn't use it, so simply remove the unused header.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/platform/x86/intel_scu_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/intel_scu_wdt.c b/drivers/platform/x86/intel_scu_wdt.c
index c2479777a1d6..a5031a25632e 100644
--- a/drivers/platform/x86/intel_scu_wdt.c
+++ b/drivers/platform/x86/intel_scu_wdt.c
@@ -13,7 +13,6 @@
 
 #include <asm/cpu_device_id.h>
 #include <asm/intel-family.h>
-#include <asm/intel-mid.h>
 #include <asm/io_apic.h>
 #include <asm/hw_irq.h>
 
-- 
2.43.0.rc1.1.gbec44491f096

[PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h

[Andy Shevchenko]

intel-mid.h is providing some core parts of the South Complex PM,
which are usually are not used by individual drivers. In particular,
this driver doesn't use it, so simply remove the unused header.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/platform/x86/intel_scu_pcidrv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
index d904fad499aa..dbf0310448da 100644
--- a/drivers/platform/x86/intel_scu_pcidrv.c
+++ b/drivers/platform/x86/intel_scu_pcidrv.c
@@ -11,7 +11,6 @@
 #include <linux/init.h>
 #include <linux/pci.h>
 
-#include <asm/intel-mid.h>
 #include <asm/intel_scu_ipc.h>
 
 static int intel_scu_pci_probe(struct pci_dev *pdev,
-- 
2.43.0.rc1.1.gbec44491f096

Re: [PATCH v1 1/2] platform/x86: intel_scu_wdt: Remove unused intel-mid.h

[Kuppuswamy Sathyanarayanan]

On 3/5/24 8:14 AM, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

>  drivers/platform/x86/intel_scu_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_wdt.c b/drivers/platform/x86/intel_scu_wdt.c
> index c2479777a1d6..a5031a25632e 100644
> --- a/drivers/platform/x86/intel_scu_wdt.c
> +++ b/drivers/platform/x86/intel_scu_wdt.c
> @@ -13,7 +13,6 @@
>  
>  #include <asm/cpu_device_id.h>
>  #include <asm/intel-family.h>
> -#include <asm/intel-mid.h>
>  #include <asm/io_apic.h>
>  #include <asm/hw_irq.h>
>  

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer

Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h

[Kuppuswamy Sathyanarayanan]

On 3/5/24 8:14 AM, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Looks fine to me.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>  drivers/platform/x86/intel_scu_pcidrv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
> index d904fad499aa..dbf0310448da 100644
> --- a/drivers/platform/x86/intel_scu_pcidrv.c
> +++ b/drivers/platform/x86/intel_scu_pcidrv.c
> @@ -11,7 +11,6 @@
>  #include <linux/init.h>
>  #include <linux/pci.h>
>  
> -#include <asm/intel-mid.h>
>  #include <asm/intel_scu_ipc.h>
>  
>  static int intel_scu_pci_probe(struct pci_dev *pdev,

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer

Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h

[Ilpo Järvinen]

On Tue, 5 Mar 2024, Andy Shevchenko wrote:

> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,

Both applied to review-ilpo. I fixed that double "are" for you while 
applying.

-- 
 i.


> this driver doesn't use it, so simply remove the unused header.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/platform/x86/intel_scu_pcidrv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
> index d904fad499aa..dbf0310448da 100644
> --- a/drivers/platform/x86/intel_scu_pcidrv.c
> +++ b/drivers/platform/x86/intel_scu_pcidrv.c
> @@ -11,7 +11,6 @@
>  #include <linux/init.h>
>  #include <linux/pci.h>
>  
> -#include <asm/intel-mid.h>
>  #include <asm/intel_scu_ipc.h>
>  
>  static int intel_scu_pci_probe(struct pci_dev *pdev,
> 

Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h

[Andy Shevchenko]

On Wed, Mar 06, 2024 at 12:44:03PM +0200, Ilpo Järvinen wrote:
> On Tue, 5 Mar 2024, Andy Shevchenko wrote:
> 
> > intel-mid.h is providing some core parts of the South Complex PM,
> > which are usually are not used by individual drivers. In particular,
> 
> Both applied to review-ilpo. I fixed that double "are" for you while 
> applying.

Thank you!

-- 
With Best Regards,
Andy Shevchenko