* [PATCH v1 0/2] platform/x86: Remove unused intel-mid.h
@ 2024-03-05 16:14 Andy Shevchenko
2024-03-05 16:14 ` [PATCH v1 1/2] platform/x86: intel_scu_wdt: " Andy Shevchenko
2024-03-05 16:14 ` [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: " Andy Shevchenko
0 siblings, 2 replies; 7+ messages in thread
From: Andy Shevchenko @ 2024-03-05 16:14 UTC (permalink / raw)
To: Hans de Goede, Julian Winkler, Andy Shevchenko,
platform-driver-x86, linux-kernel
Cc: Mika Westerberg, Ilpo Järvinen
intel-mid.h is not used in the drivers, remove it.
Andy Shevchenko (2):
platform/x86: intel_scu_wdt: Remove unused intel-mid.h
platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h
drivers/platform/x86/intel_scu_pcidrv.c | 1 -
drivers/platform/x86/intel_scu_wdt.c | 1 -
2 files changed, 2 deletions(-)
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 1/2] platform/x86: intel_scu_wdt: Remove unused intel-mid.h
2024-03-05 16:14 [PATCH v1 0/2] platform/x86: Remove unused intel-mid.h Andy Shevchenko
@ 2024-03-05 16:14 ` Andy Shevchenko
2024-03-05 19:37 ` Kuppuswamy Sathyanarayanan
2024-03-05 16:14 ` [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: " Andy Shevchenko
1 sibling, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2024-03-05 16:14 UTC (permalink / raw)
To: Hans de Goede, Julian Winkler, Andy Shevchenko,
platform-driver-x86, linux-kernel
Cc: Mika Westerberg, Ilpo Järvinen
intel-mid.h is providing some core parts of the South Complex PM,
which are usually are not used by individual drivers. In particular,
this driver doesn't use it, so simply remove the unused header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/intel_scu_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/intel_scu_wdt.c b/drivers/platform/x86/intel_scu_wdt.c
index c2479777a1d6..a5031a25632e 100644
--- a/drivers/platform/x86/intel_scu_wdt.c
+++ b/drivers/platform/x86/intel_scu_wdt.c
@@ -13,7 +13,6 @@
#include <asm/cpu_device_id.h>
#include <asm/intel-family.h>
-#include <asm/intel-mid.h>
#include <asm/io_apic.h>
#include <asm/hw_irq.h>
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 1/2] platform/x86: intel_scu_wdt: Remove unused intel-mid.h
2024-03-05 16:14 ` [PATCH v1 1/2] platform/x86: intel_scu_wdt: " Andy Shevchenko
@ 2024-03-05 19:37 ` Kuppuswamy Sathyanarayanan
0 siblings, 0 replies; 7+ messages in thread
From: Kuppuswamy Sathyanarayanan @ 2024-03-05 19:37 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Julian Winkler,
platform-driver-x86, linux-kernel
Cc: Mika Westerberg, Ilpo Järvinen
On 3/5/24 8:14 AM, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Looks good to me.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> drivers/platform/x86/intel_scu_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_wdt.c b/drivers/platform/x86/intel_scu_wdt.c
> index c2479777a1d6..a5031a25632e 100644
> --- a/drivers/platform/x86/intel_scu_wdt.c
> +++ b/drivers/platform/x86/intel_scu_wdt.c
> @@ -13,7 +13,6 @@
>
> #include <asm/cpu_device_id.h>
> #include <asm/intel-family.h>
> -#include <asm/intel-mid.h>
> #include <asm/io_apic.h>
> #include <asm/hw_irq.h>
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h
2024-03-05 16:14 [PATCH v1 0/2] platform/x86: Remove unused intel-mid.h Andy Shevchenko
2024-03-05 16:14 ` [PATCH v1 1/2] platform/x86: intel_scu_wdt: " Andy Shevchenko
@ 2024-03-05 16:14 ` Andy Shevchenko
2024-03-05 19:39 ` Kuppuswamy Sathyanarayanan
2024-03-06 10:44 ` Ilpo Järvinen
1 sibling, 2 replies; 7+ messages in thread
From: Andy Shevchenko @ 2024-03-05 16:14 UTC (permalink / raw)
To: Hans de Goede, Julian Winkler, Andy Shevchenko,
platform-driver-x86, linux-kernel
Cc: Mika Westerberg, Ilpo Järvinen
intel-mid.h is providing some core parts of the South Complex PM,
which are usually are not used by individual drivers. In particular,
this driver doesn't use it, so simply remove the unused header.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/intel_scu_pcidrv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
index d904fad499aa..dbf0310448da 100644
--- a/drivers/platform/x86/intel_scu_pcidrv.c
+++ b/drivers/platform/x86/intel_scu_pcidrv.c
@@ -11,7 +11,6 @@
#include <linux/init.h>
#include <linux/pci.h>
-#include <asm/intel-mid.h>
#include <asm/intel_scu_ipc.h>
static int intel_scu_pci_probe(struct pci_dev *pdev,
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h
2024-03-05 16:14 ` [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: " Andy Shevchenko
@ 2024-03-05 19:39 ` Kuppuswamy Sathyanarayanan
2024-03-06 10:44 ` Ilpo Järvinen
1 sibling, 0 replies; 7+ messages in thread
From: Kuppuswamy Sathyanarayanan @ 2024-03-05 19:39 UTC (permalink / raw)
To: Andy Shevchenko, Hans de Goede, Julian Winkler,
platform-driver-x86, linux-kernel
Cc: Mika Westerberg, Ilpo Järvinen
On 3/5/24 8:14 AM, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Looks fine to me.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> drivers/platform/x86/intel_scu_pcidrv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
> index d904fad499aa..dbf0310448da 100644
> --- a/drivers/platform/x86/intel_scu_pcidrv.c
> +++ b/drivers/platform/x86/intel_scu_pcidrv.c
> @@ -11,7 +11,6 @@
> #include <linux/init.h>
> #include <linux/pci.h>
>
> -#include <asm/intel-mid.h>
> #include <asm/intel_scu_ipc.h>
>
> static int intel_scu_pci_probe(struct pci_dev *pdev,
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h
2024-03-05 16:14 ` [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: " Andy Shevchenko
2024-03-05 19:39 ` Kuppuswamy Sathyanarayanan
@ 2024-03-06 10:44 ` Ilpo Järvinen
2024-03-06 13:32 ` Andy Shevchenko
1 sibling, 1 reply; 7+ messages in thread
From: Ilpo Järvinen @ 2024-03-06 10:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Hans de Goede, Julian Winkler, platform-driver-x86, LKML,
Mika Westerberg
On Tue, 5 Mar 2024, Andy Shevchenko wrote:
> intel-mid.h is providing some core parts of the South Complex PM,
> which are usually are not used by individual drivers. In particular,
Both applied to review-ilpo. I fixed that double "are" for you while
applying.
--
i.
> this driver doesn't use it, so simply remove the unused header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/platform/x86/intel_scu_pcidrv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_scu_pcidrv.c b/drivers/platform/x86/intel_scu_pcidrv.c
> index d904fad499aa..dbf0310448da 100644
> --- a/drivers/platform/x86/intel_scu_pcidrv.c
> +++ b/drivers/platform/x86/intel_scu_pcidrv.c
> @@ -11,7 +11,6 @@
> #include <linux/init.h>
> #include <linux/pci.h>
>
> -#include <asm/intel-mid.h>
> #include <asm/intel_scu_ipc.h>
>
> static int intel_scu_pci_probe(struct pci_dev *pdev,
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: Remove unused intel-mid.h
2024-03-06 10:44 ` Ilpo Järvinen
@ 2024-03-06 13:32 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2024-03-06 13:32 UTC (permalink / raw)
To: Ilpo Järvinen
Cc: Hans de Goede, Julian Winkler, platform-driver-x86, LKML,
Mika Westerberg
On Wed, Mar 06, 2024 at 12:44:03PM +0200, Ilpo Järvinen wrote:
> On Tue, 5 Mar 2024, Andy Shevchenko wrote:
>
> > intel-mid.h is providing some core parts of the South Complex PM,
> > which are usually are not used by individual drivers. In particular,
>
> Both applied to review-ilpo. I fixed that double "are" for you while
> applying.
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-03-06 13:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-05 16:14 [PATCH v1 0/2] platform/x86: Remove unused intel-mid.h Andy Shevchenko
2024-03-05 16:14 ` [PATCH v1 1/2] platform/x86: intel_scu_wdt: " Andy Shevchenko
2024-03-05 19:37 ` Kuppuswamy Sathyanarayanan
2024-03-05 16:14 ` [PATCH v1 2/2] platform/x86: intel_scu_pcidrv: " Andy Shevchenko
2024-03-05 19:39 ` Kuppuswamy Sathyanarayanan
2024-03-06 10:44 ` Ilpo Järvinen
2024-03-06 13:32 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox