RE: [PATCH v1 1/1] s390: Use string_upper() instead of open coded variant

David Laight
2021-10-11T08:21:39Z

...
> > + * This snprintf() call does two things:
> > + * - makes a NUL-terminated copy of the input string
> > + * - pads it with spaces
> > + */
> > + snprintf(tmp, sizeof(tmp), "%s ", name);
>
> I can't say I like code where I have to count spaces in order to
> verify if the code is actually correct.

What it wrong with "%-8.8s" ?

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)