From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2063.outbound.protection.outlook.com [40.107.236.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C3F733CEA3; Tue, 2 Sep 2025 16:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.63 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756831337; cv=fail; b=rQQtjMh43m4PuoaEFLK3jCi4/3B6VDX922FckAYJp/AwXHSMxmTET9HJU5gnakmdMwQtJhJ37U7M9vqALC0tkGo5ZU5bJVi7TzlCkGWkemgXS2TVE9NYFaQY609h9AeFansBDw5oz5ZLoNV3nRXW5LKNxeV5onM6McQGfIj9G74= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756831337; c=relaxed/simple; bh=O3u7k6skPUR0tvTNidY+WruQhZF+30Jts43i48p07QQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=fRsgQCWKgNeHSJMYUng17ULWIfcJPMokbGcX0u4S8Xzj4nYrVquVmIX/oZrTnvvDqU+hBt8ivSaFwgha+xJLPO8eIAiA4E3k5pFFtO1xG59nrPB/9xl8sXPNMmZfOffCUbX2jq8t16AdZIAF2rWsI4sIbIe0gSgWZYeEclQEoY8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Gy4KtLbn; arc=fail smtp.client-ip=40.107.236.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Gy4KtLbn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Sm8sfZ+tTPVUAcFH+Egy664KEdxomMXn+tmqRQxvQ+pS+yBT0nup/MzKCW42SSfTXsXyYpkU8fVXbMXMV+EAR8INQLyhWawShmRFhgiwmNXyee61k7lR/EMYPbhC4lne3FXrbxLRoRkh2W8W/zaw9MX5Y8oKAFKtBTB1EARlKIAYJrIGyhtl6MfjgJKzrYLmuGHm7trGvgUwPh0EZ++RXhYN490x8mCmCGw2XYUe3FcIxWHcdDEnMAzQXZZDG6yzah7owwIgKLRVjV4cPPMRkexNsUZA+gdx4ksQg5bwA7tZNIeUobV/sxVagFjeMxL0swgCoQj5ki73TCPkxCun1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qSXSWjcCzx90fsNvjpgIyhSyPAcVTeWUx0L2jBqE6/4=; b=jDASQ4WIBqp7Qb5CrWgLwHIh7eEcE0XWB6ORJLbvoSgr6EJWjaityQBlB0fjlYLgW3goEEz9MKyT4OUZu/J1Lk9HeFpyD+dwXFt8Tt2cKPq4iDjJKCdrZCm1ga408d0xRa1T6cKxFQSEv7K45HV7pYDgqP2lZfQCFHhKqWPIqgiedhcPu/677vfLGy2foxwQYYL0xCydLG2t7pwrAu1KJZU24KCAop1lX/HpciScm4KiSr0nNWZPajZEWw5OV8zZXRqlNXX/MOvW+qMSpySfStm841MAzePwHvGJI9XQ9z1h+rahNObX1nl1K5uE47xlK33jHzVy7LSiKYiACHrYPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=amarulasolutions.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qSXSWjcCzx90fsNvjpgIyhSyPAcVTeWUx0L2jBqE6/4=; b=Gy4KtLbn+gRwbtF68dhLDyaxLkSMjZp9sGmB0aQ8OQL4Qr3G39Hpgc8AluASBZApkHINSyKsif9sYuAOLsrPRfnUH8ZiubKIfMhesOkyEmyjJDMT3S+OqQjei9xlOL95STx4n05zacVXWDvc0ZB8GKDh9L1f2zZkv9dFZKWqleQ= Received: from SJ0PR13CA0161.namprd13.prod.outlook.com (2603:10b6:a03:2c7::16) by SJ2PR12MB8651.namprd12.prod.outlook.com (2603:10b6:a03:541::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.21; Tue, 2 Sep 2025 16:42:12 +0000 Received: from SJ5PEPF000001F1.namprd05.prod.outlook.com (2603:10b6:a03:2c7:cafe::23) by SJ0PR13CA0161.outlook.office365.com (2603:10b6:a03:2c7::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9094.16 via Frontend Transport; Tue, 2 Sep 2025 16:42:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SJ5PEPF000001F1.mail.protection.outlook.com (10.167.242.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9094.14 via Frontend Transport; Tue, 2 Sep 2025 16:42:12 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 2 Sep 2025 11:42:09 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 2 Sep 2025 11:42:08 -0500 Received: from [172.19.71.207] (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Tue, 2 Sep 2025 11:42:08 -0500 Message-ID: Date: Tue, 2 Sep 2025 09:42:07 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] dmaengine: xilinx: xdma: Fix regmap max_register Content-Language: en-US To: "Pandey, Radhey Shyam" , "anthony@amarulasolutions.com" , "Xu, Brian" , "Rampelli, Raj Kumar" , Vinod Koul , "Simek, Michal" CC: "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20250901-xdma-max-reg-v1-1-b6a04561edb1@amarulasolutions.com> From: Lizhi Hou In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F1:EE_|SJ2PR12MB8651:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f2219c7-b7b1-455b-3681-08ddea3faadb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|82310400026|7053199007|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?S2RKeG10aXRvbzlIT2s0V3VNSlIyZHMyc1BqMStWMFdRdkQvSEI0MGpGQUM1?= =?utf-8?B?bnhGNXVIbkErcC9IT2ZwaFFiOGw2RU1RTWpPME5wNENTNnJSMlRVNHRkejc3?= =?utf-8?B?NnJJakFONG15b2tYZ1FDQkFxT01SQmRPSVMxZ0FBYzZFSlI3MGl5cjZqSUpu?= =?utf-8?B?SUdrMGlqZzdvb0cxU2VmNlowMkdpbGd0QXBwblRmQTFhZGFPcmtUQ0FMNzhQ?= =?utf-8?B?WGRWdEVJeFhVS08zVHB2dlNEUU44dXVrbzNSaDdmSFFGdFRQV2hOQWo3R0tj?= =?utf-8?B?UDZ1M0NqaUwxMU1pNDJKQ1podVFCRG5sMWZIbFBYRHdoMitEVTQyZWtBb0JM?= =?utf-8?B?M2VjSmk0LytyM0FIUG9nSFJ0TEJPVUtCQ3dDZGIxYjJrZlJKWWdBbXJuZ1ht?= =?utf-8?B?VUFOYWZCVnhaS3lCUmxQU0pYRTBqdTJTL1FuVUVqeUgzRWc5Uk1OcElwYWJ3?= =?utf-8?B?RElkeFZoeC9URCtFOEVaTk5oK2h2QXpGSlpaTVMvWUxCL0FaMGxGRmFYYSsx?= =?utf-8?B?clorZC93VStYT1F0RFNOaExuY204Q0x3UWgzM25BSXY3VDZyRlJvdUt6UkdU?= =?utf-8?B?M2lSayt5Z0oyeWpZT1BuT1d3ZlNzVEthaVo5dXZINk5ZWW9IMzJjN3lGVnNy?= =?utf-8?B?bHN4cFlGSzlCMlo1RU53UGZnYWhNQ0ZaMG0vai9VYnJSOWRGeUloN3JCWjht?= =?utf-8?B?N2FRUGpFWXR3KzBEQ3loakpiZm9XT1lKcFUyMG1mSEdhUTdRbnkvcy90aU5s?= =?utf-8?B?YkV3azNwa2M0SFNDU2Z2NGVEK0VkSVNseE1mbDBLNzREN3NJT0VFTjRMU3JW?= =?utf-8?B?NlV5SG0zY2FnRGF6WUIyTWM2WWRpV1dtRlpGYXVmZG50a1ZmTElhd0txNFFE?= =?utf-8?B?RWhjT0NmTjRpWWtsQzJkU3VUNlBlODhVdlNSczF6OUJqbnZGaTZpeGtNNTJ3?= =?utf-8?B?UHJURHE1NUVZcGQ4dUtrREVtc2RrRURGTHNtUUtmblF3RkxjdWNrU1Jad0Q5?= =?utf-8?B?bHNwd1RyVGZwZjVISTVFcngzMEllTXRIdDltY1VlY1pFalVTV3dWU2NCaU02?= =?utf-8?B?aXd4eG9qQlo1aERHNVFjMmF3TTAyVk9BV2Z6OWIzZGJNTXQvZFM2UzU0WlNW?= =?utf-8?B?RGtvaTlLTHNhVThObWYrMzhRaXR4VlM1VThLMGJEcWVkTXNmVXFxMkZkeUdQ?= =?utf-8?B?MHBoUmpFckJ0ZGRjTC9sUkVLQkFuWGdrMnJ6b1RLWndaQ0crQ0tvTUVYMWNP?= =?utf-8?B?UUd2eGQ3QVFlbHFSdk55ak5BUmNqaVRaSFlCTVVVNkd5OFZJa3VsdnV4WjZ1?= =?utf-8?B?dy9JL1AxbElJS3RmeExHRkd3NzllUEFGTlFPb21QV2VmTDBlakpPL1Zqam43?= =?utf-8?B?QmNXcUx6LzhFUGhmL0hCTXFjM0RLSUZwSHU2OS84ckoxVmxmZmtoQXFmU0py?= =?utf-8?B?UVZyYzluNGp4Q0FaVzZiSExXMUlHa0YrVTBEeGUvSkdFSnFZUlI2N0ZaTldX?= =?utf-8?B?Vy9LSnFROFRmZ1lNSjl2Z1BicTdzaFVuNm1TOUEzdlJEbmJxR1BnWnZnWmtE?= =?utf-8?B?enJGT0pVeVhua05CMTMxSkQxSGNOVmd4WGREZ0wrN1dPYkhMb21JV3RnSGF5?= =?utf-8?B?Z2lpK3R0bnFCNFBaTkt6UjRYcCtVOFkvNE93TUFOcTB0RG9NU0pNUUJ0M256?= =?utf-8?B?dkVucUcxYmZGTjIxL0ZtNDNiN0ZGOUQ5ZHZ1Q01zaE53MGxtSFBIRTFHbVdK?= =?utf-8?B?LzJvejVNZXIvaVJucTNtM2ljSm1rR2MwSFY1UkNRQzRvZ2k0dzFkMUNQUmpm?= =?utf-8?B?aEdZYkdqWnZlZlQwOGVCS1VmU2YzMlFvK0hGaFI5U3hnS0VNbjZpZTVxQ2dP?= =?utf-8?B?eFhNalpjTHp6YVhtYWUyc2o3R0g2cDU3UnRlRGtoZlo4SWpjSTNIZDlHU0dJ?= =?utf-8?B?MUlTYW8rb1BLV3A4M3YzU2drb3ZpZDJYQjQrV08yb2E1TzdBTzUzNkVXOVg1?= =?utf-8?B?VnlMK2pIV2tjTkFYRmx4ZDB6K2I4ZDJPbC9tcHNTZE80WS90TG5FRGI1QmNt?= =?utf-8?B?dUNvYkdsVnF1RnQzM25jOU1VZG9XR08wVEtvZz09?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7053199007)(921020);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2025 16:42:12.5425 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f2219c7-b7b1-455b-3681-08ddea3faadb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F1.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8651 On 9/1/25 09:37, Pandey, Radhey Shyam wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > >> -----Original Message----- >> From: Anthony Brandon via B4 Relay >> >> Sent: Monday, September 1, 2025 5:07 PM >> To: Hou, Lizhi ; Xu, Brian ; Rampelli, >> Raj Kumar ; Vinod Koul ; Simek, >> Michal >> Cc: dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >> kernel@vger.kernel.org; Anthony Brandon >> Subject: [PATCH] dmaengine: xilinx: xdma: Fix regmap max_register >> >> From: Anthony Brandon >> >> The max_register field is assigned the size of the register memory region instead of >> the offset of the last register. >> The result is that reading from the regmap via debugfs can cause a segmentation >> fault: >> >> tail /sys/kernel/debug/regmap/xdma.1.auto/registers >> Unable to handle kernel paging request at virtual address ffff800082f70000 Mem >> abort info: >> ESR = 0x0000000096000007 >> EC = 0x25: DABT (current EL), IL = 32 bits >> SET = 0, FnV = 0 >> EA = 0, S1PTW = 0 >> FSC = 0x07: level 3 translation fault >> [...] >> Call trace: >> regmap_mmio_read32le+0x10/0x30 >> _regmap_bus_reg_read+0x74/0xc0 >> _regmap_read+0x68/0x198 >> regmap_read+0x54/0x88 >> regmap_read_debugfs+0x140/0x380 >> regmap_map_read_file+0x30/0x48 >> full_proxy_read+0x68/0xc8 >> vfs_read+0xcc/0x310 >> ksys_read+0x7c/0x120 >> __arm64_sys_read+0x24/0x40 >> invoke_syscall.constprop.0+0x64/0x108 >> do_el0_svc+0xb0/0xd8 >> el0_svc+0x38/0x130 >> el0t_64_sync_handler+0x120/0x138 >> el0t_64_sync+0x194/0x198 >> Code: aa1e03e9 d503201f f9400000 8b214000 (b9400000) ---[ end trace >> 0000000000000000 ]--- >> note: tail[1217] exited with irqs disabled >> note: tail[1217] exited with preempt_count 1 Segmentation fault >> >> Signed-off-by: Anthony Brandon >> --- >> drivers/dma/xilinx/xdma.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c index >> 0d88b1a670e142dac90d09c515809faa2476a816..cb73801fd6cf91fc420d6a8ab0c97 >> 3dcdb5772f5 100644 >> --- a/drivers/dma/xilinx/xdma.c >> +++ b/drivers/dma/xilinx/xdma.c >> @@ -38,7 +38,7 @@ static const struct regmap_config xdma_regmap_config = { >> .reg_bits = 32, >> .val_bits = 32, >> .reg_stride = 4, >> - .max_register = XDMA_REG_SPACE_LEN, >> + .max_register = XDMA_REG_SPACE_LEN - 4, > Nit - Better to change the value of #define itself and we can rename > it to XDMA_MAX_REG_OFFSET? > > Will wait for Lizhi and Brain to confirm if XDMA_REG_SPACE_LEN - 4 > is highest valid register address as per IP documentation, yes, it is. > >> }; >> >> /** >> >> --- >> base-commit: b320789d6883cc00ac78ce83bccbfe7ed58afcf0 >> change-id: 20250901-xdma-max-reg-1649c6459358 >> >> Best regards, >> -- >> Anthony Brandon >> >>