From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE75E63B9 for ; Mon, 29 Dec 2025 08:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766995482; cv=none; b=cxKcA7K5UK+8qzjd80a86b49+ZIYfIjekv4rwaTH5ZZi8hCaWcw1oxOSoRVSlt1KYyU7K18Fb3x7yet9SxVqq45H1CNWY1oEDG14v1cZlXb9b6BW29KIxYq3GzGFuF3/Jgm5O8aP8iGGFcitcn/O0aJXwygc9SqZZx/igJFyDrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766995482; c=relaxed/simple; bh=QGq4DPJ0jJ/rHKZagYA/Gwi/I8NZNKw39yi03vPCY6M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t2L46QefJ/GWxGybsVh/IXSqyxQrFbqgzFnOKY6YQpg8Bgffxu8bg0TVh/jCGc00qB50NTuh/L6IRdGjqe/pYTGX7+a/d97JLop0Kf5s7tg4GY1/ypCuzsHSUJd7j0VAEIxF6q9RfFoJ1EUE2WwJttbjYd9lq8dENaIDntSc+eA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BLc6qFRo; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BLc6qFRo" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5958931c9c7so9995496e87.2 for ; Mon, 29 Dec 2025 00:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766995479; x=1767600279; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wxgtnknbp9U58qvY6RDKQlVjrvd1hHGIvUEbNeV4crE=; b=BLc6qFRoSzSMuhUVgLfr+SKtUyeDN56/SWuzC48loOe3rmTRkm2u4lidvNDywmKSc6 mz2esSwArgp46wP8Of+G1P1cPtMWiyDkkY1gqvytByNBte7o5OYz4KXvXX/G6fqt5V0P seoYiDL+9PoqdZRrB1WMHZzjFZCEx1CX7e4Wvqle1Y/YHRPuzHnZybUliruJctCJf7yL neVsGA3XyIRIZhzIxFuUpiLNqzHBwwmSwtZWHogWKq/P1OD4S92F/HAqd8DNpBbA5enA qrDae9Xxk3FEwjhXfVvRKRx64AM0xfesOeCK6BIUMc7NoM/Og//qCO71l3ZDQ4Ln6iBp Oxyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766995479; x=1767600279; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Wxgtnknbp9U58qvY6RDKQlVjrvd1hHGIvUEbNeV4crE=; b=Zk8+Oud+OWe8vVDkzpINcw+NbiUPdGsfpXA3cuWrwkiXpp6MKlKCIlYDkQL46foe8y eQ1MRbYcTGB0Yp2cxaL7yCL0LEB4USPScYxWIFc/rPdDoEENEVuuBbPGQJskEzmO9qza AyLDksoKeiggT0WKKe1PrDCV8z0fEm6tgqHLXHyTl3z37ehPtOo+g7rFXkpHPf/ngLj5 PchKzJVJ/xbYKpHkd+4lz4WuJpkyIcxU1cYP+sBerZu8GuqjoipL+zFZ5t+NH82Ymbv+ PUSqdlLSJn3J38NVBZeEkaHM4bleXjCa2zy+v04SSIU9UjGxI8NTIuI+8iIPZsR27Sld yGdg== X-Forwarded-Encrypted: i=1; AJvYcCWgQRi4haZutou3kFyMHPuS2SVQnwpmHHwdU4BkBwHmSH0lgpFcVhrURhoe+/wbMNi6sjHVF7pPWRV8UgU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/BRShRxXmW0FDiNDQf3QIeOseyL+y8RmPqSDS32i/XUUwT7af b34gqFmEVyiSnPEKJTomzgn5hcJJD18gtDHm3Etj+whepBOa7Mt4gwG5 X-Gm-Gg: AY/fxX7lQ5zklHwT5dBn62dekw9kzyAeeQobF+AhdnF8BGlsE4ML2g/qPb9waZrfUiF uz2wX3aHA3kiHp72KfkX6wWoXBeIQkz9Kjn4fJqStSxX6eKWW+WJvASXBLbX4nFZhGEl6ZAT4oJ zOLJVo/VleZEemlO97/xtJQFuMrg+x4hBCsYQNsFBpLXdH3sm9TzOa6XJ2bCZ4/YyaV1cn0JJ4D WRShdwGaYXoTW4f/7RDA1H7W2chlIsBuYTo8ai4EDV5b4sy2ZKVQPQBbW+7hhSUIKfYmawSx82c AjyTNrbEOlnWCrW5xWnrAeveU50QT5TG+rjXOgx88NQC5/stKeTTTEmpyB51JqUvuh6sS1Oiwve WzPF6eMuCd4eJ3wWRqsU3GtKy6v4HlK03I5vgoo4CML/BgvpwK5oBHWTAdKuCxEA/B8CQqMJInw 1zSaqhhOhdEyeU72rXj2Xe7Gt45q3TJF0Iv5BkM2d4PQQ1E2n/6+dtQFiTvzKi4n1Zsra1 X-Google-Smtp-Source: AGHT+IHv7BrFv+9Bmci9Wx37WLq70y+3/7ZdPTcagW7BQFhWX9hxw3OqjOFGnEeRtNerT1X0WbSrPA== X-Received: by 2002:a05:6512:4016:b0:598:f4cb:aafd with SMTP id 2adb3069b0e04-59a17d958b8mr11139461e87.19.1766995478827; Mon, 29 Dec 2025 00:04:38 -0800 (PST) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59b30f7c322sm4395390e87.59.2025.12.29.00.04.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 00:04:38 -0800 (PST) Message-ID: Date: Mon, 29 Dec 2025 10:04:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: add Texas Instruments TLA 2528 To: David Lechner , Maxime Chevallier , Jonathan Cameron , nuno.sa@analog.com, Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcelo Schmitt , Antoniu Miclaus , Angelo Dureghello , Tobias Sperling , Eason Yang , Marilene Andrade Garcia , Cosmin Tanislav , duje@dujemihanovic.xyz, herve.codina@bootlin.com, Rodolfo Giometti Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com References: <20251223155534.220504-1-maxime.chevallier@bootlin.com> <20251223155534.220504-2-maxime.chevallier@bootlin.com> <56c03c7f-1e5b-4586-beb0-47a1fa3bc86c@baylibre.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <56c03c7f-1e5b-4586-beb0-47a1fa3bc86c@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/12/2025 20:26, David Lechner wrote: > On 12/23/25 9:55 AM, Maxime Chevallier wrote: >> The TI TLA 2528 is a simple 8 channel, 12-bit ADC? Add a binding > > TLA2528 (no space). Also, why the "?"? > >> documentation for it. >> >> Signed-off-by: Maxime Chevallier >> --- >> .../bindings/iio/adc/ti,tla2528.yaml | 48 +++++++++++++++++++ >> 1 file changed, 48 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml b/Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml >> new file mode 100644 >> index 000000000000..0ee326d77014 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti,tla2528.yaml >> @@ -0,0 +1,48 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/adc/ti,tla2528.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments TLA2528 8-channel 12bit I2C ADC > > 12-bit > >> + >> +maintainers: >> + - Maxime Chevallier >> + >> +description: | >> + 12bit 8-channel I2C ADC. > > The title already says this. Either drop it or add new info. > > Also, don't need the |. > >> + >> +properties: >> + compatible: >> + const: ti,tla2528 >> + >> + reg: >> + maxItems: 1 >> + >> + vref-supply: >> + description: Supply for 2.35V to 5.5V reference voltage > > According the the datasheet, there are AVDD and DVDD supplies. > Nothing named VREF or REF. > > So instead: > > avdd-supply: true > dvdd-supply: true > > > It looks like inputs can also be used as GPIOs, so > > gpio-controller: true > #gpio-cells: > const: 2 > > would be appropriate (it doesn't matter if the driver doesn't > implement it, we know what the correct bindings are). > >> + >> + "#io-channel-cells": >> + const: 1 I didn't check the data-sheet, but if the pins can be set to be GPIOs or ADC inputs, then I would require channels to be specified. It's only 8 channels, so always listing channels that are present shouldn't be that big of a problem - and it should avoid one to add extra properties to denote channels used for GPIO if GPIOs need to be supported. Well, I am not insisting this, there are folks that know this stuff better than I :) Yours, -- Matti --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~