From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1C16C3F68F for ; Tue, 17 Dec 2019 19:54:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF88424672 for ; Tue, 17 Dec 2019 19:54:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728130AbfLQTyB (ORCPT ); Tue, 17 Dec 2019 14:54:01 -0500 Received: from mga02.intel.com ([134.134.136.20]:22025 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727492AbfLQTyB (ORCPT ); Tue, 17 Dec 2019 14:54:01 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 11:54:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,326,1571727600"; d="scan'208";a="389942445" Received: from vramados-mobl.amr.corp.intel.com (HELO [10.254.1.250]) ([10.254.1.250]) by orsmga005.jf.intel.com with ESMTP; 17 Dec 2019 11:53:59 -0800 Subject: Re: [alsa-devel] [PATCH 06/10] mfd: Add core driver for AD242x A2B transceivers To: Daniel Mack , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Cc: lars@metafoo.de, sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org, broonie@kernel.org, pascal.huerst@gmail.com, lee.jones@linaro.org References: <20191209183511.3576038-1-daniel@zonque.org> <20191209183511.3576038-8-daniel@zonque.org> From: Pierre-Louis Bossart Message-ID: Date: Tue, 17 Dec 2019 13:16:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191209183511.3576038-8-daniel@zonque.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +config MFD_AD242X > + bool "Analog Devices AD242x A2B support" > + select MFD_CORE > + select REGMAP_I2C > + depends on I2C=y && OF is there a specific reason why I2C needs to be built-in (as opposed to 'm')? > +/* See Table 3-2 in the datasheet */ is the datasheet public? I thought it was only available under NDA. > + master->sync_clk = devm_clk_get(dev, "sync"); > + if (IS_ERR(master->sync_clk)) { > + ret = PTR_ERR(master->sync_clk); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "failed to get sync clk: %d\n", ret); > + > + return ret; > + } > + > + if (of_property_read_u32(dev->of_node, "clock-frequency", > + &master->sync_clk_rate)) { > + ret = clk_set_rate(master->sync_clk, master->sync_clk_rate); shouldn't you check the rate before setting it? > + if (ret < 0) { > + dev_err(dev, "Cannot set sync clock rate: %d\n", ret); > + return ret; > + } > + } > + > + master->sync_clk_rate = clk_get_rate(master->sync_clk); > + if (master->sync_clk_rate != 44100 && master->sync_clk_rate != 48000) { > + dev_err(dev, "SYNC clock rate %d is invalid\n", > + master->sync_clk_rate); > + return -EINVAL; > + } this is a bit odd, you set the rate in case there is a property but get it anyways. the last block could be an else? > + > + ret = clk_prepare_enable(master->sync_clk); > + if (ret < 0) { > + dev_err(dev, "failed to enable sync clk: %d\n", ret); > + return ret; > + } > + > + /* Master node setup */ > + > + ret = regmap_write(regmap, AD242X_CONTROL, > + AD242X_CONTROL_MSTR | AD242X_CONTROL_SOFTRST); > + if (ret < 0) > + return ret; > + > + ret = ad242x_wait_for_irq(master, &master->run_completion, 10); what is 10? > +static int ad242x_master_remove(struct i2c_client *i2c) > +{ > + struct ad242x_master *master = i2c_get_clientdata(i2c); > + > + if (master->sync_clk) > + clk_disable_unprepare(master->sync_clk); earlier you tested for IS_ERR(master->sync_clk)? > + for (i = 0; i < 4; i++) { what is 4? 4 hops?