From: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Woojung Huh <woojung.huh@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>, <kernel@pengutronix.de>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<UNGLinuxDriver@microchip.com>,
Phil Elwell <phil@raspberrypi.org>
Subject: Re: [PATCH net-next v1 1/6] net: usb: lan78xx: Add error handling to lan78xx_get_regs
Date: Mon, 16 Dec 2024 14:35:26 +0100 [thread overview]
Message-ID: <c3926eff-513d-4c43-9074-696495caa3f4@intel.com> (raw)
In-Reply-To: <Z2Ao8r3gJRnQLq_I@pengutronix.de>
On 12/16/2024 2:19 PM, Oleksij Rempel wrote:
> On Mon, Dec 16, 2024 at 02:07:37PM +0100, Mateusz Polchlopek wrote:
>>
>>
>> On 12/16/2024 1:09 PM, Oleksij Rempel wrote:
>>> if (!netdev->phydev)
>>> return;
>>> /* Read PHY registers */
>>> - for (j = 0; j < 32; i++, j++)
>>> - data[i] = phy_read(netdev->phydev, j);
>>> + for (j = 0; j < 32; i++, j++) {
>>
>> Maybe during this refactor is it worth to add some #define with
>> number of registers to be read?
>
> I prefer to remove this part. Please see patch 5
>
Ach, now I see that. So please forget about my comment
next prev parent reply other threads:[~2024-12-16 13:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 12:09 [PATCH net-next v1 0/6] lan78xx: Preparations for PHYlink Oleksij Rempel
2024-12-16 12:09 ` [PATCH net-next v1 1/6] net: usb: lan78xx: Add error handling to lan78xx_get_regs Oleksij Rempel
2024-12-16 13:07 ` Mateusz Polchlopek
2024-12-16 13:19 ` Oleksij Rempel
2024-12-16 13:35 ` Mateusz Polchlopek [this message]
2024-12-16 12:09 ` [PATCH net-next v1 2/6] net: usb: lan78xx: Use ETIMEDOUT instead of ETIME in lan78xx_stop_hw Oleksij Rempel
2024-12-16 13:08 ` Mateusz Polchlopek
2024-12-16 12:09 ` [PATCH net-next v1 3/6] net: usb: lan78xx: Use action-specific label in lan78xx_mac_reset Oleksij Rempel
2024-12-16 13:13 ` Mateusz Polchlopek
2024-12-16 12:09 ` [PATCH net-next v1 4/6] net: usb: lan78xx: rename phy_mutex to mdiobus_mutex Oleksij Rempel
2024-12-16 12:09 ` [PATCH net-next v1 5/6] net: usb: lan78xx: remove PHY register access from ethtool get_regs Oleksij Rempel
2024-12-16 12:09 ` [PATCH net-next v1 6/6] net: usb: lan78xx: Improve error handling in WoL operations Oleksij Rempel
2024-12-18 4:10 ` [PATCH net-next v1 0/6] lan78xx: Preparations for PHYlink patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3926eff-513d-4c43-9074-696495caa3f4@intel.com \
--to=mateusz.polchlopek@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox