From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH] Documentation/process: mention patch changelog in review process
Date: Sun, 3 Apr 2022 12:58:15 +0700 [thread overview]
Message-ID: <c3ea5966-cfc3-8e36-3f0d-dbaf1b1665b9@gmail.com> (raw)
In-Reply-To: <20220402100706.57507-1-krzysztof.kozlowski@linaro.org>
On 02/04/22 17.07, Krzysztof Kozlowski wrote:
> Extend the "Respond to review comments" section of "Submitting patches"
> with reference to patch changelogs.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/process/submitting-patches.rst | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index fb496b2ebfd3..9bb4e8c0f635 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -318,7 +318,10 @@ understands what is going on.
> Be sure to tell the reviewers what changes you are making and to thank them
> for their time. Code review is a tiring and time-consuming process, and
> reviewers sometimes get grumpy. Even in that case, though, respond
> -politely and address the problems they have pointed out.
> +politely and address the problems they have pointed out. When sending a next
> +version, add a ``patch changelog`` to the cover letter or to individual patches
> +explaining difference aganst previous submission (see
> +:ref:`the_canonical_patch_format`).
>
> See Documentation/process/email-clients.rst for recommendations on email
> clients and mailing list etiquette.
What about range-diffs?
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-04-03 5:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 10:07 [PATCH] Documentation/process: mention patch changelog in review process Krzysztof Kozlowski
2022-04-03 5:58 ` Bagas Sanjaya [this message]
2022-04-03 7:47 ` Krzysztof Kozlowski
2022-04-05 15:44 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3ea5966-cfc3-8e36-3f0d-dbaf1b1665b9@gmail.com \
--to=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox