diff for duplicates of <c3f923f7-05b1-44ec-8cc2-e5dff1cbd2c6@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 7c7f898..41cdc1a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,71 +1,58 @@ +From: Prarit Bhargava <prarit@redhat.com> + On 6/21/24 00:47, Liu Wei wrote: -> For varying privacy and security reasons, sometimes we would like to -> completely silence the serial console output, and only enable it through -> cmdline when needed. -> -> But there are many existing systems that depend on this console, -> so add CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE for this situation. +> > For varying privacy and security reasons, sometimes we would like to +> > completely silence the serial console output, and only enable it through +> > cmdline when needed. +> > +> > But there are many existing systems that depend on this console, +> > so add CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE for this situation. +> > +> > Signed-off-by: Liu Wei <liuwei09@cestc.cn> +> > Suggested-by: Prarit Bhargava <prarit@redhat.com> +> > --- +> > +> > v2: Add a config option suggested by Prarit +> > --- +> > arch/arm64/kernel/acpi.c | 12 ++++++++++++ +> > drivers/acpi/arm64/Kconfig | 11 +++++++++++ +> > 2 files changed, 23 insertions(+) +> > +> > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c +> > index dba8fcec7f33..3365fabb5cf8 100644 +> > --- a/arch/arm64/kernel/acpi.c +> > +++ b/arch/arm64/kernel/acpi.c +> > @@ -227,7 +227,19 @@ void __init acpi_boot_table_init(void) +> > if (earlycon_acpi_spcr_enable) +> > early_init_dt_scan_chosen_stdout(); +> > } else { +> > + /* +> > + * For varying privacy and security reasons, sometimes need +> > + * to completely silence the serial console output, and only +> > + * enable it by cmdline when needed. +> > + * But there are many existing systems that depend on this +> > + * behavior, so use CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE. +> > + */ +> > +#ifdef CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE +> > + acpi_parse_spcr(earlycon_acpi_spcr_enable, false); +> > +#else +> > acpi_parse_spcr(earlycon_acpi_spcr_enable, true); +> > +#endif +> > + > -> Signed-off-by: Liu Wei <liuwei09@cestc.cn> -> Suggested-by: Prarit Bhargava <prarit@redhat.com> -> --- +> I don't think you want a config option here after all. See my previous +> comment about "acpi=nospcr". I realized that if you do use a config +> then distros will not have the ability to default 'on', and advise users +> to disable it for their use cases. > -> v2: Add a config option suggested by Prarit -> --- -> arch/arm64/kernel/acpi.c | 12 ++++++++++++ -> drivers/acpi/arm64/Kconfig | 11 +++++++++++ -> 2 files changed, 23 insertions(+) -> -> diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c -> index dba8fcec7f33..3365fabb5cf8 100644 -> --- a/arch/arm64/kernel/acpi.c -> +++ b/arch/arm64/kernel/acpi.c -> @@ -227,7 +227,19 @@ void __init acpi_boot_table_init(void) -> if (earlycon_acpi_spcr_enable) -> early_init_dt_scan_chosen_stdout(); -> } else { -> + /* -> + * For varying privacy and security reasons, sometimes need -> + * to completely silence the serial console output, and only -> + * enable it by cmdline when needed. -> + * But there are many existing systems that depend on this -> + * behavior, so use CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE. -> + */ -> +#ifdef CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE -> + acpi_parse_spcr(earlycon_acpi_spcr_enable, false); -> +#else -> acpi_parse_spcr(earlycon_acpi_spcr_enable, true); -> +#endif -> + - -I don't think you want a config option here after all. See my previous -comment about "acpi=nospcr". I realized that if you do use a config -then distros will not have the ability to default 'on', and advise users -to disable it for their use cases. +> Try the 'acpi=nospcr' option. That should keep everyone happy. +> -Try the 'acpi=nospcr' option. That should keep everyone happy. +Ok, I will send new version soon. -P. +Thanks for your suggestion! -> if (IS_ENABLED(CONFIG_ACPI_BGRT)) -> acpi_table_parse(ACPI_SIG_BGRT, acpi_parse_bgrt); -> } -> diff --git a/drivers/acpi/arm64/Kconfig b/drivers/acpi/arm64/Kconfig -> index b3ed6212244c..7e4d860d7089 100644 -> --- a/drivers/acpi/arm64/Kconfig -> +++ b/drivers/acpi/arm64/Kconfig -> @@ -21,3 +21,14 @@ config ACPI_AGDI -> -> config ACPI_APMT -> bool -> + -> +config ARM_DISABLE_ACPI_SPCR_CONSOLE -> + bool "Disable ACPI SPCR Console by Default on Arm64" -> + depends on ARM64 && ACPI_SPCR_TABLE -> + default n -> + help -> + For varying privacy and security reasons, sometimes need to -> + completely silence the serial console output, and only enable -> + it by kernel cmdline when needed. -> + -> + Say Y to disable ACPI SPCR console by default. +Liu Wei + +> P. +> diff --git a/a/content_digest b/N1/content_digest index 908b0b0..4808428 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,10 @@ "ref\020240530015332.7305-1-liuwei09@cestc.cn\0" "ref\020240621044706.87181-1-liuwei09@cestc.cn\0" - "From\0Prarit Bhargava <prarit@redhat.com>\0" + "From\0Liu Wei <liuwei09@cestc.cn>\0" "Subject\0Re: [PATCH v2] ACPI: Add config to disable ACPI SPCR console by default on arm64\0" - "Date\0Fri, 21 Jun 2024 07:26:51 -0400\0" - "To\0Liu Wei <liuwei09@cestc.cn>\0" + "Date\0Sat, 22 Jun 2024 00:39:25 +0800\0" + "To\0prarit@redhat.com" + " Liu Wei <liuwei09@cestc.cn>\0" "Cc\0catalin.marinas@arm.com" guohanjun@huawei.com linux-arm-kernel@lists.infradead.org @@ -14,76 +15,63 @@ " will@kernel.org\0" "\00:1\0" "b\0" + "From: Prarit Bhargava <prarit@redhat.com>\n" + "\n" "On 6/21/24 00:47, Liu Wei wrote:\n" - "> For varying privacy and security reasons, sometimes we would like to\n" - "> completely silence the serial console output, and only enable it through\n" - "> cmdline when needed.\n" - "> \n" - "> But there are many existing systems that depend on this console,\n" - "> so add CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE for this situation.\n" + "> > For varying privacy and security reasons, sometimes we would like to\n" + "> > completely silence the serial console output, and only enable it through\n" + "> > cmdline when needed.\n" + "> > \n" + "> > But there are many existing systems that depend on this console,\n" + "> > so add CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE for this situation.\n" + "> > \n" + "> > Signed-off-by: Liu Wei <liuwei09@cestc.cn>\n" + "> > Suggested-by: Prarit Bhargava <prarit@redhat.com>\n" + "> > ---\n" + "> > \n" + "> > v2: Add a config option suggested by Prarit\n" + "> > ---\n" + "> > arch/arm64/kernel/acpi.c | 12 ++++++++++++\n" + "> > drivers/acpi/arm64/Kconfig | 11 +++++++++++\n" + "> > 2 files changed, 23 insertions(+)\n" + "> > \n" + "> > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c\n" + "> > index dba8fcec7f33..3365fabb5cf8 100644\n" + "> > --- a/arch/arm64/kernel/acpi.c\n" + "> > +++ b/arch/arm64/kernel/acpi.c\n" + "> > @@ -227,7 +227,19 @@ void __init acpi_boot_table_init(void)\n" + "> > \t\tif (earlycon_acpi_spcr_enable)\n" + "> > \t\t\tearly_init_dt_scan_chosen_stdout();\n" + "> > \t} else {\n" + "> > +\t\t/*\n" + "> > +\t\t * For varying privacy and security reasons, sometimes need\n" + "> > +\t\t * to completely silence the serial console output, and only\n" + "> > +\t\t * enable it by cmdline when needed.\n" + "> > +\t\t * But there are many existing systems that depend on this\n" + "> > +\t\t * behavior, so use CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE.\n" + "> > +\t\t */\n" + "> > +#ifdef CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE\n" + "> > +\t\tacpi_parse_spcr(earlycon_acpi_spcr_enable, false);\n" + "> > +#else\n" + "> > \t\tacpi_parse_spcr(earlycon_acpi_spcr_enable, true);\n" + "> > +#endif\n" + "> > +\n" "> \n" - "> Signed-off-by: Liu Wei <liuwei09@cestc.cn>\n" - "> Suggested-by: Prarit Bhargava <prarit@redhat.com>\n" - "> ---\n" + "> I don't think you want a config option here after all. See my previous \n" + "> comment about \"acpi=nospcr\". I realized that if you do use a config \n" + "> then distros will not have the ability to default 'on', and advise users \n" + "> to disable it for their use cases.\n" "> \n" - "> v2: Add a config option suggested by Prarit\n" - "> ---\n" - "> arch/arm64/kernel/acpi.c | 12 ++++++++++++\n" - "> drivers/acpi/arm64/Kconfig | 11 +++++++++++\n" - "> 2 files changed, 23 insertions(+)\n" - "> \n" - "> diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c\n" - "> index dba8fcec7f33..3365fabb5cf8 100644\n" - "> --- a/arch/arm64/kernel/acpi.c\n" - "> +++ b/arch/arm64/kernel/acpi.c\n" - "> @@ -227,7 +227,19 @@ void __init acpi_boot_table_init(void)\n" - "> \t\tif (earlycon_acpi_spcr_enable)\n" - "> \t\t\tearly_init_dt_scan_chosen_stdout();\n" - "> \t} else {\n" - "> +\t\t/*\n" - "> +\t\t * For varying privacy and security reasons, sometimes need\n" - "> +\t\t * to completely silence the serial console output, and only\n" - "> +\t\t * enable it by cmdline when needed.\n" - "> +\t\t * But there are many existing systems that depend on this\n" - "> +\t\t * behavior, so use CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE.\n" - "> +\t\t */\n" - "> +#ifdef CONFIG_ARM_DISABLE_ACPI_SPCR_CONSOLE\n" - "> +\t\tacpi_parse_spcr(earlycon_acpi_spcr_enable, false);\n" - "> +#else\n" - "> \t\tacpi_parse_spcr(earlycon_acpi_spcr_enable, true);\n" - "> +#endif\n" - "> +\n" - "\n" - "I don't think you want a config option here after all. See my previous \n" - "comment about \"acpi=nospcr\". I realized that if you do use a config \n" - "then distros will not have the ability to default 'on', and advise users \n" - "to disable it for their use cases.\n" + "> Try the 'acpi=nospcr' option. That should keep everyone happy.\n" + ">\n" "\n" - "Try the 'acpi=nospcr' option. That should keep everyone happy.\n" + "Ok, I will send new version soon.\n" "\n" - "P.\n" + "Thanks for your suggestion!\n" "\n" - "> \t\tif (IS_ENABLED(CONFIG_ACPI_BGRT))\n" - "> \t\t\tacpi_table_parse(ACPI_SIG_BGRT, acpi_parse_bgrt);\n" - "> \t}\n" - "> diff --git a/drivers/acpi/arm64/Kconfig b/drivers/acpi/arm64/Kconfig\n" - "> index b3ed6212244c..7e4d860d7089 100644\n" - "> --- a/drivers/acpi/arm64/Kconfig\n" - "> +++ b/drivers/acpi/arm64/Kconfig\n" - "> @@ -21,3 +21,14 @@ config ACPI_AGDI\n" - "> \n" - "> config ACPI_APMT\n" - "> \tbool\n" - "> +\n" - "> +config ARM_DISABLE_ACPI_SPCR_CONSOLE\n" - "> +\tbool \"Disable ACPI SPCR Console by Default on Arm64\"\n" - "> +\tdepends on ARM64 && ACPI_SPCR_TABLE\n" - "> +\tdefault n\n" - "> +\thelp\n" - "> +\t\tFor varying privacy and security reasons, sometimes need to\n" - "> +\t\tcompletely silence the serial console output, and only enable\n" - "> +\t\tit by kernel cmdline when needed.\n" - "> +\n" - "> +\t\tSay Y to disable ACPI SPCR console by default." + "Liu Wei\n" + " \n" + "> P.\n" + > -c3863d565580bb231cb5e716e5323e92e455269fdaa3a6fd4a321ad0a54a5d3a +a168652df1d17785a321c1454a27f33d84994a73c0f2d9865c80647191260ebf
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox