From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACE8C04A6A for ; Tue, 15 Aug 2023 02:08:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234108AbjHOCIN (ORCPT ); Mon, 14 Aug 2023 22:08:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234114AbjHOCHp (ORCPT ); Mon, 14 Aug 2023 22:07:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92673172C; Mon, 14 Aug 2023 19:07:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 27113644FF; Tue, 15 Aug 2023 02:07:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8410BC433C7; Tue, 15 Aug 2023 02:07:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692065263; bh=Sf1f6HcmcCqT/xTbQgDjPUCBG8YZBaGPXD/uAr2kD/s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uBaCkgjhSyPsburjeK5c7wIYGPuij3HRcF+k5XA66AD5bj8I9BmtWv7LE8g/Dlti8 No3EA0M7KutVgr6A3xCgTciLyEaft4qzy1mwd4AtxoAzVZzi6LVDvTWEbgaPSquf8a akbcT1Qz0kg7A7R4+f2AwEiYOAzS/X6ZRxEMTwLq2yLaEsWTD4YlcBCy6UEpQ13rSA dOYJkh0RICVYHHbYbqXzK5gaBTU5UJtGD6QsqUy0fDrSzjjvk8FU1k8Da/bLfw45tc 0jryd1gFzVXR0dgYiiE9R8PTF2T/tkZ43eMGYFe3azy9FK3Pqdc2i5ldfQhwBZ3U41 XJlfqc1M5pomQ== Message-ID: Date: Tue, 15 Aug 2023 11:07:41 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 02/10] scsi: libsas: Delete enum sas_class Content-Language: en-US To: John Garry , jejb@linux.ibm.com, martin.petersen@oracle.com, chenxiang66@hisilicon.com, artur.paszkiewicz@intel.com, yanaijie@huawei.com, jinpu.wang@cloud.ionos.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230814141022.36875-1-john.g.garry@oracle.com> <20230814141022.36875-3-john.g.garry@oracle.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230814141022.36875-3-john.g.garry@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/14/23 23:10, John Garry wrote: > enum sas_class prob would have been useful if function sas_show_class() was > ever implemented, which it wasn't. > > enum sas_class is used as asd_sas_port.class and asd_sas_phy.class, which > are only ever set, so delete these members and the enum. > > Signed-off-by: John Garry Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research