From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Liu Ying <victor.liu@nxp.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Cc: p.zabel@pengutronix.de, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, glx@linutronix.de,
vkoul@kernel.org, kishon@kernel.org, aisheng.dong@nxp.com,
agx@sigxcpu.org, francesco@dolcini.it, frank.li@nxp.com,
dmitry.baryshkov@linaro.org
Subject: Re: [v4,09/19] drm/imx: Add i.MX8qxp Display Controller display engine
Date: Thu, 28 Nov 2024 16:46:53 +0800 [thread overview]
Message-ID: <c4334c9b-833b-4923-8188-64d662231512@linux.dev> (raw)
In-Reply-To: <20241125093316.2357162-10-victor.liu@nxp.com>
Hi,
On 2024/11/25 17:33, Liu Ying wrote:
> i.MX8qxp Display Controller display engine consists of all processing
> units that operate in a display clock domain. Add minimal feature
> support with FrameGen and TCon so that the engine can output display
> timings. The display engine driver as a master binds FrameGen and
> TCon drivers as components. While at it, the display engine driver
> is a component to be bound with the upcoming DRM driver.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v4:
> * Use regmap to define register map for all registers. (Dmitry)
> * Use regmap APIs to access registers. (Dmitry)
> * Inline some small functions. (Dmitry)
Why?
Its seems that the switch to regmap APIs is not very necessary,
as ioremap/writel/readl are simple enough and easier to use.
Isn't that this just introduce an intermediate layer? It's okay
for display bridges/panels that behind I2C bus or SPI bus. But
then, why drm/msm still haven't be converted to use the regmap
APIs ?
Just a few questions, has no opinions to your patch.
--
Best regards,
Sui
next prev parent reply other threads:[~2024-11-28 8:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 9:32 [PATCH v4 00/19] Add Freescale i.MX8qxp Display Controller support Liu Ying
2024-11-25 9:32 ` [PATCH v4 01/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller processing units Liu Ying
2024-11-25 9:32 ` [PATCH v4 02/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller blit engine Liu Ying
2024-11-25 9:33 ` [PATCH v4 03/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine Liu Ying
2024-11-25 9:33 ` [PATCH v4 04/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine Liu Ying
2024-11-25 9:33 ` [PATCH v4 05/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller AXI performance counter Liu Ying
2024-11-25 9:33 ` [PATCH v4 06/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller command sequencer Liu Ying
2024-11-25 9:33 ` [PATCH v4 07/19] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller Liu Ying
2024-11-25 9:33 ` [PATCH v4 08/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller Liu Ying
2024-11-25 9:33 ` [PATCH v4 09/19] drm/imx: Add i.MX8qxp Display Controller display engine Liu Ying
2024-11-28 8:12 ` [v4,09/19] " Sui Jingfeng
2024-11-29 2:30 ` Liu Ying
2024-11-28 8:46 ` Sui Jingfeng [this message]
2024-11-28 14:18 ` Dmitry Baryshkov
2024-11-30 17:37 ` [PATCH v4 09/19] " Uwe Kleine-König
2024-12-02 2:16 ` Liu Ying
2024-11-25 9:33 ` [PATCH v4 10/19] drm/imx: Add i.MX8qxp Display Controller pixel engine Liu Ying
2024-11-25 9:33 ` [PATCH v4 11/19] drm/imx: Add i.MX8qxp Display Controller interrupt controller Liu Ying
2024-11-25 9:33 ` [PATCH v4 12/19] drm/imx: Add i.MX8qxp Display Controller KMS Liu Ying
2024-11-25 9:33 ` [PATCH v4 13/19] MAINTAINERS: Add maintainer for i.MX8qxp Display Controller Liu Ying
2024-11-25 9:33 ` [DO NOT MERGE PATCH v4 14/19] dt-bindings: phy: mixel, mipi-dsi-phy: Allow assigned-clock* properties Liu Ying
2024-11-25 9:33 ` [DO NOT MERGE PATCH v4 15/19] dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes Liu Ying
2024-11-26 7:01 ` Krzysztof Kozlowski
2024-11-26 7:33 ` Liu Ying
2024-11-26 7:34 ` Krzysztof Kozlowski
2024-11-25 9:33 ` [DO NOT MERGE PATCH v4 16/19] arm64: dts: imx8qxp: Add display controller subsystem Liu Ying
2024-11-25 10:52 ` Francesco Dolcini
2024-11-26 2:08 ` Liu Ying
2024-11-26 8:43 ` Maxime Ripard
2024-11-26 9:00 ` Liu Ying
2024-11-25 9:33 ` [DO NOT MERGE PATCH v4 17/19] arm64: dts: imx8qxp: Add MIPI-LVDS combo subsystems Liu Ying
2024-11-25 9:33 ` [DO NOT MERGE PATCH v4 18/19] arm64: dts: imx8qxp-mek: Enable display controller Liu Ying
2024-11-25 9:33 ` [DO NOT MERGE PATCH v4 19/19] arm64: dts: imx8qxp-mek: Add MX8-DLVDS-LCD1 display module support Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4334c9b-833b-4923-8188-64d662231512@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=agx@sigxcpu.org \
--cc=airlied@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=frank.li@nxp.com \
--cc=glx@linutronix.de \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox