From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751845AbdJ1Ac6 (ORCPT ); Fri, 27 Oct 2017 20:32:58 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21359 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbdJ1Acy (ORCPT ); Fri, 27 Oct 2017 20:32:54 -0400 Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module To: Hal Rosenstock Cc: linux-rdma@vger.kernel.org, tbogendoerfer@suse.de, matanb@mellanox.com, leonro@mellanox.com, parav@mellanox.com, linux-kernel@vger.kernel.org, dledford@redhat.com References: <64ef31c8-cb1a-4579-ba12-11fbf6d1d5c0@default> <0af834ca-52ff-47da-a225-744aab4e59d6@dev.mellanox.co.il> <9be6d049-c3fc-6cf2-8d91-4449f4bcc896@oracle.com> <4dcf0ca6-77ff-bfd3-9f79-c114617f536f@dev.mellanox.co.il> From: Ghazale Hosseinabadi Organization: Oracle Corporation Message-ID: Date: Fri, 27 Oct 2017 17:36:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <4dcf0ca6-77ff-bfd3-9f79-c114617f536f@dev.mellanox.co.il> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2017 04:19 PM, Hal Rosenstock wrote: > On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote: >> >> On 10/27/2017 03:52 PM, Hal Rosenstock wrote: >>> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: >>>> When running ibstat (if transceiver is not connected in adapter): >>>> >>>> ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid >>>> argument >>> Any output before that ? >> no, It only prints this line. > and setting the width to 1x in the driver so the rate file is properly > populated fixes this ? Yes, because a value is written in /sys/class/infiniband/mlx5_X/ports/1/rate > I must be missing something as to what is going > on in this scenario. Without this bug fix, file /sys/class/infiniband/mlx5_X/ports/1/rate is empty, which results in ibpanic. -- Ghazale > > sysfs.c:rate_show is inconsistent as it paves over an invalid speed > setting that to SDR but does not pave over invalid width returning > -EINVAL but this comment is in another "direction". > > -- Hal > >> -- Ghazale >>> I'm trying to understand how far it gets. It >>> looks to me that empty rate file would be parsed as 0 and ibstat would >>> show that rate. ibpanic would occur if file was not found but I could be >>> missing something. >>> >>