The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Michael Kelley" <mhklinux@outlook.com>,
	"Roman Kisel" <romank@linux.microsoft.com>,
	"Arnd Bergmann" <arnd@kernel.org>
Cc: "Dexuan Cui" <decui@microsoft.com>,
	"Haiyang Zhang" <haiyangz@microsoft.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"nunodasneves@linux.microsoft.com"
	<nunodasneves@linux.microsoft.com>,
	"Saurabh Singh Sengar" <ssengar@linux.microsoft.com>,
	"Wei Liu" <wei.liu@kernel.org>
Subject: Re: [PATCH] hv: add CONFIG_EFI dependency
Date: Fri, 13 Jun 2025 18:06:53 +0200	[thread overview]
Message-ID: <c449d792-fcdc-4b08-a76e-519c0a64525d@app.fastmail.com> (raw)
In-Reply-To: <SN6PR02MB4157D600219C00D33D00C3B4D477A@SN6PR02MB4157.namprd02.prod.outlook.com>

On Fri, Jun 13, 2025, at 17:50, Michael Kelley wrote:
> From: Michael Kelley <mhklinux@outlook.com> Sent: Tuesday, June 10, 
>
> There are other ways to express the HYPERV dependency on EFI that is
> conditional. But if the condition includes HYPERV_VTL_MODE (which
> it needs to), then there's a dependency loop because
> HYPERV_VTL_MODE depends on HYPERV. So that doesn't work
> either.
>
> To solve the immediate problem, we'll just have to do
>
>     select SYSFB if EFI && !HYPERV_VTL_MODE

Right. Technically, you could do

    select HYPERV_VTL_MODE if !EFI

but that makes no sense from a usability point of view.

> Separately, if we want to express the broader dependency of
> HYPERV on EFI (at least for ARM64), then the dependency of
> HYPERV_VTL_MODE on HYPERV will need to go away. Three
> months back I had suggested not creating that dependency [1],
> but the eventual decision was to add it. [2, and follow discussion]
> We would need to revisit that discussion.
>
> Arnd -- if you'd prefer that I submit the patch, let me know.
> I created the original problem and can clean up the mess. :-)

Yes, please do, I trust you will come up with a better patch
description than I would.

      Arnd

      reply	other threads:[~2025-06-13 16:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  9:18 [PATCH] hv: add CONFIG_EFI dependency Arnd Bergmann
2025-06-10 15:33 ` Roman Kisel
2025-06-10 15:45   ` Arnd Bergmann
2025-06-10 16:17     ` Michael Kelley
2025-06-10 16:26       ` Roman Kisel
2025-06-10 16:36       ` Roman Kisel
2025-06-10 18:45       ` Michael Kelley
2025-06-13 15:50         ` Michael Kelley
2025-06-13 16:06           ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c449d792-fcdc-4b08-a76e-519c0a64525d@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhklinux@outlook.com \
    --cc=nunodasneves@linux.microsoft.com \
    --cc=romank@linux.microsoft.com \
    --cc=ssengar@linux.microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox