From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0ABA194A60; Wed, 16 Jul 2025 14:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752675812; cv=none; b=m1Vq79FGRj9Bi4GINyWmBC2Eg93KeDDYk0RUJ27qAWXu84iCBpnJUuTclgudajK1cTRkfAAkPUz2L5wk1CzMgiF8h1e33LtHxwiJPX5Ex6g79RW3cORqV+1VjXNp7/HpxgmUYU3W7PkvyqLWsIDojWNnnuvlsb5BPH7MhKbaq4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752675812; c=relaxed/simple; bh=e5zCNgF4CRlQ6UG+BnF+U5KFmnlBVcJj1XukETvxuWw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OECtUJoEZrdOsDlhDllL/Z4iBevOmJjDmg7yOG0fCS/IKJd5vY1Tbk8Pd+XzFzDMmwdNu6MW8OIMOy78kY4aj6GoY+9SnL0hzj6zAAtaYY8BroRmtim1RfEoupE3CMHBrPEibOWqV3nt6sHMWUB9ohHUfX24iSs31f0Zfnf3yH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gMsGVNVJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gMsGVNVJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4D3BC4CEE7; Wed, 16 Jul 2025 14:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752675812; bh=e5zCNgF4CRlQ6UG+BnF+U5KFmnlBVcJj1XukETvxuWw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gMsGVNVJUzfW4rt6liw1e8wbE5wbrvAWvHVCKBH+M6qYfGU2Ve3XnKB0n+4dZ9BKK gqruRHqvERx6D/iVbkdUZYI6Ph8gLLRMcDteRsWVXOTGkSsGrmRkHa6DWmi4pRAFCb erqn7MsW6V+em/Sxs6E6KHtVaX+QwsKbBp5WAPtA49nD/hw+JN3fuH8AsRY1faqTGD VLxYjkAWy63ltTmLGSz9pfjpizl0KwM67C70KRnJUP4A8Ylu6MsVv5WawyNtBBG52U HULPB/AX3Fmk3NsV3PcLGSOEi60GYNJFsFu3NMAJKxh+vM/Ao8aA5z1tCJaxLT6sAI WEE5uKUV+IXpw== Message-ID: Date: Wed, 16 Jul 2025 16:23:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/4] Revert "media: platform: ti: Remove unused vpdma_update_dma_addr" To: Yemike Abhilash Chandra , mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux@armlinux.org.uk, ardb@kernel.org, ebiggers@kernel.org, geert+renesas@glider.be, claudiu.beznea@tuxon.dev, bparrot@ti.com, andre.draszik@linaro.org, kuninori.morimoto.gx@renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com, heikki.krogerus@linux.intel.com, kory.maincent@bootlin.com, florian.fainelli@broadcom.com, lumag@kernel.org, dale@farnsworth.org, sbellary@baylibre.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dagriego@biglakesoftware.com, u-kumar1@ti.com References: <20250716111912.235157-1-y-abhilashchandra@ti.com> <20250716111912.235157-3-y-abhilashchandra@ti.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20250716111912.235157-3-y-abhilashchandra@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 16/07/2025 13:19, Yemike Abhilash Chandra wrote: > This reverts commit 9314891df119442a6ec1518b3d872c330e2bf1a1. > > We're adding support for TI VIP driver, so this is no longer unused. > > Signed-off-by: Yemike Abhilash Chandra > --- > drivers/media/platform/ti/vpe/vpdma.c | 32 +++++++++++++++++++++++++++ > drivers/media/platform/ti/vpe/vpdma.h | 3 +++ > 2 files changed, 35 insertions(+) > > diff --git a/drivers/media/platform/ti/vpe/vpdma.c b/drivers/media/platform/ti/vpe/vpdma.c > index bb8a8bd7980c..da90d7f03f82 100644 > --- a/drivers/media/platform/ti/vpe/vpdma.c > +++ b/drivers/media/platform/ti/vpe/vpdma.c > @@ -552,6 +552,38 @@ EXPORT_SYMBOL(vpdma_submit_descs); > > static void dump_dtd(struct vpdma_dtd *dtd); > Please add kerneldoc. > +void vpdma_update_dma_addr(struct vpdma_data *vpdma, > + struct vpdma_desc_list *list, dma_addr_t dma_addr, > + void *write_dtd, int drop, int idx) > +{ > + struct vpdma_dtd *dtd = list->buf.addr; > + dma_addr_t write_desc_addr; > + int offset; > + > + dtd += idx; > + vpdma_unmap_desc_buf(vpdma, &list->buf); > + > + dtd->start_addr = dma_addr; > + > + /* Calculate write address from the offset of write_dtd from start > + * of the list->buf > + */ > + offset = (void *)write_dtd - list->buf.addr; > + write_desc_addr = list->buf.dma_addr + offset; > + > + if (drop) > + dtd->desc_write_addr = dtd_desc_write_addr(write_desc_addr, > + 1, 1, 0); > + else > + dtd->desc_write_addr = dtd_desc_write_addr(write_desc_addr, > + 1, 0, 0); > + > + vpdma_map_desc_buf(vpdma, &list->buf); > + > + dump_dtd(dtd); > +} > +EXPORT_SYMBOL(vpdma_update_dma_addr); This has to be GPL > + > void vpdma_set_max_size(struct vpdma_data *vpdma, int reg_addr, > u32 width, u32 height) Best regards, Krzysztof