From: Oleksandr <olekstysh@gmail.com>
To: Julien Grall <julien.grall@arm.com>,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: horms@verge.net.au, magnus.damm@gmail.com, linux@armlinux.org.uk,
geert@linux-m68k.org,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Subject: Re: [PATCH V4] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available
Date: Tue, 14 May 2019 19:51:30 +0300 [thread overview]
Message-ID: <c45a056f-80d5-187d-e865-fb66d514830a@gmail.com> (raw)
In-Reply-To: <4e712484-d6a4-e358-ea66-51dfcee18b0d@arm.com>
On 14.05.19 19:13, Julien Grall wrote:
> Hi,
Hi Julien
>
> On 14/05/2019 17:06, Oleksandr Tyshchenko wrote:
>> diff --git a/arch/arm/mach-shmobile/setup-rcar-gen2.c
>> b/arch/arm/mach-shmobile/setup-rcar-gen2.c
>> index eea60b2..64e3abd 100644
>> --- a/arch/arm/mach-shmobile/setup-rcar-gen2.c
>> +++ b/arch/arm/mach-shmobile/setup-rcar-gen2.c
>> @@ -17,6 +17,7 @@
>> #include <linux/of.h>
>> #include <linux/of_fdt.h>
>> #include <linux/of_platform.h>
>> +#include <linux/psci.h>
>> #include <asm/mach/arch.h>
>> #include <asm/secure_cntvoff.h>
>> #include "common.h"
>> @@ -63,6 +64,15 @@ void __init rcar_gen2_timer_init(void)
>> void __iomem *base;
>> u32 freq;
>> + /*
>> + * If PSCI is available then most likely we are running on
>> PSCI-enabled
>> + * U-Boot which, we assume, has already taken care of resetting
>> CNTVOFF
>> + * and updating counter module before switching to non-secure mode
>> + * and we don't need to.
>> + */
>> + if (psci_ops.cpu_on) > + goto skip_update;
> Are you sure this is working when ARM_PSCI_FW is not selected? Is it
> possible to have a .config for RCAR without ARM_PSCI_FW?
Oh, my fault. Mainline shmobile_defconfig has PSCI stuff disabled.
I should have checked for the PSCI operation to be available only if
CONFIG_ARM_PSCI_FW is defined.
Thank you for pointing this out.
>
> Cheers,
>
--
Regards,
Oleksandr Tyshchenko
prev parent reply other threads:[~2019-05-14 16:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 16:06 [PATCH V4] ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available Oleksandr Tyshchenko
2019-05-14 16:13 ` Julien Grall
2019-05-14 16:51 ` Oleksandr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c45a056f-80d5-187d-e865-fb66d514830a@gmail.com \
--to=olekstysh@gmail.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=oleksandr_tyshchenko@epam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox