From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4915D184540 for ; Wed, 13 Aug 2025 21:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755120831; cv=none; b=gc4pprbAaU9Q0dKQ7g5wesTfY+GXhQ6Xasl+MpmMnqeEjS9ybZUbbKJqlg0DZogibXqEwBi5+zDUFUwSERO9s5GZHuf2AHghBXKdWTlAsYUS5jPArL5LxfMCdVUAhIepdoox4x0AI13paguUgmTiqZZarmjNh+YdOy2yqiLuF7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755120831; c=relaxed/simple; bh=uTx6cOJQtxOfCRA/41WV7CyIUJyXISfLg3bbXqEPSrw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sWCX3AQm4K/fCl3kyEweHvCTf2AQVK5sEqeev2ZWH/eBktLrbe90mYaCsUKb+pl4ked8J72Tk/ZTsl07vh5bn3Vp3IoxGj9KSS9KP6rEcdVhFX1IBwHz9koS5jBTR/ZiIElUOOGOsjXPdz5X2eVz4onggKNiHBsKqtY7Z5AHfdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OFH2tCi9; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OFH2tCi9" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-45a1b00f187so1085265e9.0 for ; Wed, 13 Aug 2025 14:33:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755120826; x=1755725626; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mcsR2lpNDjubFi27+my/+Mvy0uMimCUXPssMeKK9hBQ=; b=OFH2tCi9mQ1+W/+FczKPse7GMceU9IVGVn+0B+31sqL91iWd0eruGawnbmGTEmK5gs 957nVTD80EwQQNA8HSeRNqJA60K2OVqc+9sJvY3Q5EzllRFSQEgK8xGLt1FOwHyq6fdL xZXVERSySw6OSj2/MGnowBvA5+McRuG6VeH4EnXA9sfWQjkprjRO/W9rzs8mLnEqz7gt 1WkCzGoNlXuY0wJnho5q6HGK6LR/DMDTXeyfsgcXORTQYl/yOKxoTGOFyoVPBhWdwgSs YQvjfYqaA9KG6o/oWlorwvPm8dFaJYOhZp8/s8DY6xVV4XEbRQFzbP6DFuEUMPXoPCLH QhnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755120826; x=1755725626; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mcsR2lpNDjubFi27+my/+Mvy0uMimCUXPssMeKK9hBQ=; b=haVHwIdP/FRMJ1WuejV2xzdujG9dzLOZ6BL+eGlc2Pn6bMmTG2qwoVge/UryKY1VyF g53x/UinZFj/1ck1Ccn65hm2ybJcgXQQyyeN14b2hV42J33aUJQh2YnfXlpsV321TQkP e6HottF1f3xE323PWxTe9alEuuxe7Wyv6QKPlfmX5tsf5rRAeMle5oXgE8f1nwlfJwqF AnsP5qOzqMX8D+I4g8NkGmWhUDPH8qjRY+oB20fjwnAj7Vgyi1BwW5mtkgi0x6NcN0Of 5ARoZbSbvamyJAO8m81E/jc00H7j6U2aw5Sq4iEOqemSw7DoVDESc8u2d3FOonKWm++h QDUw== X-Forwarded-Encrypted: i=1; AJvYcCWEztDCdG2PrTQmm/QRV5a4Vio7Q5FG0rXAZkzq25obRcVUw8x4xU8e2EGaZZgd9H2ch42SP+sK/WHj0fw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/4HLqma9jkON6djqxkwlDb5J3VYH9ja/jp1UJzMp+VC0ESDS8 GYBQdBa3SRXjCIf07HEpx4AUXt5rbkQjb7Ld2Nao5zPruA1+kIuxv9Vx6SK/1AHfaRE= X-Gm-Gg: ASbGnctsPZAwXsXJIph+5uFR9EqQUO7vm8b0/lF5VUEGRH2XEHkeZQ2D+pOie4ODqvW dFjQeS+vsyeizoXLX47y6Tfbg73AA8rgCXCXvKGsWd5oUS7ldcDRzQiWcYpxcleEQb6GFIqR62q qy2hURem+NZHOGKiNTwAgD7UkWdOb8UOg6fdVozNd8N415ycjA/91JXSOR/C7FSNVRM78ZZUHiz Nlg22fNaOHSUgl4VgTRl6rYGaM7giT8ggbCx2sjL4ww7sXZTPG06MDrlRyuLp7FNKJ0iW+dmSLE lL54rVTArTG8XKf3DUhTaj7fuw58iaXpbqr2b02awoSCaJCMXVyvbAC6h+4RyU/W3ybEwTkP6NY WHuonMqzjairb2ewAqlMi012kltOykxbCSwxdJG1BkNVibeRfAoKcZ90GSphPED89 X-Google-Smtp-Source: AGHT+IFQrbl5wtElBhTcltssVqQElSDpYxXU1Tfejew44z/pIJJpOOHXcbKrIs4k71QsMA33PxUImg== X-Received: by 2002:a05:600c:4708:b0:459:e025:8c5b with SMTP id 5b1f17b1804b1-45a1b674677mr2714735e9.30.1755120826249; Wed, 13 Aug 2025 14:33:46 -0700 (PDT) Received: from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1a53a5e3sm15602925e9.24.2025.08.13.14.33.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Aug 2025 14:33:45 -0700 (PDT) Message-ID: Date: Wed, 13 Aug 2025 22:33:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/7] media: qcom: camss: enable csid 690 for qcs8300 To: Vikram Sharma , rfoss@kernel.org, todor.too@gmail.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250813053724.232494-1-quic_vikramsa@quicinc.com> <20250813053724.232494-5-quic_vikramsa@quicinc.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20250813053724.232494-5-quic_vikramsa@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/08/2025 06:37, Vikram Sharma wrote: > The CSID in qcs8300 is version 690, it is same as csid used in > lemans(sa8775p). csid gen3 have support for csid 690. > > Signed-off-by: Vikram Sharma > --- > drivers/media/platform/qcom/camss/camss-csid-gen3.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen3.c b/drivers/media/platform/qcom/camss/camss-csid-gen3.c > index fc6a9787febe..664245cf6eb0 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-gen3.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-gen3.c > @@ -45,7 +45,8 @@ > #define CSID_CSI2_RX_IRQ_CLEAR 0xA4 > #define CSID_CSI2_RX_IRQ_SET 0xA8 > > -#define IS_CSID_690(csid) (csid->camss->res->version == CAMSS_8775P) > +#define IS_CSID_690(csid) ((csid->camss->res->version == CAMSS_8775P) \ > + || (csid->camss->res->version == CAMSS_8300)) > #define CSID_BUF_DONE_IRQ_STATUS 0x8C > #define BUF_DONE_IRQ_STATUS_RDI_OFFSET (csid_is_lite(csid) ?\ > 1 : (IS_CSID_690(csid) ?\ This really feels like it should be a property of the CSID not of the SoC but... anyway it'll do for now. Reviewed-by: Bryan O'Donoghue