From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A661F20F079 for ; Wed, 12 Feb 2025 13:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739367901; cv=none; b=jJEmYNUtqcrzibO8jovwAiajUJOQCGEtp8vUpuh63QsqEa4xcRIjvArSlVwGGqrj8Fv6oMFNdAm2fcxpxqQvPJOYv5i9sxyIWi7BA23YnG7wQKc9aM2KpOx/sdGRBoODTSzeCXAxaGYFeZpzg5Ai5D5VogQ3cFksE9B0eJtOfpQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739367901; c=relaxed/simple; bh=1N4I54exUcgE3LTlRai6GULrj0a3pJK6dc5b/9sf+V8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pl63/iBsEM2V1srngYqWewVK33Meu740VvK4Z8Wyxs2hsElq9v0yxIB/Mc2cl8a3xarbHMcVpNvrrXlTRFHO2x8KDXjZN3Im++qsqUAvA8JAgfKDXVrN0Mdsq1n2ovsDSznJsTdXdXJ3KFA2y+sRlr0lGl/ev1EJoHRIZB+4EPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eGLt8cg1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eGLt8cg1" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51C672Ei006115 for ; Wed, 12 Feb 2025 13:44:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bcv87hwVFJ59H+rlgvVS9U8o2Zyl8UBZpx3M/46jsWA=; b=eGLt8cg13jFBCs95 yrPopG7sZNOi1ak3UaZIxzK32Z9zTx0VtHzuFulWKVwnu6fmhU5x0gCh6CR9KBGP 3HptCiSTfHzFiFDymejlEFZWMMv4XD1pu5mWfZwUVsW4vea0O0oC5/Lau0VOtSbe ToGZMztFEXKAxtnSvhHTWyf0HsGIiih9PT+k5NkkQLwK9Dn7WJPuv2fe89iie91C jienpfs1fDF22tg981YnrAmkBIvBa1npVfm/8Awhj1DJQAdn9ePdivZWJAhtg2VE pmyEV5cr18DV5BiKZxOKcnlMrMKjfzfD2HPbMTmUCcJbyIxvP/GHS+CrV7jI562i bNU6KA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44qe5mypur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 12 Feb 2025 13:44:58 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c05d579bc2so31720385a.2 for ; Wed, 12 Feb 2025 05:44:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739367898; x=1739972698; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bcv87hwVFJ59H+rlgvVS9U8o2Zyl8UBZpx3M/46jsWA=; b=NcI3zIqbbFBcgryhbGarUPGmB5UEY0tNKzIWWT0rcUjS6d5HLQzxirj2u+Zp6Q0cM7 cEtTiC3kKGKLEZn2cANkHAnBQzZ4x3a3akay2lQDi7osRmHXtP3FMv5v7rKK8Z2RKXw4 q9uQL4C959NkhG29ft6Jc89mWZPunSafRzXA3Lsra1TfG8LasIUOW+N2QgsYh/8U6NmA Sne5OHpvQK8CbATxqNiQ9svJFuUPfreY5t2j5w4yYf/ZphjPzcVJeYGQF88eGwlCnYKk Jo3RMynZnxgViRZGWmga2K07UE6rmj8kxdgkZNm9QJRrytAb8QDpOeZfpvDGM26KYghM H/1w== X-Forwarded-Encrypted: i=1; AJvYcCWGjS9PeUuAo4p8/az+oDvgyPy25O+NV/+GNwMo7A5wRCjsSMni4kjHrM4oZwN1wzcszp6ZZIKT0j3mDSo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5FDeQkq+pdEQMDPrmetQGcN+5GkzyjFRf9c/bvFAR2uLncUX7 W3bPqGfSihZlau/3FZdJBtHQYcx7BBiQJJvaQ95MhsyGSRMpCiYaJKpVuWuA3cKj3+xygam1++U /pMzFKDHwD0ok0lz84MzMUEe3GhtUVAJcf7QSn0oM0hQYi4P8J+40pCEqKnM0uH4= X-Gm-Gg: ASbGnctRLEeCCIeGEQ075gTdnaxItE4/nxyyGB0I17xzwYO501CDc+p4b4Kz/Hht9LR yzISA2R4371/HOMEPXAkbRu46PMZnI0cLbIIaXyzW9ebBGAR2pi/WU3ogkNw4wLYIYp22LvdVA5 J0LpWipqROLe5G/1aKnYCj5iim+hVkM/wWXyae8zNRvENmvzp9ygVU5g67w06rfeVlLHePF61d8 OJQbwLEgZfsxuUTls+jKB/OpqaCJkN5BOj0wrDfFPAaemcVujb5DQYZyBVauUhgxPMVp+tFe7Au utfu1RCs/07qOUsTn/4Sg6FjDUEZqTNOVAugicWz2SHFlBer994PUaKdHv4= X-Received: by 2002:a05:620a:178f:b0:7c0:7818:8563 with SMTP id af79cd13be357-7c0781886f1mr47788185a.8.1739367896994; Wed, 12 Feb 2025 05:44:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHOHyU09alCVQwtWMOufSC23nsnbBXmC6L1k3XnA5cPStmX6pOxlCcBfACplNb3zo+zUrAcFA== X-Received: by 2002:a05:620a:178f:b0:7c0:7818:8563 with SMTP id af79cd13be357-7c0781886f1mr47786285a.8.1739367896515; Wed, 12 Feb 2025 05:44:56 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de51768762sm9483438a12.61.2025.02.12.05.44.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Feb 2025 05:44:56 -0800 (PST) Message-ID: Date: Wed, 12 Feb 2025 14:44:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: display/msm: Redocument the dp-controller for QCS8300 To: Krzysztof Kozlowski , Yongxing Mou , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kuogee Hsieh , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250212-mst_qcs8300-v1-0-38a8aa08394b@quicinc.com> <20250212-mst_qcs8300-v1-1-38a8aa08394b@quicinc.com> <531a23fe-940a-4e9a-b023-5f1789ac65a5@kernel.org> <10d83c88-9f72-4577-95ba-bb1fd1ef36d1@quicinc.com> <5fd75e3d-ee87-439e-b6d4-dd0dd9a0ea2d@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5fd75e3d-ee87-439e-b6d4-dd0dd9a0ea2d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: moKu3gx_jjB1TPvUqI5YqY_npJGCnMvB X-Proofpoint-ORIG-GUID: moKu3gx_jjB1TPvUqI5YqY_npJGCnMvB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-12_04,2025-02-11_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502120106 On 12.02.2025 12:28 PM, Krzysztof Kozlowski wrote: > On 12/02/2025 12:13, Yongxing Mou wrote: >> >> >> On 2025/2/12 16:35, Krzysztof Kozlowski wrote: >>> On 12/02/2025 08:12, Yongxing Mou wrote: >>>> We need to enable mst for qcs8300, dp0 controller will support 2 streams >>>> output. So not reuse sm8650 dp controller driver and will add a new driver >>>> patch for qcs8300 mst feature. Modify the corresponding dt-bingding file >>>> to compatible with the qcs8300-dp. >>>> >>>> Signed-off-by: Yongxing Mou >>> NAK. You just said qcs8300 is compatible with sm8650. I did not ask >>> about drivers, I asked about hardware. >>> >>> This is messy approach. Describe properly the hardware first, instead of >>> sending two conflicting patchsets. >>> >>> Best regards, >>> Krzysztof >> >> Hi, Krzysztof, thanks for reviewing, i want to explain why i submitted >> this patch. Patch >> https://lore.kernel.org/all/20250114-dts_qcs8300-v3-1-d114cc5e4af9@quicinc.com/ >> and >> https://lore.kernel.org/all/20250120-mdssdt_qcs8300-v4-2-1687e7842125@quicinc.com/ >> is the qcs8300 display enablement changes. It base on current linux base >> code and it only support SST mode, so in the SST mode, qcs8300 dp >> controller driver is quite same with sm8650, struct msm_dp_desc only >> have 3 members(io_start, id and wide_bus_supported) and they are same >> both in qcs8300 and sm8650, so we reuse it. BTW, for dp phy hardware >> version, qcs8300 and sm8650 is different. > > No. In one patchset you claim hardware is like that, in other patchset > you say hardware is different. > > Sorry, hardware does not change based on your patchsets. > > Sort out this before posting new versions. In other words, fallback compatibles must be chosen with features that are present in hardware, but not yet supported upstream in mind. It's totally fine (and even preferred/expected) to describe hardware resources (such as MST clocks here) when initially creating bindings for a piece of hw, even though the drivers don't use them yet at that moment. dt-bindings are supposed to give the OS a complete representation of the hardware and ideally be immutable (which is a struggle, but we're getting better). Driver specifics should not influence your decisions (or at least do so very minimally) when adding these. Now you're in a """good""" position as the display bindings haven't been merged yet, so you can still upload a new patchset where the description is more accurate. If it was merged, we'd have to break the ABI or add some crazy workarounds.. Please coalesce this patchset with the "add 8300 display support" one. Please also describe all 4 MST clocks and whatever other clocks/resets that may be necessary down the line. Konrad