From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934308AbcIEUTq (ORCPT ); Mon, 5 Sep 2016 16:19:46 -0400 Received: from mout.web.de ([212.227.15.4]:51676 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932368AbcIEUSd (ORCPT ); Mon, 5 Sep 2016 16:18:33 -0400 Subject: [PATCH 3/7] ACPI-APEI-HEST: Move an assignment in hest_ghes_dev_register() To: linux-acpi@vger.kernel.org, Len Brown , "Rafael J. Wysocki" References: <566ABCD9.1060404@users.sourceforge.net> <9834b713-2c7b-ad6d-76a5-b1db40f561fc@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, trivial@kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Mon, 5 Sep 2016 22:18:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <9834b713-2c7b-ad6d-76a5-b1db40f561fc@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:M8/3JDWZ2KN5a7suL+sK/bJIPCoUX7ZY+whCh/df9fnTRvc7aOf YfOdAN+tq/KYHyDWFjrRgfisw3lle9/lqPvRfGzExLFTP40iaJum0kFbMsQqG2rYyPgtZF5 kdoa5U4iYJcqgTFgknhkIPYwfcYPM1EvcMx8NyFL2Q69KZfZ4D39hwwKh4xU+NYCyIZGiL6 rMXfnokhjSwocbwy3IYBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:iKidZbSygRA=:uUrtb7BHdm/a4G1k1bKyJA s2SVov/sH4Y1URtplDWwy4eJhRddDxUGfNGPRFIDSHUMv9fzsmqppLbyhmovQhLOyy+oXEwab 7aCuFn3l84WUYaH33EyYmITFWVDbCk2dt12I83R8kfPH3ZEsjyKHDe4p45oziv9vaZOpCNEss 3oXR7X9T1c7oDs6iZXaauMou6Jk7piOauKifZvop9KaN7/x+Or9MXUxDREPvye6JtmpQFZdWF mHUZkfmvxeLiCCzm1ay9TlTuGU7IibWIk8BcLDaHOgQMglMqzBCRtXYcT1fptcs0qbgDrR3d+ 7qN8JXcSnAH6ovIUY1vXEKVXRoRu3Rm3q8xFPnPi//P8OndDcozRLqMHWqIR9Prtv3c2R2evK 02xb9Y7gkAerywwHBMeXa09R2khfcj8mYaVzsuNs5H8/pSY1lu2V29UfbPdKnuaQkveypNeXt oWeEhQWf52U+39kvmORrL95uZ8WSIno0ZMC2AzpC1kPI8uNssAk/P95ONKiEQPHsMOP5+g6ON RiQzOlzY6d5DrJmz0XYmanG4U4w1gGz1HnDvy7YSdr8GhTyVUzufjNk8SAuY+4s5lTMuOwUpw MuGgkbAXwKDi0raz8ExzUy4UQ04y8ZTRk34Iq0qRJV2kP+uqh6KeOJG/3Nf4skOWLlrUQoQKl NwTyWXkro/7jg3JLU/sM0LRY90Vw8o2G1oKuOwZW/OAe/3O7QZ4YlrlZ2a3NqN4IbkhEcL8Wy zV832UWy2rAG0AhvwAIc48CrI8kA1OXEfYpm5pqb7TayhCTUylitKrhpVP3nFR7XyRIXnTRa/ tMU/DVJ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 5 Sep 2016 21:15:22 +0200 Move one assignment for a data structure member in one local variable so that its setting will only be performed after a corresponding memory allocation succeeded by this function. Signed-off-by: Markus Elfring --- drivers/acpi/apei/hest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c index a852237..26f5e78 100644 --- a/drivers/acpi/apei/hest.c +++ b/drivers/acpi/apei/hest.c @@ -185,13 +185,13 @@ static int __init hest_ghes_dev_register(unsigned int ghes_count) int rc, i; struct ghes_arr ghes_arr; - ghes_arr.count = 0; ghes_arr.ghes_devs = kmalloc_array(ghes_count, sizeof(*ghes_arr.ghes_devs), GFP_KERNEL); if (!ghes_arr.ghes_devs) return -ENOMEM; + ghes_arr.count = 0; rc = apei_hest_parse(hest_parse_ghes, &ghes_arr); if (rc) goto err; -- 2.10.0