public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Zongmin Zhou <min_halo@163.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Zongmin Zhou <zhouzongmin@kylinos.cn>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usbip: Fix the error limitation on max_hw_sectors for usbip device
Date: Tue, 4 Mar 2025 12:45:28 -0700	[thread overview]
Message-ID: <c49917d2-5157-4878-9866-be6053b5124d@linuxfoundation.org> (raw)
In-Reply-To: <4d4035bf.26b9.19556dcc23d.Coremail.min_halo@163.com>

On 3/2/25 05:37, Zongmin Zhou wrote:
> Dear shuah,
> 
> 
> Yes, I agree with you.It would be better if there have a more simpler fixes than This patch.
> 
> I can just think of the two possible solutions that mentioned before.

What are the two possible solutions?
> 
> 
> If SWIOTLB disabled,dma_max_mapping_size() return SIZE_MAX.

Right when CONFIG_HAS_DMA, if not it returns 0. Perhaps we
can ignore CONFIG_HAS_DMA=n for this for this discussion.

> 
> Only if SWIOTLB is active and dma addressing limited will return the swiotlb max mapping size.
> 
> 
> The swiotlb config seems rely on many other config options like x86_64/IOMMU_SUPPORT and so on,
> 
> and the configuration on host and client side only use the default at all,Like the default ubuntu release version.
> 
> It seems that switlb is enabled by default on most platforms.

If understand correctly the problem happens only when SWIOTLB
is enabled on client or host?

The following combinations are possible:

SWILTLB enabled on client and disabled on host - rate limited?
SWILTLB enabled on client and enabled on host - rate limited?
SWILTLB disabled on client and enabled on host - rate limited?
SWILTLB disabled on client and disabled on host - not a problem

thanks,
-- Shuah



  parent reply	other threads:[~2025-03-04 19:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19  9:25 [PATCH] usbip: Fix the error limitation on max_hw_sectors for usbip device Zongmin Zhou
2025-02-21 16:37 ` Shuah Khan
     [not found]   ` <5a41d6c3.8c78.195371996e0.Coremail.min_halo@163.com>
2025-02-27 22:23     ` Shuah Khan
     [not found]       ` <4d4035bf.26b9.19556dcc23d.Coremail.min_halo@163.com>
2025-03-04 19:45         ` Shuah Khan [this message]
     [not found]           ` <6d47fef6.9eef.19565c308e5.Coremail.min_halo@163.com>
2025-03-10 16:49             ` Shuah Khan
2025-03-13 10:02               ` Zongmin Zhou
2025-03-28 21:14                 ` Shuah Khan
2025-04-02  8:34                   ` Zongmin Zhou
2025-04-08 22:54                     ` Shuah Khan
2025-04-22  6:34                       ` [PATCH] usbip: set the dma mask to 64bit default for vhci-driver Zongmin Zhou
2025-04-22  6:40                         ` Greg KH
2025-04-22  7:24                         ` Christoph Hellwig
2025-04-25  8:08                           ` Zongmin Zhou
2025-04-25  8:28                             ` Greg KH
2025-04-28  9:51                               ` Zongmin Zhou
2025-04-28 10:04                                 ` Greg KH
2025-04-28 23:07                                   ` Shuah Khan
2025-04-30  5:24                                     ` Zongmin Zhou
2025-04-30  7:31                                       ` Greg KH
2025-04-23  1:02                         ` kernel test robot
2025-04-23  7:50                         ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c49917d2-5157-4878-9866-be6053b5124d@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=i@zenithal.me \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=min_halo@163.com \
    --cc=shuah@kernel.org \
    --cc=valentina.manea.m@gmail.com \
    --cc=zhouzongmin@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox