From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB9E31A3140 for ; Fri, 28 Feb 2025 22:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740783517; cv=none; b=tWuaammDA/kL+RqWHrDT4fjSkT+XMmsXzxJVZUYE834Nwvz/GAuDZ6xkQHFQ9dNyRzlG97mhPg2cLOHXjdkRooqfAfmeVHBSoYAIApaONuRbGl5TKmh53NdqUsPJslcOtjv/qvleGht+8pcMGoZ/LKfI4aifWPMNGwrRoHSvsPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740783517; c=relaxed/simple; bh=8Gz+b0IgszYTBoe/or9bnW6RZD40tKLt9gCNI5Vd5Xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XilDsTaUi8gW9vimcZWdHDihZ3fq6f4GTACyb2Rfce54lWgVdEEK6K32SHtsYSgPv8V5Sppege5AHqqAZ8PpSAuSqsFAswdozrnesRuhV+GKDknExdfk4cK4PC8P239/gJpd97d3JhCUlzb3L4QvanNtM4wzuisR5RZdsRGzeYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=S+SoZ1EG; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="S+SoZ1EG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740783516; x=1772319516; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=8Gz+b0IgszYTBoe/or9bnW6RZD40tKLt9gCNI5Vd5Xs=; b=S+SoZ1EG5aXdM6xil4PMTISkXfwpuYyzYNZXYQ3bAkRvZjBhN4WviV9J h+P0kdr2c4Lkxh+E+E7VmBfyuEJ/ehmEEbvJ3ewn7cCPBpNPQtKtSy377 7WyI4sUS2ArnO2gzZJ15XFak0a/QWzrierSkleInl1vZayO5haRKIMHCp ebaBtnDYP6yK5w4OLiLARUiRjxn/3ShqLyUZ/WIHvVNj+hxy4G/ff3Hyf Z8tSlYNtz6tg1HjegVEpSAHJwlnm63wdZAqK03nr8YcnY8dgembmSfeeF Qaf0e8gi332NdDLM6UK1wYM4AMlp+3sOQ5mMXQpq5OB5IinzjwjaW01R6 g==; X-CSE-ConnectionGUID: TkIrTLhrRxSJWbsJXi792g== X-CSE-MsgGUID: jD0kAP+CS6qfFX6O15Q64Q== X-IronPort-AV: E=McAfee;i="6700,10204,11359"; a="29316124" X-IronPort-AV: E=Sophos;i="6.13,323,1732608000"; d="scan'208";a="29316124" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2025 14:58:34 -0800 X-CSE-ConnectionGUID: s7Ey/okBSuWIb79rYkVuWQ== X-CSE-MsgGUID: MHAautXJRZqNrXMmaawR1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="118362553" Received: from puneetse-mobl.amr.corp.intel.com (HELO [10.125.108.197]) ([10.125.108.197]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2025 14:58:34 -0800 Message-ID: Date: Fri, 28 Feb 2025 14:58:47 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -tip] x86/locking/atomic: Use asm_inline for atomic locking insns To: Uros Bizjak Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" References: <20250228123825.2729925-1-ubizjak@gmail.com> <20f1af22-71dc-4d62-9615-03030012222e@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/28/25 14:31, Uros Bizjak wrote: > On Fri, Feb 28, 2025 at 5:48 PM Dave Hansen wrote: >> >> On 2/28/25 04:35, Uros Bizjak wrote: >>> The code size of the resulting x86_64 defconfig object file increases >>> for 33.264 kbytes, representing 1.2% code size increase: >>> >>> text data bss dec hex filename >>> 27450107 4633332 814148 32897587 1f5fa33 vmlinux-old.o >>> 27483371 4633784 814148 32931303 1f67de7 vmlinux-new.o >> >> So, first of all, thank you for including some objective measurement of >> the impact if your patches. It's much appreciated. >> >> But I think the patches need to come with a solid theory of why they're >> good. The minimum bar for that, I think, is *some* kind of actual >> real-world performance test. I'm not picky. Just *something* that spends >> a lot of time in the kernel and ideally where a profile points at some >> of the code you're poking here. >> >> I'm seriously not picky: will-it-scale, lmbench, dbench, kernel >> compiles. *ANYTHING*. *ANY* hardware. Run it on your laptop. >> >> But performance patches need to come with performance *numbers*. > > I don't consider this patch a performance patch, it is more a patch > that fixes a correctness issue. The compiler estimates the number of > instructions in the asm template wrong, so the patch instructs the > compiler that everything in the template in fact results in a single > instruction, no matter the pseudos there. The correct estimation then > allows the compiler to do its job better (e.g. better scheduling, > better inlining decisions, etc...). Why does it matter if the compiler does its job better? I'll let the other folks who maintain this code chime in if they think I'm off my rocker. But, *I* consider this -- and all of these, frankly -- performance patches. > I don't expect some noticeable performance changes from the > non-algorithmic patch like this. TBH, I would be surprised if they > were outside the measurement noise. Nevertheless, I'll try to provide > some performance numbers. That would be appreciated, thanks!