Re: [v3] coccinelle: semantic patch to check for inappropriate do_div() calls

Julia Lawall
2020-01-11T07:44:40Z

> > +*do_div(f, \( l \| ul \| ul64 \| sl64 \) );
> >
> > We agree with Julia:
> > I don't se any point to this.
>
> Can the avoidance of duplicate source code (according to SmPL disjunctions)
> trigger positive effects on run time characteristics and software maintenance?

Markus. Please stop asking this question. You are bothering people with
this advice, why don't _you_ figure out once and for all whether the change
that you suggest has any "positive effects on the run time
characteristics"? Hint: it will not. You don't even have to run Coccinelle
to see that. Just use spatch --parse-cocci on your two suggestions and you
will see that they expand to the same thing. Coccinelle has a pass that
propagates disjunctions at the sub-statement level to the statement level.

julia