From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42624307481 for ; Fri, 3 Jul 2026 16:38:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783096739; cv=none; b=Cq1gg3Gl4gYRIjU8XKeQ1x5Z9fJvvubzgTXSN3ymCqzl45wzHrGT3gCMX2j14TIGLZ2CIl5bHTG5GcZPpFX+F6riBqOrAzHgg2gVHwXj1Q5LWkMoVghkTzz2xv58wWFsvbuzbHiF/abDX+L/GJva5gKO1Br3/wgdNNPw99FepPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783096739; c=relaxed/simple; bh=nrFUeTISsssZEEKhYbH1QGl9yO+vtAmYijszoSwDM+A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gaPRWZmvhTxwiJ0rPynGve8riY/WutyUNipK9j35RG+CgO8r2aaDdzaMj1/1a6LtXQn1Xnv8xia6BC4zoggeZollfVri3hF2vgStDcfYMUNyROLX2r2bFF/qTYDOfffJStudF9u0NU96Bg9BlSNsfitoxKXNU4+2nUz1gi+6biE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ggyc7vlG; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ggyc7vlG" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-490cf3000f0so6668445e9.1 for ; Fri, 03 Jul 2026 09:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783096737; x=1783701537; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Dq50xUh9vnokWwn/2MgFrw6Bt3+wGtcUaeVmHV+z9uw=; b=Ggyc7vlGYIbSvGqthNUShze+DJZAsTFUaDbHlq36g348Cdb5niXyXxp+sUWKHgjZWW eAktUxb/FEeX2zjqolnvhIFfjnsSUM6IF+vE0DeFqf2e2MklvJ8S24i3B6z6IMQ+ZY57 9fHaoxM8umqHAHCrQ/dL+d7M3gZqPtFvsf6FWe0+LEzGlVDNpXdJsP7zlzGMXwogqbPm 6El1qBPJ5EOA+2SusUKKkFY+eO2ZuhsElxh+wP4lOQu4/Rqad1xhZUlR1/P9B07S/iw0 dos78O+MNfgcRplb6Pal03bPOllpnhKNakd0DUCNuEPonPvHYJHLGjmZ25GfyhNZJvfH 9QEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096737; x=1783701537; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dq50xUh9vnokWwn/2MgFrw6Bt3+wGtcUaeVmHV+z9uw=; b=pokQurF55EkSxWIX9N6pOKtpErUGEvJEGk31P4mNww0JtZLmin2vMNdOpn/gmdCmEs sVE65q1df/tVk9BIEfTHVVan/h6JDl8dj6BLcODCEq0jhR9JGcdJBUkpR5wL2ej4kA7N e9P7/DpCUb+t4+6GKZRURIIRP6nK9PrqGj+SHUdyWw2gSLZdV81e42ab6miuvxVDxr8T 5I+syMgD2Lra/BtjouaH3JtdF0h6stYTrYzngQSWFqnlCA03IOJmCuNaewBU4EzoKlNU yUIm2bHXNrtxTYvqRU/LF/5cfIP3xuCTlWghQfsfbEtFERfolYM8u+X9ZKL8TK3jst8S 4Leg== X-Forwarded-Encrypted: i=1; AFNElJ95Zn/0MsjOVeYtCvGmlkJtkrSTDRPdAMvOZVrOGH5eoBmgF3xJq9ZLfF+2eNDxwzTUDvAgtufNAF6OSeM=@vger.kernel.org X-Gm-Message-State: AOJu0Yww1iOHF4JbQk5b1lyNZbaC6k2hYuMV0KD53/ecg3cXUVeElJsX 5Vfdj6y4lG7V+MrEbyIkIKVeymzxk4coKTSkKulAlLZj9GchrkkeVJEI X-Gm-Gg: AfdE7cnShsUOVrt+YWi4L30+rbuDVXw5x5C3bKIccCoqMrfxbxnPTYDzmk9ite8lXq4 g+3UTsjT0m7iaZJocquT8IfeJiPYS3AoPaLED9NmrNZ5ZRYy4TOUhVzPYgzrlvizZtPciv9i+aR aiahHnM2OlIgGGgXvxwG+lFbnGe45GDXpSVSkKeqEh1QSmJ3JRLpDJ2knHRQvB/cKkKQXtlI50n v78qEXTskWLmh1Jbs8yQmUqPfnSzPYH2ZKTjI76eYm0Kj9oya+QJETastPG0J9AGoqduOY69qog MKV2tgWn9kOmn2KOMAfw4bcJRRclSMqZI6woaajMxpo7Dt2RC0Z400o+986+x/JzooV8XNT6HEt 6G3xfpt/DrjZNXzVJx/MPyJ7VwI+1+4nT9Cw30ukevai/qTr8bkWtPoGjreyfQYAcsvmIvFS0xu ZoDgBuCpfXIqn5EpeDctYjAPV5fnY8GsTdgfChI+BVd8zfGBWKMqBkeI7gzSJdj0yGZ4qMLvkj8 dDpTse6 X-Received: by 2002:a05:600c:8105:b0:493:aaa2:f034 with SMTP id 5b1f17b1804b1-493d11f6cfamr400035e9.26.1783096736053; Fri, 03 Jul 2026 09:38:56 -0700 (PDT) Received: from [10.128.11.240] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce040b4sm82259395e9.10.2026.07.03.09.38.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 09:38:55 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Fri, 3 Jul 2026 17:38:53 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] pwm: rp1: Add RP1 PWM controller driver To: Andrea della Porta Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , linux-pwm@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Naushir Patuck , Stanimir Varbanov , mbrugger@suse.com References: <0b6a7f41-b753-48dc-b46e-77aaf0e999f4@gmail.com> <6babbdea-fa93-4cd7-8198-5cd3accc34cc@gmail.com> Content-Language: en-US From: Julian Braha In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Andrea, On 7/3/26 15:56, Andrea della Porta wrote: > Honestly I don't have a strong opinion on that, but documenting is basically > the same than just selecting the option (well with the addition of the #), so > not really a difference. If there's no major concern about that I also wouuld > prefer to expicitly declare teh selecion of REGMAP_MMIO. My preference seems to be unpopular, so I've adjusted my reviews. - Julian Braha