[PATCH 0/2] Blackfin: Adjustments for two function implementations

[PATCH 0/2] Blackfin: Adjustments for two function implementations

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 May 2017 20:00:02 +0200

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter()
  Delete an error message for a failed memory allocation in isram_test_init()

 arch/blackfin/mach-common/pm.c  | 4 +---
 arch/blackfin/mm/isram-driver.c | 1 -
 2 files changed, 1 insertion(+), 4 deletions(-)

-- 
2.13.0

[PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter()

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 May 2017 19:29:25 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/blackfin/mach-common/pm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/blackfin/mach-common/pm.c b/arch/blackfin/mach-common/pm.c
index 5ece38a5b758..f4d442b7a1a1 100644
--- a/arch/blackfin/mach-common/pm.c
+++ b/arch/blackfin/mach-common/pm.c
@@ -151,10 +151,8 @@ int bfin_pm_suspend_mem_enter(void)
 					 + L1_DATA_B_LENGTH + L1_SCRATCH_LENGTH,
 					  GFP_ATOMIC);
 
-	if (memptr == NULL) {
-		panic("bf53x_suspend_l1_mem malloc failed");
+	if (!memptr)
 		return -ENOMEM;
-	}
 
 #ifndef CONFIG_BF60x
 	wakeup = bfin_read_VR_CTL() & ~FREQ;
-- 
2.13.0

Re: [PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter()

[Al Viro]

On Wed, May 24, 2017 at 08:03:45PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 24 May 2017 19:29:25 +0200
> 
> Omit an extra message for a memory allocation failure in this function.

That's no extra message, that's "won't continue past that point if it happens".

> This issue was detected by using the Coccinelle software.

... which absolves you of any need to think, presumably.

[PATCH 2/2] blackfin: Delete an error message for a failed memory allocation in isram_test_init()

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 May 2017 19:39:32 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/blackfin/mm/isram-driver.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/blackfin/mm/isram-driver.c b/arch/blackfin/mm/isram-driver.c
index aaa1e64b753b..4221b07a61dc 100644
--- a/arch/blackfin/mm/isram-driver.c
+++ b/arch/blackfin/mm/isram-driver.c
@@ -374,6 +374,5 @@ static __init int isram_test_init(void)
 	if (!sdram) {
 		sram_free(l1inst);
-		pr_warning("SKIP: could not allocate sdram\n");
 		return 0;
 	}
 
-- 
2.13.0