From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAEB8C4363A for ; Mon, 5 Oct 2020 08:05:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8682520756 for ; Mon, 5 Oct 2020 08:05:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726019AbgJEIFw (ORCPT ); Mon, 5 Oct 2020 04:05:52 -0400 Received: from smtprelay0174.hostedemail.com ([216.40.44.174]:34992 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725898AbgJEIFw (ORCPT ); Mon, 5 Oct 2020 04:05:52 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 5F708182CF668; Mon, 5 Oct 2020 08:05:51 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: bite38_220bb4e271bc X-Filterd-Recvd-Size: 1817 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Mon, 5 Oct 2020 08:05:50 +0000 (UTC) Message-ID: Subject: Re: [PATCH RFC] checkpatch: add new warnings to author signoff checks. From: Joe Perches To: Dwaipayan Ray Cc: linux-kernel-mentees@lists.linuxfoundation.org, Lukas Bulwahn , linux-kernel@vger.kernel.org Date: Mon, 05 Oct 2020 01:05:49 -0700 In-Reply-To: References: <20201005064842.33495-1-dwaipayanray1@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-10-05 at 13:10 +0530, Dwaipayan Ray wrote: > On Mon, Oct 5, 2020 at 12:48 PM Joe Perches wrote: > > On Mon, 2020-10-05 at 12:18 +0530, Dwaipayan Ray wrote: > > > The author signed-off-by checks are currently very vague. > > > Cases like same name or same address are not handled separately. [] > > And for mismatches, it's really not known that > > it should be one way or the or the other is it? > > > > I think that's true. But since the mail in the > From: part is the one which with others are being > compared, I think maybe it should have the higher > priority, and be treated as the expected one. I rather expect it to be the other way around. The Signed-off-by: line should be authoritative as that is what is put in the commit log.