From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012005.outbound.protection.outlook.com [52.101.43.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7093613635E for ; Tue, 28 Apr 2026 11:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.5 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777374315; cv=fail; b=IfufThz3HvZUXVebaAykZ7K0/MoVLbzyAkda9qxRG7AOnJ/HgIlgLwspgozTzlPk5lq3X+3flqxcJyi5OjAFKU22ZVXoHzbuI052yL9bIeDe2LAQgWDuuB5RiAOSAqNNnbtOXyUC7zwXjMZA/orbFPs2+DQ/iWmQWu2TWS/Bz28= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777374315; c=relaxed/simple; bh=Y9DiGUIApgoxmg8Q26GCJ1FlnHi/L99Tia/3vnwQrXk=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=oEpX5BqxbMjw2k6fBWpV1lzFPfAlb5cHSXJwEo7PFDb2rP/MUGinMZiT1E5gpVWUdZrh39+6m3XU2X+lvmAVYsikdBmhK/ZEt2eMOhrU98L6TfPoq4zEVR8Zv1BkcKReJK7LiLX4oNGRCldoOqHKIPJNKxrgtLTEHazJ/fJPHuU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=V3nk1Dpk; arc=fail smtp.client-ip=52.101.43.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="V3nk1Dpk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DpxO8ygWnzHjL+foXQKDAPhHFhYpx/Zud8at4U2HBxpFICw9QvmX68htc/xrgyncndyHHvGXnbeP1y9UJRJ4Q9oaR2BBoRc3F4KBhM7Rjii/CiIhc2TVlebMNHyrX4G5eB8OPj2LNYQ62aLEOzAsNswzFGCDOWGEzFSfhzTBo0LzTNel9jYMzkef1rqRfKj9bcf1ol9tywQjSB/NcK96AO7obfmaYmV29I/p4BWDTwLGQZN3TBJEheKYfJy3Hg0iyztRVg2GenZc6aTNzkXHsmLIK+PvsMc6NqujLH65tVttF1jv5kxwgwVmI9RVtr4xqPj/QGGxFxeoy11D1y2B2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gJsmIIV6nd0FY+tbtGequzJfQqa0ja9Xf1QRVvP1Foo=; b=BmPlGUvAfL92TTuJuRri06T+suHk4aum7Sb586U46T2fGJut35nzZaj3g1oF375ek87sFrLGT7nsQ6WMLwBbpwVZWR6SamRw/o6fZf3/RRQJhr2n9ijlkkQoxGtj8ZH5Ik2IQQ44Z65J6TaFIlTEb2dQhNTO0N6yQckyIKi53J2jPopbVTzPVc1/3cDEvuvr1MBjmIoBdBc/XpSTnNtUqR3qn6wZ0S8F1nx6NaHUNYXbz5LPcwdyD1/4Wt8/3JqX2q9vAB2gWXJqLMLAHNCv6Ns11C1ys1tq4b8RE/dOUDSw7+JfNei4Z8H9TDlgBz/HxcDWIc6wDH7Bui/jYBNXNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nvidia.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gJsmIIV6nd0FY+tbtGequzJfQqa0ja9Xf1QRVvP1Foo=; b=V3nk1DpkYf7bkKDyh1g4i66x8UulXlGg6hxcOU+zvUxgSQd8apOpSEYa5w2FCjYHNPRzY2xszEnpHnyh/bbMgCoy14rNGETyF6NTtGOKWWD0qppabf3PHXG9mByGBqMzJGy5KW+Ng+oWMtsDQZa3QLruFvitF2m+7cd8mThHFXY= Received: from PH7PR02CA0029.namprd02.prod.outlook.com (2603:10b6:510:33d::6) by MW4PR12MB7240.namprd12.prod.outlook.com (2603:10b6:303:226::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.18; Tue, 28 Apr 2026 11:05:08 +0000 Received: from CY4PEPF0000FCC1.namprd03.prod.outlook.com (2603:10b6:510:33d:cafe::80) by PH7PR02CA0029.outlook.office365.com (2603:10b6:510:33d::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.28 via Frontend Transport; Tue, 28 Apr 2026 11:05:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CY4PEPF0000FCC1.mail.protection.outlook.com (10.167.242.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Tue, 28 Apr 2026 11:05:08 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Tue, 28 Apr 2026 06:05:04 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 28 Apr 2026 06:05:04 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Tue, 28 Apr 2026 06:04:58 -0500 Message-ID: Date: Tue, 28 Apr 2026 16:34:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] sched/fair: Use guard(rcu) for sched_domain RCU sections To: Andrea Righi CC: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , "Mel Gorman" , Valentin Schneider , "Christian Loehle" , Koba Ko , "Felix Abecassis" , Balbir Singh , "Joel Fernandes" , Shrikanth Hegde , References: <20260428051720.3180182-1-arighi@nvidia.com> <20260428051720.3180182-2-arighi@nvidia.com> <0882ce78-a51f-4317-a1b4-624e39e65507@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Received-SPF: None (SATLEXMB03.amd.com: kprateek.nayak@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC1:EE_|MW4PR12MB7240:EE_ X-MS-Office365-Filtering-Correlation-Id: 305a134b-38a1-48e1-39f1-08dea5160283 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|376014|7416014|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: PR9/pzDl64tUnTyMKAtZcKbxAOaKmpGbUlWwEdASPZUmzuH1ExYZJSu0Wy1Nh8V1oKmtR7qQ/2i6c3L/A3tQWzCfZlzxtJXQR80qJUWVwD2Zkof7LiP1HTj6sPlFR9jSfO4oA8nfakBUM6rn/YR3pYJK6XgIW2bQrL5MahNrkPk3EXn1hy3faLIqS8UmrjEtuK3elPBwN9SedHd6wGqwsFzahgbwT6/0G7XHhIQFoXYe9vItsS2O7Px1F8+WkIjPR4wl/q/wHAbsU8w4hf/WMJAlCKst3Oe1POLpFNlTP5/raKrn4AKWeKAxc2SXmqTrTPm+S5wkaLMjjqJwW2gG+kT0LVyLmiDj91bXu/Rng9vl+7UycOWjXIjogEHX+SPOKssREe8hWTSWPa1Tp4i0BRgHzz7CEWhHGVfX9xaw2gAf0HJaG1uDmpYexGSlKuJicl0draDk+cfzLwAKqow7muHF4LRQoRQXampv8wfVB1YktclJToPU82+ow+SWIPHM1ihztTpyILi4QRlTP24vmsSXIPo4nvQ/93jJT8UEBFaVhWhABoxUvSJ7DNGOPHiNZtQVhypGZSw1j1MzRT56PcHpqkpSN35sRG1q0YhZVDa6NuxPUK1pbbuzpBehtLXQpZheoT3o2EuQYFTi1AoKrSyz9fQw0YDxWQH7AYb+jtWwj88rvTnnj52dTJB+CvE4d3HJFWWKzZo1sATvx0eCZJHKCcn7MsUOgsfOkjWuhPkxaNULKnFAsWw2NUBi7p7EMbdauQpRrkIT/CjmZIb6nA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(376014)(7416014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Gg+baPErsmrhVpQbQZuO8C+3FhDcwm6kynLIFwvYWoefKJyYQbQKpd3i+CWXfUdJMmc0LFCLMILhgHTimTJ5eEybmX4lSmPN3Z2ndN37h3jS7RcWdAVhGPPa/S4AfI9tD+1HX6BAJudfodYbyyPNnooeBC8xJyp4xDFCzlgAZeX29v1Wga1fjFIFZirLWbiFuXmuCE1b91sNwADhkqU7p2ATdNGSUoDYjOX9iYWURSE7tsAHohlOOCifKsXwORgzp1vElpVXx6S2EZ4WeTCJ2j+BlZFeMNLtowGA94GUCqVfbcoEkSNF8e75nKtfUYsH90d9Dv3YPz5LhL7jKms4Prb5LZycfMudo6UfwJYHjSDgooTtz2oqgI62oelJLKweYhGs2zYQTeyGU5gfNbJc2eOCm14mUKPCUi0Et6cg4oRBjhdYX5dfhMtct/6rtp31 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 11:05:08.2333 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 305a134b-38a1-48e1-39f1-08dea5160283 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC1.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7240 Hello Andrea, On 4/28/2026 4:13 PM, Andrea Righi wrote: >>> - rcu_read_lock(); >>> + guard(rcu)(); >> >> and since this is only called from: >> >> sched_tick() /* IRQs disabled */ >> sched_balance_trigger() >> nohz_balancer_kick() >> >> with IRQs disabled, we can get rid of that rcu_read_lock() entirely. > > Yeah, all makes sense. I'll update the patch dropping rcu_read_lock/unlock() > completely. > > Is it worth adding a lockdep_assert_irqs_disabled()? Yes, that would be nice. Thank you! -- Thanks and Regards, Prateek