From: "Miquel van Smoorenburg" <miquels@cistron.nl>
To: linux-kernel@vger.kernel.org
Subject: Re: dd PATCH: add conv=direct
Date: Thu, 8 Apr 2004 11:44:59 +0000 (UTC) [thread overview]
Message-ID: <c53dvr$911$1@news.cistron.nl> (raw)
In-Reply-To: 20040407220928.GI2814@hexapodia.org
In article <20040407220928.GI2814@hexapodia.org>,
Andy Isaacson <adi@hexapodia.org> wrote:
>On Wed, Apr 07, 2004 at 05:02:24PM -0500, Nathan Straz wrote:
>> On Tue, Apr 06, 2004 at 05:03:58PM -0500, Andy Isaacson wrote:
>> > Linux-kernel: is this patch horribly wrong?
>> ...
>> > to force O_DIRECT. The enclosed patch adds a "conv=direct" flag to
>> > enable this usage.
>>
>> Adding the functionality to conv= doesn't seem right to me. conv= is
>> for converting the data in some way. This is just changing the way data
>> is written. Right?
>
>There's already conv=notrunc which means "open without O_TRUNC". I
>agree that it's a nonintuitive interface, but then, the entire dd(1)
>command line is.
Well as you already added iflags and oflags, it makes more sense to
use those. oflags=fsync makes more sense to me than conv=fsync.
Likewise oflags=notrunc.
Mike.
prev parent reply other threads:[~2004-04-08 11:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 22:03 dd PATCH: add conv=direct Andy Isaacson
2004-04-07 0:33 ` Andrew Morton
2004-04-07 16:21 ` Bruce Allen
2004-04-07 16:42 ` Andrew Morton
2004-04-07 17:31 ` Andy Isaacson
2004-04-07 18:18 ` Andrew Morton
2004-04-07 19:24 ` Andy Isaacson
2004-04-07 19:34 ` Andrew Morton
2004-04-07 19:47 ` Andy Isaacson
2004-04-07 20:03 ` Andrew Morton
2004-04-07 20:43 ` Andy Isaacson
2004-04-07 21:00 ` Valdis.Kletnieks
2004-04-07 21:35 ` Bruce Allen
2004-04-08 6:56 ` Paul Eggert
2004-04-08 11:07 ` Jim Meyering
2004-04-08 19:32 ` Paul Eggert
2004-04-08 19:51 ` Paul Jarc
2004-04-08 21:34 ` Jim Meyering
2004-04-08 16:23 ` Philippe Troin
2004-04-08 20:20 ` dd patch to remove noctty Paul Eggert
2004-04-08 21:40 ` Jim Meyering
2004-04-09 0:37 ` dd PATCH: add conv=direct Anton Blanchard
2004-04-09 1:42 ` Wim Coekaerts
2004-04-10 21:28 ` Jim Meyering
2004-04-07 20:46 ` Paul Eggert
2004-04-07 21:06 ` Andrew Morton
2004-04-07 21:09 ` Andy Isaacson
2004-04-07 19:12 ` Miquel van Smoorenburg
2004-04-07 20:14 ` Andy Isaacson
2004-04-07 22:02 ` Nathan Straz
2004-04-07 22:09 ` Andy Isaacson
2004-04-08 11:44 ` Miquel van Smoorenburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='c53dvr$911$1@news.cistron.nl' \
--to=miquels@cistron.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).