From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BDE1239085 for ; Wed, 6 May 2026 04:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778042103; cv=none; b=VVWMcRjlFzhGHjkMdQqT3tP6mMIOiNZsb+ipGNib6jEKrZrSc8QjCu3pZSC5tJl+o/x5KbsZV4rk2564WiM7mnBgFhaLqzGIm/so7q92QSwH/bCQEi/utgLUrziPN9wdnVNaayYuEnCE3c/OSQ7rrMuEwEaLXdCUyB+qvEPLuDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778042103; c=relaxed/simple; bh=tWNh02pUiTr80ilyrsnlKKawbL+ZaDWaGbzNR9y0jQs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qn8IthRHUC5UEr6OyK8yxVUU0v1zr31hzfcGzhfejrHlz1tjwCfbUXHCTQAQ6SrWvsfmb5hzRcQN17+/RZvv8cJ3K6xyYljs4Ahry6qL0K982sqfv0rkORxbQaUFxiOZSAHZ/jzlBwlwcXIo0XYsthy+WhdtABHDzfO5BgkskH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=rdnZ42K1; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="rdnZ42K1" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 645K6qdE2808530; Wed, 6 May 2026 04:34:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=tYeGJn UiR+pJlwKQlOjTGBVTkpn+nHsGOg6LYM+Gjy0=; b=rdnZ42K13x26sE1dyRZze9 yxjyRcsz9C1ccvndjqImRPEyOx3gstpXX+/YmJA280/ZTxw2SjTFvlNB8UzIp4V8 yXZw/+UdWtndRiF1UwG1xUG7tgu4tQN1mt6PZwAyMTYj1IRLFT5r4wF/0eCf/8tE 6GShg0l9jYYhH782fnhGGGcNb3SkQhpZ/cnmb1ryeOxck9865EwjpjL6zMC335U2 j/4qltk94MRj4BzbuVMkVWYYwFCwVm/okZSLKKezkVeeLA5QJWQ/vVrsUK9E3JJD LIjHywKu20ps4GjC0Ilsmwi176jhlrZExbyVXunKoPBA14PfdN6NnX5kYNxPzYSA == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dw9y1exba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 May 2026 04:34:44 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 6464OpXg015802; Wed, 6 May 2026 04:34:43 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dwwtgcghc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 May 2026 04:34:43 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6464Ygek28574324 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 May 2026 04:34:43 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB41C5805A; Wed, 6 May 2026 04:34:42 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5523A58051; Wed, 6 May 2026 04:34:39 +0000 (GMT) Received: from [9.124.209.5] (unknown [9.124.209.5]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 6 May 2026 04:34:38 +0000 (GMT) Message-ID: Date: Wed, 6 May 2026 10:04:37 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] powerpc: fix dead default for GUEST_STATE_BUFFER_TEST Content-Language: en-GB To: Julian Braha , maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, jniethe5@gmail.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260405161545.161006-1-julianbraha@gmail.com> From: Harsh Prateek Bora In-Reply-To: <20260405161545.161006-1-julianbraha@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: ggCt4CKrVVX0AWEJauPCYx9o4_NofMXm X-Proofpoint-GUID: k8o3kzIb6igVr8HKgZABaI17iwiuwViq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDAzNyBTYWx0ZWRfX+Ku9GwQtdbCU D3V4+SD2YwkW8B/L16DxHXNIBXc+nMPkY1s+7Qp/GKJRVkcMU67ApHxCzR1HeYcc/KOPMj+EKrO j8eU53UWpf0iAp54CLbxxJlbHLfKM3qbWm43mpDvk2iJEWAv+4Li0VbP+bVNLadgcCw57sZSaLg tLWQtV8kQwMBi6+F8E4PVnI+hnbv0nEQa8nnx/5tyA/udje1VNNz+lGkBbrfDRJyM7Dv4atbM5p RXbdP48vHu6K1ouGNB+KNCel6y0lGKXeQwRj331zGZGhv5LWmSLpQdlHpTi+0nTI1hkaD9/LAKI lDDYln1/NCLC/qhBL8dDWcwL6d531S0Y0xDNCTIzCnLJTaZLMDQKfuJEoxZVLdkfUvCf/Kip4qR uiLpluuPwIjPTVw1zCa389pP18BICRVu1S64kffxKhOHStz6m7NPaUKBsL2bRy+W8Ds78rCGxrJ x+TX2mB0ALhfwZp4DCQ== X-Authority-Analysis: v=2.4 cv=UbFhjqSN c=1 sm=1 tr=0 ts=69fac4e5 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=f7IdgyKtn90A:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=pGLkceISAAAA:8 a=VnNF1IyMAAAA:8 a=asDfj_d41YawczLiECMA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060037 On 05/04/26 9:45 pm, Julian Braha wrote: > The GUEST_STATE_BUFFER_TEST config option should default > to KUNIT_ALL_TESTS so that if all tests are enabled then > it is included, but currently the 'default KUNIT_ALL_TESTS' > statement is shadowed by 'def_tristate n', > meaning that this second default statement is currently dead code. > > It looks to me like the commit > 6ccbbc33f06a ("KVM: PPC: Add helper library for Guest State Buffers") > intended to set the default to KUNIT_ALL_TESTS, but mistakenly > missed the def_tristate. > > This dead code was found by kconfirm, a static analysis tool for Kconfig. > > Fixes: 6ccbbc33f06a ("KVM: PPC: Add helper library for Guest State Buffers") > Signed-off-by: Julian Braha Keeping the commit title as "powerpc: correctly enable KUNIT_ALL_TESTS as default for GUEST_STATE_BUFFER_TEST" might look better. Anyways, Reviewed-by: Harsh Prateek Bora > --- > arch/powerpc/Kconfig.debug | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug > index f15e5920080b..e8718bc13eeb 100644 > --- a/arch/powerpc/Kconfig.debug > +++ b/arch/powerpc/Kconfig.debug > @@ -83,11 +83,10 @@ config MSI_BITMAP_SELFTEST > depends on DEBUG_KERNEL > > config GUEST_STATE_BUFFER_TEST > - def_tristate n > + def_tristate KUNIT_ALL_TESTS > prompt "Enable Guest State Buffer unit tests" > depends on KUNIT > depends on KVM_BOOK3S_HV_POSSIBLE > - default KUNIT_ALL_TESTS > help > The Guest State Buffer is a data format specified in the PAPR. > It is by hcalls to communicate the state of L2 guests between