From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C62CA2D59E9 for ; Mon, 25 Aug 2025 10:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756118280; cv=none; b=YOSjpeNFrWNAuXKzjmYoiBp0hI64Xe1JrshFmLu3V8i0KX6alLrQNOYUX9wM19jjYalZiaN7Qap8PURLtqE4btPwX/QLJZS6HBQFPdodZn2OyGkd6qZfrfwm6J514j6ZeSa1mhSyu92756RALGkMUbqY3N8yvjTYne0QpEEytPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756118280; c=relaxed/simple; bh=e1nR2s50qhicERGHdK8MQ9XDEVOrB0MuAdclmZvHDGU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Nasl0iwu8hEUuCTIuPnm964j9I3cxoFSgnERdYc5U4gmbOeRX+oTCqCi4hjqahM9ljMUPeFOB2SXhvV0lyZY/K9yZEhwLxJMytA179xgXLf0KkT08WzcQRP+guFaCgCsGIzcCTfSmiA6IQgLD4yF/kKCUCX8VkbBy5Bk5jHMc6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uqUZi-0001ab-FF; Mon, 25 Aug 2025 12:37:18 +0200 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uqUZe-0023HK-2d; Mon, 25 Aug 2025 12:37:14 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1uqUZe-000M78-2I; Mon, 25 Aug 2025 12:37:14 +0200 Message-ID: Subject: Re: [PATCH v10 07/13] media: rockchip: add driver for mipi csi-2 receiver From: Philipp Zabel To: michael.riesch@collabora.com, Mehdi Djait , Maxime Chevallier , =?ISO-8859-1?Q?Th=E9o?= Lebrun , Thomas Petazzoni , Gerald Loacker , Bryan O'Donoghue , Markus Elfring , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Reichel , Collabora Kernel Team , Paul Kocialkowski , Alexander Shiyan , Val Packett , Rob Herring , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Date: Mon, 25 Aug 2025 12:37:14 +0200 In-Reply-To: <20240220-rk3568-vicap-v10-7-62d8a7b209b4@collabora.com> References: <20240220-rk3568-vicap-v10-0-62d8a7b209b4@collabora.com> <20240220-rk3568-vicap-v10-7-62d8a7b209b4@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Di, 2025-08-19 at 01:25 +0200, Michael Riesch via B4 Relay wrote: > From: Michael Riesch >=20 > The Rockchip RK3568 MIPI CSI-2 Receiver is a CSI-2 bridge with one > input port and one output port. It receives the data with the help > of an external MIPI PHY (C-PHY or D-PHY) and passes it to the > Rockchip RK3568 Video Capture (VICAP) block. >=20 > Add a V4L2 subdevice driver for this unit. >=20 > Signed-off-by: Michael Riesch > Signed-off-by: Michael Riesch > --- > MAINTAINERS | 1 + > drivers/media/platform/rockchip/Kconfig | 1 + > drivers/media/platform/rockchip/Makefile | 1 + > drivers/media/platform/rockchip/rkcsi/Kconfig | 16 + > drivers/media/platform/rockchip/rkcsi/Makefile | 3 + > drivers/media/platform/rockchip/rkcsi/rkcsi.c | 741 +++++++++++++++++++= ++++++ > 6 files changed, 763 insertions(+) >=20 [...] > diff --git a/drivers/media/platform/rockchip/rkcsi/rkcsi.c b/drivers/medi= a/platform/rockchip/rkcsi/rkcsi.c > new file mode 100644 > index 000000000000..5658ffb60769 > --- /dev/null > +++ b/drivers/media/platform/rockchip/rkcsi/rkcsi.c > @@ -0,0 +1,741 @@ [...] > +static int rkcsi_probe(struct platform_device *pdev) > +{ > + struct device *dev =3D &pdev->dev; > + struct rkcsi_device *csi_dev; > + int ret; > + > + csi_dev =3D devm_kzalloc(dev, sizeof(*csi_dev), GFP_KERNEL); > + if (!csi_dev) > + return -ENOMEM; > + csi_dev->dev =3D dev; > + dev_set_drvdata(dev, csi_dev); > + > + csi_dev->base_addr =3D devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(csi_dev->base_addr)) > + return PTR_ERR(csi_dev->base_addr); > + > + ret =3D devm_clk_bulk_get_all(dev, &csi_dev->clks); > + if (ret !=3D RKCSI_CLKS_MAX) > + return dev_err_probe(dev, -ENODEV, "failed to get clocks\n"); > + csi_dev->clks_num =3D ret; > + > + csi_dev->phy =3D devm_phy_get(dev, NULL); > + if (IS_ERR(csi_dev->phy)) > + return dev_err_probe(dev, PTR_ERR(csi_dev->phy), > + "failed to get MIPI CSI PHY\n"); > + > + csi_dev->reset =3D devm_reset_control_array_get_exclusive(dev); Why array? rockchip,rk3568-mipi-csi bindings specify a single reset. regards Philipp